Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1575520ybh; Sun, 8 Mar 2020 07:40:56 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuuu1HK/hJxYgn9bQMgREXfORs0p2P8vqm2hImDzp12sdjnzjC9hYLBzeTni1aAYwCsA5rA X-Received: by 2002:a05:6830:2391:: with SMTP id l17mr7399894ots.339.1583678456029; Sun, 08 Mar 2020 07:40:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583678456; cv=none; d=google.com; s=arc-20160816; b=xGv3Cwtmdrg+hciw7jo2w2XB9R2aCm48A59X0nY9yetxPi0msNQTiGxHnDuKn4rfqZ YMcTgyORnQqkvEv9YF1aMGQnmkNdiO0ZbgMqoKyygNju0e/giGGSR1PWMZTQlf7X8iw3 AohOYQj1nvdjcpianS0/bv1hWBt2cc2eOrqJ2GYEpdGSIawNkVr2+gV+uj6TKaN+TR+Q SzFDUr1W30yY0M8jh7dIc/WaWfoC/33k13M9XSoth783J/AVG1d+3o/AA92RlQEFZCJc ZngcdC9dE64byqiX0Tif8G7xB/uIcBlWiMH6yR3yfyY7pAH+ItEsYYlQTS+PUP6ZQbYa QitQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=T39gAXhmzlW9oJlKFxNoThuXkCX2cqZLtw5fM1yB7V4=; b=RCvJgbXJQ6uF84p0rBL5zgXYoMC4jXWoiszT/rmpdJTkXkbe0ETy8Za7i51Yr1ZPc3 lJNdwgLFHwKEB3Ld56f9wXo4G6PzDUpkithMgfY/xCwSBeYucGussUk+CTiXa7n/5snX dF1a3rABtvnmAHPNJzGa4CmC0p4cps0QEAoXd5X5p/mbTq8XZuD49z4rRy/bHu9PxVNo 4M9RC8WeylPzg8tty5OApq+ESB7sVmMLkKlZNhyUeeCWWiUGzyohLwUCb971veQn8tO5 WEVe2RE1xQ9rw5nXVQm4G5RrdSA5IQNgzo2VIfRxIRSG1rY9EBmj834ItZpx2GC1o7hP QdrQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iJfYi7Es; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6si373507otm.298.2020.03.08.07.40.43; Sun, 08 Mar 2020 07:40:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iJfYi7Es; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726338AbgCHOjM (ORCPT + 99 others); Sun, 8 Mar 2020 10:39:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:55192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbgCHOjM (ORCPT ); Sun, 8 Mar 2020 10:39:12 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5C2C0206D7; Sun, 8 Mar 2020 14:39:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583678351; bh=AMd0h0/qwrlKb60N+y/bZccBrEPrwM6M0GofBq5BRyU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iJfYi7Es7/Rk36TmElQNtAtib6Gk+L5JPtAMRh5ULtEF68pz2E3sehoE/h0BApUbK 6jM8jMfUExCvJvhos19Fpgg4vUgjIcink8jVBn2APpB4LWyKcrLmMtvCxY/dqij0FN OZE4vjEBAT6ZyNPmBcBADNW0NjB1vh6c9/NWElAw= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jAx5B-00B39e-K4; Sun, 08 Mar 2020 14:39:09 +0000 Date: Sun, 8 Mar 2020 14:39:07 +0000 From: Marc Zyngier To: Atish Patra Cc: linux-kernel@vger.kernel.org, Anup Patel , Albert Ou , Anju T Sudhakar , Anup Patel , Borislav Petkov , "Eric W. Biederman" , James Morse , Jason Cooper , linux-riscv@lists.infradead.org, Palmer Dabbelt , Paul Walmsley , "Rafael J. Wysocki" , Steven Price , Thomas Gleixner , Ulf Hansson , Vincent Chen Subject: Re: [PATCH v3 1/2] irqchip/sifive-plic: Enable/Disable external interrupts upon cpu online/offline Message-ID: <20200308143907.51f8eddc@why> In-Reply-To: <20200308135931.331f9be4@why> References: <20200302231146.15530-1-atish.patra@wdc.com> <20200302231146.15530-2-atish.patra@wdc.com> <20200308135931.331f9be4@why> Organization: Approximate X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: atish.patra@wdc.com, linux-kernel@vger.kernel.org, anup@brainfault.org, aou@eecs.berkeley.edu, anju@linux.vnet.ibm.com, anup.patel@wdc.com, bp@suse.de, ebiederm@xmission.com, james.morse@arm.com, jason@lakedaemon.net, linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, rafael.j.wysocki@intel.com, steven.price@arm.com, tglx@linutronix.de, ulf.hansson@linaro.org, vincent.chen@sifive.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 8 Mar 2020 13:59:31 +0000 Marc Zyngier wrote: > On Mon, 2 Mar 2020 15:11:45 -0800 > Atish Patra wrote: > > > Currently, PLIC threshold is only initialized once in the beginning. > > However, threshold can be set to disabled if a CPU is marked offline with > > CPU hotplug feature. This will not allow to change the irq affinity to a > > CPU that just came online. > > > > Add PLIC specific CPU hotplug callbacks and enable the threshold when a CPU > > comes online. Take this opportunity to move the external interrupt enable > > code from trap init to PLIC driver as well. On cpu offline path, the driver > > performs the exact opposite operations i.e. disable the interrupt and > > the threshold. > > > > Signed-off-by: Atish Patra > > Reviewed-by: Anup Patel > > Both patches queued for 5.7 (please add a cover letter when sending a > patch series). Apologies, there was a cover letter. I just messed my filters... ;-) M. -- Jazz is not dead. It just smells funny...