Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp1696165ybh; Sun, 8 Mar 2020 10:35:37 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsTlH5OsMnvu3pi/mJazo1EebAYxEGND9MD4ryr/w6RwZ9O1nDXfun74JUBXxp4Qp/hKSBT X-Received: by 2002:a9d:6c4f:: with SMTP id g15mr9904754otq.96.1583688937495; Sun, 08 Mar 2020 10:35:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583688937; cv=none; d=google.com; s=arc-20160816; b=uteU7YsVr/Nfs86j1oKWJn6G7EOS55svkC6BnLZFW+f1YIzxpVsD6iMqV2iz7RFm9Y fCi/86NaBWt/h2ZyE+iHzv2GBkpScPWUki7SJxQs8xKVgvasHsZDEIZYYeMu5P1hCUrE mHVod30E6fFse+r/9Tx+pBvH/wlnuq6Pfu0pwupq+GrG82yJjuftnWf9hzjIB3wpSe7v O4diRhMDFXc7+UBl/GgzsN6qYvso+97exNIo30Wevb4aWRJVS1COt8Xt8/BOKuWt5wl0 J2iutsWKiWu1zZ6EQXmBjcoRmEbhVEVo9rMc3gXsDE57NT+ec3H2sQ1FBuo1iiwcqogF +uRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=NZ+K+H/dLqzoHf+Bh92zZitV5Bbwp/p0oJh5LZISIxM=; b=MRGI5lBcKYzr/21hn30abgKFdMPB5qJ/FsUGKceCanXjbDkVHTP9q2qfzqkSCOrOc5 2lvfIIC6Wdac9TkRKP944ZX6/wpMboVV9eIuWZGoEXvzxNmkPnS5MnN7nQNZrAURlx4s tHuRFebCczT/DPy3juTbr5a03G4sm4osDfXiSdwJHz38N9/WmHUtD+2cs2ZDx7W6GEgf T0etCIoVg0yfNvXb9+X+MfyT9YZrLR9TCWxl6dsNfBfpPnVvO3SkUcHfgzxrsAsQZRUp 2d3dSQwRi25B42fXe9RFJmMseFbcBceV3Ji+whspO0oCbrwUoHTWz/aU3Jvehch2cy6D H4iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b7oFDBjB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n17si4910202otr.177.2020.03.08.10.35.25; Sun, 08 Mar 2020 10:35:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=b7oFDBjB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726330AbgCHRfJ (ORCPT + 99 others); Sun, 8 Mar 2020 13:35:09 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:36272 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726279AbgCHRfJ (ORCPT ); Sun, 8 Mar 2020 13:35:09 -0400 Received: by mail-wr1-f65.google.com with SMTP id s5so4300970wrg.3; Sun, 08 Mar 2020 10:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=NZ+K+H/dLqzoHf+Bh92zZitV5Bbwp/p0oJh5LZISIxM=; b=b7oFDBjBCuNbJAY0Jwvo4aHW97cEtHb2dXO9gxL3GERk5OrA6YfGjqdAIuksWelJjY 47KQc6y0LQfSmWLCmkvGUw6HlY1RvJP0TkZaA4Nkp9vCCl8pQg9zyYArvJTA0Mpx5NQx KfpOMKL9JU6ng7KEbsNts0cmnrWYAeVIt/VTWd2l5KchI42XFLMBjK9L2cGHUHZC85Yg TtBOCvwPTXl57+w3A5gKZsJoszTqtHsczJ8yxtjmj6c21VaJTGhQntwxWeFJ/YFeRZgO dXL7im868V9p3qFjvgQdN7E92NDz2blkLbRWXiCB9dQy2Xjc1n/MpGe4jH9WJsZSou6n zYnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=NZ+K+H/dLqzoHf+Bh92zZitV5Bbwp/p0oJh5LZISIxM=; b=Mr3Do2DoQQlEYRLBPu7ILCRCQQEM91FVvRG766y7iQfC938rPJSEjRFAKg4vjIosUM 5KBuTECIDk/EYqCRJW5yuP0lr62/1fiq0+/6ttLADGgN8NcAWvqpOUemH11FmqFMaPWW gdrqcxqGf4JNUGJsOHpftK7dPwGBHsV7m9U9QdfV7VBamZDsPPLJufvbUKam3+G625X7 acTqPOe5F638iP6Pk2FMkwoRW6LWt9sPUn72XAtIUNnc2zU3YXuf3Q7zRY6fhgKlp6Zn r2b0XXjtKnMDfrFF4OAEDu8ZKL8mXK0Q9Pk8CHrG4++HXNrNT03uO9QA/HAJU10hkt2u BxmA== X-Gm-Message-State: ANhLgQ3nsJHjWQBCjP4Il4GMdI2rIBw/hHf5h0W/ICBbpexBbYhOyBW3 69uxG2B0pg2iaL2RwqkapNa9q1qK X-Received: by 2002:adf:f2ca:: with SMTP id d10mr16798884wrp.247.1583688905331; Sun, 08 Mar 2020 10:35:05 -0700 (PDT) Received: from [192.168.1.23] (affz13.neoplus.adsl.tpnet.pl. [95.49.155.13]) by smtp.gmail.com with ESMTPSA id l8sm22425718wmj.2.2020.03.08.10.35.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Mar 2020 10:35:04 -0700 (PDT) Subject: Re: [RFC PATCH 1/1] leds: add generic inverted led trigger support To: Tobias Schramm , Pavel Machek , Dan Murphy Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200308142722.1199260-1-t.schramm@manjaro.org> <20200308142722.1199260-2-t.schramm@manjaro.org> From: Jacek Anaszewski Autocrypt: addr=jacek.anaszewski@gmail.com; prefer-encrypt=mutual; keydata= xsFNBFWjfaEBEADd66EQbd6yd8YjG0kbEDT2QIkx8C7BqMXR8AdmA1OMApbfSvEZFT1D/ECR eWFBS8XtApKQx1xAs1j5z70k3zebk2eeNs5ahxi6vM4Qh89vBM46biSKeeX5fLcv7asmGb/a FnHPAfQaKFyG/Bj9V+//ef67hpjJWR3s74C6LZCFLcbZM0z/wTH+baA5Jwcnqr4h/ygosvhP X3gkRzJLSFYekmEv+WHieeKXLrJdsUPUvPJTZtvi3ELUxHNOZwX2oRJStWpmL2QGMwPokRNQ 29GvnueQdQrIl2ylhul6TSrClMrKZqOajDFng7TLgvNfyVZE8WQwmrkTrdzBLfu3kScjE14Q Volq8OtQpTsw5570D4plVKh2ahlhrwXdneSot0STk9Dh1grEB/Jfw8dknvqkdjALUrrM45eF FM4FSMxIlNV8WxueHDss9vXRbCUxzGw37Ck9JWYo0EpcpcvwPf33yntYCbnt+RQRjv7vy3w5 osVwRR4hpbL/fWt1AnZ+RvbP4kYSptOCPQ+Pp1tCw16BOaPjtlqSTcrlD2fo2IbaB5D21SUa IsdZ/XkD+V2S9jCrN1yyK2iKgxtDoUkWiqlfRgH2Ep1tZtb4NLF/S0oCr7rNLO7WbqLZQh1q ShfZR16h7YW//1/NFwnyCVaG1CP/L/io719dPWgEd/sVSKT2TwARAQABzS1KYWNlayBBbmFz emV3c2tpIDxqYWNlay5hbmFzemV3c2tpQGdtYWlsLmNvbT7Cwa8EEwEIAEICGwMHCwkIBwMC AQYVCAIJCgsDFgIBAh4BAheAAhkBFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAl5O5twFCRIR arsAIQkQvWpQHLeLfCYWIQS/HfwKVo8F95V1cJC9alAct4t8JhIgEACtWz3zR5uxaU/GozHh iZfiyUTomQpGNvAtjjZE6UKO/cKusCcvOv0FZbfGDajcMIU8f3FUxJdybrY86KJ9a3tOddal KtB2of3/Ot/EIQjpQb28iLoY8AWnf9G4LQZtoXHiUcOAVPkKgCFnz1IENK3uvyCB9c9//KhE cRZkeAIE2sTmcI4k7/dNHpRI4nha/ZytPwTdM3BjAfxxQI5nMLptm1ksEBI7W1SDOnY3dG2J QWmqpxIefjgyiy0aU+jAw1x3RdZrokVD8OCJiJM8+Z36imarEzqIRQLh+sDNLfV3wEaBn/HU 0Vj6VrRyW2K0jAYToRFD3Ay/eGSfOOAEr/LoMr3NBTDkRLEWdOozllOwADEY9wH0BLHMp2WI hXGOStNiroIEhW2/E0udFJo9b3VoOWKWl+zcUP/keLxVUCXhpmeS7VpSkqsrCVqTVkEc8AXq xhJXeIQJC/XRpCYFc3pFUlVCFViF1ZU2OzE8TndRzzD8e/9ETrJ1GAYa78tNopYhY6AbGlv4 U01nIC93bK07O4IhtBAKsiUz3JPX/KA/dXJOC86qP373cVWVYPvZW+KOya9/7rz0MGR1az9G HqJB7q7DVcCQKt9Egae/goznnXbET6ivCNKbqkH3n/JpiPIxkaXVrbn3QlVtzYpROsS/pCOp 5Evig7kql5L0aYJIZs4zBFsKioYWCSsGAQQB2kcPAQEHQFCKEG5pCgebryz66pTa9eAo+r8y TkMEEnG8UR5oWFt3wsIbBBgBCAAgFiEEvx38ClaPBfeVdXCQvWpQHLeLfCYFAlsKioYCGwIA rwkQvWpQHLeLfCaNIAQZFggAHRYhBBTDHErITmX+em3wBGIQbFEb9KXbBQJbCoqGACEJEGIQ bFEb9KXbFiEEFMMcSshOZf56bfAEYhBsURv0pdvELgD/U+y3/hsz0bIjMQJY0LLxM/rFY9Vz 1L43+lQHXjL3MPsA/1lNm5sailsY7aFBVJxAzTa8ZAGWBdVaGo6KCvimDB8GFiEEvx38ClaP BfeVdXCQvWpQHLeLfCbuOg/+PH6gY6Z1GiCzuYb/8f7D0NOcF8+md+R6KKiQZij/6G5Y7lXQ Bz21Opl4Vz/+39i5gmfBa9LRHH4ovR9Pd6H0FCjju4XjIOJkiJYs2HgCCm6nUxRJWzPgyMPS VbqCG2ctwaUiChUdbS+09bWb2MBNjIlI4b8wLWIOtxhyn25Vifm0p+QR5A2ym4bqJJ9LSre1 qM8qdPWcnExPFU4PZFYQgZ9pX1Jyui73ZUP94L7/wg1GyJZL3ePeE4ogBXldE0g0Wq3ORqA9 gA/yvrCSyNKOHTV9JMGnnPGN+wjBYMPMOuqDPC/zcK+stdFXc6UbUM1QNgDnaomvjuloflAx aYdblM26gFfypvpFb8czcPM+BP6X6vWk+Mw9+8vW3tyK9lSg+43OjIWlBGPpO9aLZsYYxAqv J5iSxcbbOLb5q8wWct6U7EZ1RnuOfVInoBttrlYvdWtcI/5NQTptkuB/DyRhrxBJc/fKzJ4w jS2ikcWe0FnxrQpcE2yqoUIFaZMdd/Cx9bRWAGZG087t5dUHJuMnVVcpHZFnHBKr8ag1eH/K tFdDFtyln5A/f9O22xsV0pyJni7e2z7lTBitrQFG69vnVGJlHbBE2dR4GddZqAlVOUbtEcE7 /aMk4TrCtx0IyOzQiLA81aaJWhkD3fRO8cDlR4YQ3F0aqjYy8x1EnnhhohHOwU0EVaN9oQEQ AMPNymBNoCWc13U6qOztXrIKBVsLGZXq/yOaR2n7gFbFACD0TU7XuH2UcnwvNR+uQFwSrRqa EczX2V6iIy2CITXKg5Yvg12yn09gTmafuoIyKoU16XvC3aZQQ2Bn3LO2sRP0j/NuMD9GlO37 pHCVRpI2DPxFE39TMm1PLbHnDG8+lZql+dpNwWw8dDaRgyXx2Le542CcTBT52VCeeWDtqd2M wOr4LioYlfGfAqmwcwucBdTEBUxklQaOR3VbJQx6ntI2oDOBlNGvjnVDzZe+iREd5l40l+Oj TaiWvBGXkv6OI+wx5TFPp+BM6ATU+6UzFRTUWbj+LqVA/JMqYHQp04Y4H5GtjbHCa8abRvBw IKEvpwTyWZlfXPtp8gRlNmxYn6gQlTyEZAWodXwE7CE+KxNnq7bPHeLvrSn8bLNK682PoTGr 0Y00bguYLfyvEwuDYek1/h9YSXtHaCR3CEj4LU1B561G1j7FVaeYbX9bKBAoy/GxAW8J5O1n mmw7FnkSHuwO/QDe0COoO0QZ620Cf9IBWYHW4m2M2yh5981lUaiMcNM2kPgsJFYloFo2XGn6 lWU9BrWjEoNDhHZtF+yaPEuwjZo6x/3E2Tu3E5Jj0VpVcE9U1Zq/fquDY79l2RJn5ENogOs5 +Pi0GjVpEYQVWfm0PTCxNPOzOzGR4QB3BNFvABEBAAHCwZMEGAEIACYCGwwWIQS/HfwKVo8F 95V1cJC9alAct4t8JgUCXk7nGAUJEhFq9wAhCRC9alAct4t8JhYhBL8d/ApWjwX3lXVwkL1q UBy3i3wmVBwP/RNNux3dC513quZ0hFyU6ZDTxbiafprLN2PXhmLslxPktJgW/xO5xp16OXkW YgNI/TKxj3+oSu+MhEAhAFA2urFWHyqedfqdndQTzbv4yqNuyhGupzPBWNSqqJ2NwKJc9f2R wqYTXVYIO+6KLa32rpl7xvJISkx06s70lItFJjyOf6Hn1y5RBMwQN9hP2YxLhYNO3rmlNSVy 7Z/r95lZTDnnUCuxBZxnjx/pMHJ8LZtKY0t7D0esA+zYGUrmoAGUpNWEBP+uSL+f8rhjSAL0 HgoRL39ixg5Bm0MzJn9z3or++Pl5bRnSvHy6OKh7rzTjCwaGoZD+6LHBwPFPlmInX1H+yHrX lu1uPAdqG5xcsZAZFTxBRMEnYu1yYebDSA9x+iulggMZQcWC2GvHCaKIpKcFY8XCxk7Hbl5c 8hcPKWOy16NLO6Y66Ws4kMedXuNUHe4zBLVlRbcYUdgT9Brw8nxmxu3KhEVsJkwOpXLUDuzo hQNfg9em95lpAK+VOTocke8PSESy3GbEtmoMueW3caSeDHb5dRP6WrndaYhEOzAA/KjuPU7J LMXOABOMIq+R38y7e2B3TnVDCrccdZDseFPUWmH0cGCGihH/j2UZG+PImrSDCh3h5MedVHGo sI62tmWm0q6lrljwSZmMZ30w1QaGmdFpI3Q6V+nZ7TZldI3x Message-ID: <057e4efd-30a1-20df-d990-d11ef2573a3e@gmail.com> Date: Sun, 8 Mar 2020 18:35:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200308142722.1199260-2-t.schramm@manjaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tobias, We have already some triggers that accomplish that by introducing a custom sysfs file. It seems less intrusive to do the same for ledtrig-disk.c. You could also try to make this a generic feature for all LED triggers. On 3/8/20 3:27 PM, Tobias Schramm wrote: > This commit allows inversion of triggers by appending "-inverted" to the > name of a trigger. > > This can be useful when dealing with device that lack separate LEDs for > indicating e.g. disk activity. With this commit applied the power LED > can be used as a disk activity indicator by setting its default state to > on and using the "disk-activity-inverted" trigger. The LED will then turn > off briefly when there is disk activity. > > Signed-off-by: Tobias Schramm -- Best regards, Jacek Anaszewski