Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 8 Mar 2020 18:34:48 +0000
From:   Mel Gorman <mgorman@suse.de>
To:     qiwuchen55@gmail.com
Cc:     mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com,
        linux-kernel@vger.kernel.org, chenqiwu <chenqiwu@xiaomi.com>
Subject: Re: [PATCH] sched/fair: fix build warning about undefined
 test_idle_cores()
Message-ID: <20200308183448.GI3772@suse.de>
References: <1583682792-30844-1-git-send-email-qiwuchen55@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1583682792-30844-1-git-send-email-qiwuchen55@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Mar 08, 2020 at 11:53:12PM +0800, qiwuchen55@gmail.com wrote:
> From: chenqiwu <chenqiwu@xiaomi.com>
> 
> The build with arm64's defconfig:
> CONFIG_SCHED_MC=y
> # CONFIG_SCHED_SMT is not set
> 
> Trigger the following warning due to test_idle_cores()'s definition
> missing:
> kernel/sched/fair.c:1524:20: warning: ???test_idle_cores??? declared ???static???
> 	but never defined [-Wunused-function]
> 
> Move the CONFIG_SCHED_SMT ifdeffery around test_idle_cores()'s declaration
> to fix it.
> 
> Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>

Thanks. A fix has been merged to tip/sched/core as

commit 76c389ab2b5e300698eab87f9d4b7916f14117ba
Author: Valentin Schneider <valentin.schneider@arm.com>
Date:   Tue Mar 3 11:02:57 2020 +0000

    sched/fair: Fix kernel build warning in test_idle_cores() for !SMT NUMA


-- 
Mel Gorman
SUSE Labs