Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] scsi: aacraid: fix -Wcast-function-type
To:     Phong Tran <tranmanphong@gmail.com>, <aacraid@microsemi.com>,
        <jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
        <bvanassche@acm.org>
CC:     <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <keescook@chromium.org>
References: <20200307132103.4687-1-tranmanphong@gmail.com>
 <20200308020143.9351-1-tranmanphong@gmail.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <9a0e6373-b4a3-0822-3b65-e3b326266832@huawei.com>
Date:   Mon, 9 Mar 2020 09:23:50 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20200308020143.9351-1-tranmanphong@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/03/2020 02:01, Phong Tran wrote:
> correct usage prototype of callback scsi_cmnd.scsi_done()
> Report by: https://github.com/KSPP/linux/issues/20
> 

no harm to add:

drivers/scsi/aacraid/aachba.c:813:23: warning: cast between incompatible 
function types from ‘int (*)(struct scsi_cmnd *)’ to ‘void (*)(struct 
scsi_cmnd *)’ [-Wcast-function-type]


> Signed-off-by: Phong Tran <tranmanphong@gmail.com>
> ---
>   drivers/scsi/aacraid/aachba.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
> index 33dbc051bff9..20ca3647d211 100644
> --- a/drivers/scsi/aacraid/aachba.c
> +++ b/drivers/scsi/aacraid/aachba.c
> @@ -798,6 +798,11 @@ static int aac_probe_container_callback1(struct scsi_cmnd * scsicmd)
>   	return 0;
>   }
>   
> +static void  aac_probe_container_scsi_done(struct scsi_cmnd *scsi_cmnd)

supernit: double whitespace

> +{
> +	aac_probe_container_callback1(scsi_cmnd);
> +}
> +
>   int aac_probe_container(struct aac_dev *dev, int cid)
>   {
>   	struct scsi_cmnd *scsicmd = kmalloc(sizeof(*scsicmd), GFP_KERNEL);
> @@ -810,7 +815,7 @@ int aac_probe_container(struct aac_dev *dev, int cid)
>   		return -ENOMEM;
>   	}
>   	scsicmd->list.next = NULL;
> -	scsicmd->scsi_done = (void (*)(struct scsi_cmnd*))aac_probe_container_callback1;
> +	scsicmd->scsi_done = aac_probe_container_scsi_done;
>   
>   	scsicmd->device = scsidev;
>   	scsidev->sdev_state = 0;
>