Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200305103228.9686-1-zhang.lyra@gmail.com> <20200305103228.9686-2-zhang.lyra@gmail.com>
 <CAMuHMdU-gAhupHotQTHAZfopkGF_jQc-VrVxb24caw_BfzWd6g@mail.gmail.com>
 <CAAfSe-sonfA=6x9uvQXaHniQaXR8hWZa4uOcWxoo+Z_XT9QNhw@mail.gmail.com>
 <CAMuHMdUBkS+pPyPid2K=40jaTOSnAE_L-vJP5knmyVr8Fr5_hg@mail.gmail.com> <CAAfSe-uZSYZopDCGxQbGBQQ5+NZK6L79P+T62nfnL9CiZka++g@mail.gmail.com>
In-Reply-To: <CAAfSe-uZSYZopDCGxQbGBQQ5+NZK6L79P+T62nfnL9CiZka++g@mail.gmail.com>
From:   Geert Uytterhoeven <geert@linux-m68k.org>
Date:   Mon, 9 Mar 2020 11:32:25 +0100
Message-ID: <CAMuHMdXY5=QS4FA0T55_G=ARPs9V0NLbWwF3hd76rwO=8ahZbA@mail.gmail.com>
Subject: Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD
To:     Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Jiri Slaby <jslaby@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Orson Zhai <orsonzhai@gmail.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Chunyan,

On Mon, Mar 9, 2020 at 9:43 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> On Mon, 9 Mar 2020 at 16:01, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> > > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote:
> > > > > From: Chunyan Zhang <chunyan.zhang@unisoc.com>
> > > > >
> > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s,
> > > > > since we want them can be built-in when ARCH_SPRD is set as 'm'.
> > > >
> > > > Why would you want a serial driver for a specific platform to be builtin,
> > > > while all other platform support is modular?
> > >
> > > Oh, that's not this patch means.
> > >
> > > We just want serial driver can be builtin for any platform, so it
> >
> > What would be the benefit of the user to be able to have the SPRD serial
> > driver built-in on any platform?  AFAIU, it supports only Spreadtrum
> > platforms.
>
> Right, it does support Spreadtrum platforms only indeed.
> Like I said on the replay to patch 1/2, simply because I want serial
> driver can be builtin all the time, no matter ARCH_SPRD is m or y.

OK.

So shouldn't the dependency become

    depends on ARCH_SPRD || ARCH_SPRD=m || COMPILE_TEST

instead, to avoid asking the question when you're not building a kernel
plus modules for Spreadtrum platforms?


> > > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD)
> > > , otherwise if the config was set as 'm', the serial driver can't be
> > > selected as 'y' then.
> >
> > I ask about that as a reply to PATCH 1/2.
> >
> > > That's what I mean.
> >
> > > > > --- a/drivers/tty/serial/Kconfig
> > > > > +++ b/drivers/tty/serial/Kconfig
> > > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135
> > > > >
> > > > >  config SERIAL_SPRD
> > > > >         tristate "Support for Spreadtrum serial"
> > > > > -       depends on ARCH_SPRD
> > > > >         select SERIAL_CORE
> > > > >         help
> > > > >           This enables the driver for the Spreadtrum's serial.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds