Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] iio:ad7797: Use correct attribute_group
To:     "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
        "stefan.popa@analog.com" <stefan.popa@analog.com>,
        "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
        "pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "knaack.h@gmx.de" <knaack.h@gmx.de>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        "yuehaibing@huawei.com" <yuehaibing@huawei.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
References: <20200302133249.23152-1-yuehaibing@huawei.com>
 <8d7a7062af94a3531dd519bd60fe26c8530c6a43.camel@analog.com>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <f82a318f-16b3-0bc0-61bf-0c54da05446d@metafoo.de>
Date:   Mon, 9 Mar 2020 11:10:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.5.0
MIME-Version: 1.0
In-Reply-To: <8d7a7062af94a3531dd519bd60fe26c8530c6a43.camel@analog.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/4/20 7:35 AM, Ardelean, Alexandru wrote:
> On Mon, 2020-03-02 at 21:32 +0800, YueHaibing wrote:
>> [External]
>>
>> It seems ad7797_attribute_group should be used in ad7797_info,
>> according to commit ("iio:ad7793: Add support for the ad7796 and ad7797").
> While the change looks good at first, I am thinking that this might introduce
> another issue while fixing this one.
>
> It looks like the ad7797_attributes[] array may also require the
> &iio_dev_attr_in_m_in_scale_available.dev_attr.attr attribute as well.
> It looks like the available scales should be printed for AD7997 as well.
>
> That being said, this patch is fine as-is.
> But it would require a patch [before-this-patch] to fix the ad7797_attributes
> array.
>
> Something like this:
>
> static struct attribute *ad7797_attributes[] = {
>          &iio_const_attr_sampling_frequency_available_ad7797.dev_attr.attr,
> +       &iio_dev_attr_in_m_in_scale_available.dev_attr.attr,
>         NULL
> };
>
> I'm hoping I'm right about this one. I sometimes don't notice things too well.
>
Scale is fixed for the ad7796 and not programmable. Usually we only have 
the scale attribute itself in that case and no scale_available attribute.

- Lars