Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2481145ybh; Mon, 9 Mar 2020 06:47:15 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs0KsEH5GQGUPOLrzn45BIE2GVnndqTbojs+3Plll1h+JJxDGqAiticae0IKqmjYilIo4CV X-Received: by 2002:aca:dc8b:: with SMTP id t133mr11480493oig.98.1583761635455; Mon, 09 Mar 2020 06:47:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583761635; cv=none; d=google.com; s=arc-20160816; b=I6TyS7FFqQxpYfVx9fS5wzpPJM/nPnz75ry89EZiIO67e1+U6FYY8MtrYL58ZrONh+ jHcOXf0UqBwQSuhlLvYO4dECRvC4fYZLt27SDzjp2hSXRitLSCQdmTXcWpnU8aQXycoj N6tuYTx5R+4eJevMyVamyG+n/3rubKC3NxTULLnlXp2i3EV/yoDHgmCGv2dR8lm39Fnh A1tgipG7T7t/RDbmCrxhqt308q6WD9ARwHEXxyVKLzo7wCCHOHp33kpGzXrVYkyehR6Q lcSq6udoiP8Miu4ovRBnIjBCH0+sihJwTe64fPe6G/SBn2gys2sZT8kVM9h6hqqhGME2 uWUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject; bh=1Isq49tChu7PDcDumniPLs64R9Znq3TGKHVyG/doirU=; b=c6h9af17geff5aaQZwruZOussqLDJxDizNj0DhJuxF2wRxZjzI7iOZGNqgypj/vzq/ 7Y/R9twDws8agLJgDG9IZzQUADAsMJNWnbh3evbiVJDaK3tj93bqmXRFDBnJX4eWIc3b nIUYEZPuW5AAXofHVTfbrgMu6s6o7xGrcH3p9XTlsKOzRVExOUoQEn7AjMLr9Vg4vkGm DgFQasVjJztwu490j0N94UNh/+JJGyi7IThTMdGvGALPwDRBNkoJABfbxyInR8UK7Vvt +8QYN5CzibQFD3UVgPUIqAZjvPx9aja8B34wqLjnykWKOOlUZ01NxtWt4IeuNjQAY3WT Ev3Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6si1882799otm.298.2020.03.09.06.47.03; Mon, 09 Mar 2020 06:47:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726676AbgCINpw (ORCPT + 99 others); Mon, 9 Mar 2020 09:45:52 -0400 Received: from mail.manjaro.org ([176.9.38.148]:58810 "EHLO mail.manjaro.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726383AbgCINpw (ORCPT ); Mon, 9 Mar 2020 09:45:52 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.manjaro.org (Postfix) with ESMTP id C3A963701AC9; Mon, 9 Mar 2020 14:45:50 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at manjaro.org Received: from mail.manjaro.org ([127.0.0.1]) by localhost (manjaro.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oXfIn-hvP3mj; Mon, 9 Mar 2020 14:45:48 +0100 (CET) Subject: Re: [RFC PATCH 1/1] leds: add generic inverted led trigger support To: Jacek Anaszewski , Tobias Schramm , Pavel Machek , Dan Murphy Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200308142722.1199260-1-t.schramm@manjaro.org> <20200308142722.1199260-2-t.schramm@manjaro.org> <057e4efd-30a1-20df-d990-d11ef2573a3e@gmail.com> From: Tobias Schramm Message-ID: Date: Mon, 9 Mar 2020 14:46:52 +0100 MIME-Version: 1.0 In-Reply-To: <057e4efd-30a1-20df-d990-d11ef2573a3e@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacek, thanks dor the feedback. > We have already some triggers that accomplish that by introducing > a custom sysfs file. [...] > You could also try to make this a generic feature > for all LED triggers. Based on the other feedback I got I will do just that. Pavel is right, we do already have a lot of triggers, doubling the number of triggers is probably not the best idea. Tobias