Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH 0/1] Add generic inverted led triggers
To:     Pavel Machek <pavel@ucw.cz>, Tobias Schramm <t.schramm@manjaro.org>
Cc:     Jacek Anaszewski <jacek.anaszewski@gmail.com>,
        Dan Murphy <dmurphy@ti.com>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200308142722.1199260-1-t.schramm@manjaro.org>
 <20200308212649.GA31247@amd>
From:   Tobias Schramm <t.schramm@manjaro.org>
Message-ID: <10a57ef4-e8a3-2aea-ee28-2c3bb187c17a@manjaro.org>
Date:   Mon, 9 Mar 2020 15:05:49 +0100
MIME-Version: 1.0
In-Reply-To: <20200308212649.GA31247@amd>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US-large
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Pavel,

thanks for the feedback.

> Not a big fan (sorry).
> 
> We have already _way_ too many triggers, we don't want to have twice
> that much.

True. Doubling the amount of triggers is probably not a good idea.

> 
> Better implementation might be to have a trigger attribute doing the
> inverting.

I agree. Especially since Jacek pointed out that some triggers do that
already.

> 
> Inverting really does not work with all the triggers; numlock-inverted
> will not get too many
> users. always-on-inverted... blink-inverted.... I guess it does make
> sense for disk activity (but be warned disk can be continuously active
> for quite a while).
> 
> What triggers do you think make sense inverted?

I think all kinds of activity indicators (disk-activity, mmc, usb, ide,
nand, cpu, network, etc.) make sense. Guess I'll add a flags field to
the led_trigger struct and have an invertible flag that specifies
whether a trigger should be invertible or not.


Thanks again,

Tobias