Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2502401ybh; Mon, 9 Mar 2020 07:11:42 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsY3NsWbaswznZCmFiPx+QLEY20edXVaTNddXPquZzPqJeUJ8PWy7qCKE4tgBQqOMNpwgj4 X-Received: by 2002:a05:6830:1504:: with SMTP id k4mr13791143otp.244.1583763102700; Mon, 09 Mar 2020 07:11:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583763102; cv=none; d=google.com; s=arc-20160816; b=bJzgCv5BUFVAipSwYz5o7nWkRVDKRmQ+hKtOTEOwF6QNhrN2hxlIugxWKrA5Z/MdGV 60JBI8pY2x6420DWQ3IhYtIuKzffVYbNe5+BTFy98e+WTV8RUpzTLQcWvVKdG1kpbR2h 6ttvePdGTNI4FPJF1mEbmTwOpM02yplqhDxNyEsdf+ENov9UwrX7CqqG0LIopn5vQ2Zy pVvp9ou0032Wb2vujACkMpd6fpC8i/yeU2nfK69FRU9tNGjsoR7SI7zbOrotNLEwILmv CX2pZLghlAsWoYycKDdLdDIYh53tCszkud3hVcy2daNj6EZxT5aaioKsu1PlZ4wmIizW ewug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=1DONZyJhzIw61vc2b8VyfHEnmtSL8XmCoaWpkr0Q6yQ=; b=xi6Qsqk0WzGl/kOMOVPrWy/gJDr4uAxBbyRyKBM+8RCRzkqTxC6SvIh7HEelUn07NN DXcFBoRYqS13nKIqlcPHvaHQa0Kj55Im2/jU4l9cQEPaQZ/dEnOCcbXVywH59umcbiea boPCUSimJ41t1t0TNzMcHr6ZctdP5gtSgWG81lHjvhurVT6GAbT60k3sZkUKYxO1I2S5 mKxC0ZxXuypdyVJUDGYC4TDG4zwcfxktoAg6tiRUPYg+7IdNLrlA0nZcf/e0tjyV2eij mQFrWKdrdRLSffKywaM+DAHoQcRMfi5dmoDx45wYq3KFFx6Wn7VaIQlXGlrM0ELbjudz lp4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZYDWaVXI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h145si3770598oib.210.2020.03.09.07.11.30; Mon, 09 Mar 2020 07:11:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ZYDWaVXI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726788AbgCIOLB (ORCPT + 99 others); Mon, 9 Mar 2020 10:11:01 -0400 Received: from mail-lf1-f66.google.com ([209.85.167.66]:34456 "EHLO mail-lf1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726233AbgCIOLB (ORCPT ); Mon, 9 Mar 2020 10:11:01 -0400 Received: by mail-lf1-f66.google.com with SMTP id i19so1889086lfl.1; Mon, 09 Mar 2020 07:11:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1DONZyJhzIw61vc2b8VyfHEnmtSL8XmCoaWpkr0Q6yQ=; b=ZYDWaVXI+O+RUpYxYfXm8ia4oOLkw/O+R89i+fHtsyE7gL+aPkvQ6/74KlAZ7upBOy mVkW/vEl9ymGQtMH96WKfn9Hl9vP2enpx2WSUQVt5eNiOZcBSPMGvWaD1xhAx24j218x TssPVDmyorIu6yhB4IZASsU3vvyEwVPLv2jnnokvy9Y5/c7QhkrdURMMpyYom7hAAf83 0+1LWvmFyikllT7rr9CQOxn7hYse57X0T2WNRzV76ixDvKlEOO/B3d2skZ4yPNRtbbPT BMfcq/IX+sZXcbLGV2NFlvHPnT/i864dbduIhTa+QK+inCG7Vr8hhA627LXSrkzIyzMl Pcsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1DONZyJhzIw61vc2b8VyfHEnmtSL8XmCoaWpkr0Q6yQ=; b=IX+ZH8980MnJmLCrj/u0QfGrR/1yXcamX1onMf+PcogmqlX6c1P7k3qtyFEhDrEK2v Cte+YEAK9oymvKWTagb0Qnzkw2O54zSDIkb8h1aUZINjia9XfW5KjfGS1vCWh4vml+no cBMxLzCQ4Ty54y6Mtsy4JA8m4J7IAO8aLLPAWaLi2J+SIrbmnUXwMvH6FXd3lsQe975O c79p+QgfX/XlPhM9u3NZ5w1N3uB7DEZwxw0i94+Tq5KBULL5E5qYfLK5UbOmOg68k/66 zkg/9l6QjhD4v7/Hyw65CtMMsJBixvuLk/u00XoCrsiUBWNx20yNktQrHdg7n97Sj0+m 5bZg== X-Gm-Message-State: ANhLgQ14T1ZLB6as7KimGcQkNAl9MJMW5G1nhlBFLbj8TlXWJr04/R2F AxlSbpQ3mu4LQeulZ6z5YZYWVIqxw9wW5keuuBM= X-Received: by 2002:ac2:5328:: with SMTP id f8mr9426587lfh.47.1583763059624; Mon, 09 Mar 2020 07:10:59 -0700 (PDT) MIME-Version: 1.0 References: <20200305103228.9686-1-zhang.lyra@gmail.com> <20200305103228.9686-2-zhang.lyra@gmail.com> In-Reply-To: From: Orson Zhai Date: Mon, 9 Mar 2020 22:10:41 +0800 Message-ID: Subject: Re: [PATCH 2/2] tty: serial: make SERIAL_SPRD not depend on ARCH_SPRD To: Geert Uytterhoeven Cc: Chunyan Zhang , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Linux Kernel Mailing List , Chunyan Zhang , "open list:SERIAL DRIVERS" , Baolin Wang , Linux ARM , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Mon, Mar 9, 2020 at 4:01 PM Geert Uytterhoeven wrote: > > Hi Chunyan, > > On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang wrote: > > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven wrote: > > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang wrote: > > > > From: Chunyan Zhang > > > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > > > Why would you want a serial driver for a specific platform to be builtin, > > > while all other platform support is modular? > > > > Oh, that's not this patch means. > > > > We just want serial driver can be builtin for any platform, so it > > What would be the benefit of the user to be able to have the SPRD serial > driver built-in on any platform? AFAIU, it supports only Spreadtrum > platforms. > Assume there is a all-in-one common kernel binary image say arm64 for all SoC platform and all device drivers are built as modules from different vendors for each specific devices. But for serial driver it is too late to be initialized as a module if users want to check early console log. At this circumstance vendors prefer to set their serial driver to be built into that all-in-one image as easy as to only set one config instead of enabling whole platform then disabling many out of serial. -Orson > > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > > , otherwise if the config was set as 'm', the serial driver can't be > > selected as 'y' then. > > I ask about that as a reply to PATCH 1/2. > > > That's what I mean. > > > > > --- a/drivers/tty/serial/Kconfig > > > > +++ b/drivers/tty/serial/Kconfig > > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > > > config SERIAL_SPRD > > > > tristate "Support for Spreadtrum serial" > > > > - depends on ARCH_SPRD > > > > select SERIAL_CORE > > > > help > > > > This enables the driver for the Spreadtrum's serial. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds