Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2549190ybh; Mon, 9 Mar 2020 08:06:29 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsrujFTi3girmLcdVMDTskSq1mt+dNhWt+g0UYSg4h5p0ccEkkGIo67OyNtZGh51H+5zfPY X-Received: by 2002:aca:f449:: with SMTP id s70mr10760332oih.86.1583766389164; Mon, 09 Mar 2020 08:06:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583766389; cv=none; d=google.com; s=arc-20160816; b=V1GS9hh7UkbSpvq4YQDfJodC+dPRSgBVY1fIOXP30MuQ27Blx2w90TG4O3po/FiX6z uT8MfdHyrrOOqlPIdDMhBgVQ1Q+z3ttCoRPejsid+WNRXdWEPaA3KmYs6uT5rjMskH6c LgrjqZAV0+3NxALbnymbQlIz3Bh62SxHrBEZbqHB4/oahIMM7V7eWAoU2/0btmd3TCus Yjzc0PIznf0xgqOSirDojR9qpR69ZhUF5WGRwivmCeaympczUbUh3qd4pzC0CQXbT81e oWG0bMJ6MKGTx4VQo2bum5Jcr1zbSLDYJA9pm+cO+xsn2OXou9A3sseXcVcvut4VJT9p Cabw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=mybra6UFAHviKaf5qhiFaOqNSz80DfTyYW9vHPbK66Q=; b=IO5kyIHk3c/sPmyQI8Vgc+AL92fs9RW5YSP8AMrebK9HWV59KMQduDEW79xW2wSEFc Zi0qOK5o/bH2UKxqcTuxfL3C9Oi6fsslvqcyydCm87Tf25LXGoUEDX3CVzqmFtuE3jDo f+T0Z3png+7ytccVMZkFXng3LHVkpD46J+Y4s/2jzDFwtYW4zHyLYlfMDPk+NsZ5ayd7 wcyX6XmteDT/mIs11UWKA9F41xSVDD41M1IsH7bpoQw45pcsttuOupa8SS6eZzEtzyJX Wq0LjHvBKxwvn3nbNLB2aPJpHAWRa+fsRCBbNj5A1k8O/vEy45g0HU3drR02qkYPnMby UDfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a18si6296625otf.230.2020.03.09.08.06.07; Mon, 09 Mar 2020 08:06:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726814AbgCIPDn (ORCPT + 99 others); Mon, 9 Mar 2020 11:03:43 -0400 Received: from foss.arm.com ([217.140.110.172]:53500 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726739AbgCIPDn (ORCPT ); Mon, 9 Mar 2020 11:03:43 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6083C30E; Mon, 9 Mar 2020 08:03:42 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 46AE03F6CF; Mon, 9 Mar 2020 08:03:40 -0700 (PDT) Date: Mon, 9 Mar 2020 15:03:28 +0000 From: Lorenzo Pieralisi To: Boqun Feng Cc: linux-pci@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Kelley , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Sasha Levin , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Andrew Murray , Bjorn Helgaas Subject: Re: [PATCH v3 0/3] PCI: hv: Generify pci-hyperv.c Message-ID: <20200309150319.GA18350@e121166-lin.cambridge.arm.com> References: <20200210033953.99692-1-boqun.feng@gmail.com> <20200221023344.GJ69864@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net> <20200221104454.GA8595@e121166-lin.cambridge.arm.com> <20200309143548.GB118238@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200309143548.GB118238@debian-boqun.qqnc3lrjykvubdpftowmye0fmh.lx.internal.cloudapp.net> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2020 at 10:35:48PM +0800, Boqun Feng wrote: > Hi Lorenzo, > > On Fri, Feb 21, 2020 at 10:44:54AM +0000, Lorenzo Pieralisi wrote: > > On Fri, Feb 21, 2020 at 10:33:44AM +0800, Boqun Feng wrote: > > > Ping ;-) > > > > > > Any suggestion or plan on this patchset? > > > > Hi, > > > > I shall have a look shortly, thanks. > > > > Any chance you got some time to look into this? I did last week and I applied it now, pci/hv for v5.7. Thanks, Lorenzo > Regards, > Boqun > > > Lorenzo > > > > > Thanks and Regards, > > > Boqun > > > > > > On Mon, Feb 10, 2020 at 11:39:50AM +0800, Boqun Feng wrote: > > > > Hi, > > > > > > > > This is the first part for virtual PCI support of Hyper-V guest on > > > > ARM64. The whole patchset doesn't have any functional change, but only > > > > refactors the pci-hyperv.c code to make it more arch-independent. > > > > > > > > Previous version: > > > > v1: https://lore.kernel.org/lkml/20200121015713.69691-1-boqun.feng@gmail.com/ > > > > v2: https://lore.kernel.org/linux-arm-kernel/20200203050313.69247-1-boqun.feng@gmail.com/ > > > > > > > > Changes since v2: > > > > > > > > * Rebased on 5.6-rc1 > > > > > > > > * Reword commit logs as per Andrew's suggestion. > > > > > > > > * It makes more sense to have a generic interface to set the whole > > > > msi_entry rather than only the "address" field. So change > > > > hv_set_msi_address_from_desc() to hv_set_msi_entry_from_desc(). > > > > Additionally, make it an inline function as per the suggestion > > > > of Andrew and Thomas. > > > > > > > > * Add the missing comment saying the partition_id of > > > > hv_retarget_device_interrupt must be self. > > > > > > > > * Add the explanation for why "__packed" is needed for TLFS > > > > structures. > > > > > > > > I've done compile and boot test of this patchset, also done some tests > > > > with a pass-through NVMe device. > > > > > > > > Suggestions and comments are welcome! > > > > > > > > Regards, > > > > Boqun > > > > > > > > Boqun Feng (3): > > > > PCI: hv: Move hypercall related definitions into tlfs header > > > > PCI: hv: Move retarget related structures into tlfs header > > > > PCI: hv: Introduce hv_msi_entry > > > > > > > > arch/x86/include/asm/hyperv-tlfs.h | 41 +++++++++++++++++++++++++++ > > > > arch/x86/include/asm/mshyperv.h | 8 ++++++ > > > > drivers/pci/controller/pci-hyperv.c | 43 ++--------------------------- > > > > 3 files changed, 52 insertions(+), 40 deletions(-) > > > > > > > > -- > > > > 2.24.1 > > > >