Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2568265ybh; Mon, 9 Mar 2020 08:27:54 -0700 (PDT) X-Google-Smtp-Source: ADFU+vs4pe33dSoEBsyurKELv5o6YO68T2YVjkdKdr3tW/GlLkWkfNqGrnv4F8OLQ4ACl9FHsjI3 X-Received: by 2002:aca:f07:: with SMTP id 7mr11319399oip.29.1583767674105; Mon, 09 Mar 2020 08:27:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583767674; cv=none; d=google.com; s=arc-20160816; b=gQw0ihVAPQcNxRgLDUmmiCXG396cyvn+Vngdbh12k6jHqqcQMDRBihCvc67VEa/AOh WgMBIFQR+IqnQ2uEx5nDQxqc1d5QyyhG/5YSuUo1t1ltWNaHAVMBc4CPsQS/tNWKbZZC pjRJDhx3FQlDoSUqmNhO/6ueq9pTvxYbIJIt7U8pYlR30guTTp1+mC0RiBOXPKgF6LvE VWu8aa9nT/q8bhTH+JDzRngiEyMjcK94E4CfOZs7x71oxHJG4+bGVtWmjIFx8V5TUdm2 3onRVKD5dxHQgmwS6pXV6IPPDGV4M0fw72gkgmSuVbiHMygHotL8nFNEGscYF2Ncb5Kc Eabg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:from:subject:message-id:in-reply-to :date:mime-version; bh=0ZrYWFYrYRIyPuZCV9HfvTWtZxwXcc5YwAN9ehMm70k=; b=GZ8gS/E0ihwYcrBMX1T7Ztg1p/HW4BF3YhVhOUaNR8cYMGSc51i7wSI67nhglXhFpE +WCaHbzcHVHAQlbIurft86LIR9Fy2R8YVdWqlSXJ9thj4B5F2soLDCF9eMh6GWKfUXfe 7NNRgG0+Vte+zXHFhJmsEj6G4nEEhvcF0b4fdrIZ1X9D1OvBErZMvUiUp7TW4NlMw4xJ aiWd6lI8ZJt3qaBkY1/fd9PsP0iOcZN+tZEGTQaJm022Qeg1rI77nl3rjzQVYFeGwG8b x7KOp5Xn1RO7LTAtYjK61NbuobArIUfOEzGkGGgSZelsaTnFyz++24sP59h2WySelwY6 PYCw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=appspotmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 15si4279295oix.96.2020.03.09.08.27.41; Mon, 09 Mar 2020 08:27:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=appspotmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbgCIP0N (ORCPT + 99 others); Mon, 9 Mar 2020 11:26:13 -0400 Received: from mail-il1-f200.google.com ([209.85.166.200]:48119 "EHLO mail-il1-f200.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726905AbgCIP0N (ORCPT ); Mon, 9 Mar 2020 11:26:13 -0400 Received: by mail-il1-f200.google.com with SMTP id a4so7594783ili.14 for ; Mon, 09 Mar 2020 08:26:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:date:in-reply-to:message-id:subject :from:to; bh=0ZrYWFYrYRIyPuZCV9HfvTWtZxwXcc5YwAN9ehMm70k=; b=sY2DjymmGWQgvxmYDvaF71XglvjGsJRu1Gh7k8pYzPH78xWOPWi6qFrXq+txUvKhT5 Y5MlM6vewe2josejYyD70iXlOA0mhCk49J0Vj9X+YjbMq+qanBijMqQNSXicUM5I2iXi IgZOb8rql70Oy6xbMvyKOInBvqk8/il7MJAk+HgtmwxgD5BzJ7NsChbK/aX3Fd3Mbk5J m4cNASk5KzTTD89q/5fpuyXJyLtDFuAkfc3G7qZn250qPpPWz3kPTAouJZuNbK77uijR /TqhcR+icAAUxmA0MC+BGF5XYX3xfV2MMdB/BWOvM1YztroBsDaYmgtwPepLD+uH+sXO 0Vmg== X-Gm-Message-State: ANhLgQ3qD1QU8BC8eCtLvrAM32PUhr1yuDPpOeC0qfy5dO5O9Hryyc1r 9MOkIjiB5oTQiBvi2OuP3j6gKrRdn7EwtZNp0llyI76jbf7b MIME-Version: 1.0 X-Received: by 2002:a05:6e02:10c6:: with SMTP id s6mr10043517ilj.9.1583767570846; Mon, 09 Mar 2020 08:26:10 -0700 (PDT) Date: Mon, 09 Mar 2020 08:26:10 -0700 In-Reply-To: <000000000000ce8d2305a03b0988@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <0000000000007799d505a06d9f81@google.com> Subject: Re: INFO: trying to register non-static key in uhid_char_release From: syzbot To: benjamin.tissoires@redhat.com, dh.herrmann@googlemail.com, ebiggers@kernel.org, hdanton@sina.com, jikos@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org syzbot has found a reproducer for the following crash on: HEAD commit: 2c523b34 Linux 5.6-rc5 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=150bce55e00000 kernel config: https://syzkaller.appspot.com/x/.config?x=a5295e161cd85b82 dashboard link: https://syzkaller.appspot.com/bug?extid=8357fbef0d7bb602de45 compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81) syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11b439c3e00000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=16dc6fb5e00000 IMPORTANT: if you fix the bug, please add the following tag to the commit: Reported-by: syzbot+8357fbef0d7bb602de45@syzkaller.appspotmail.com INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness validator. CPU: 0 PID: 10346 Comm: syz-executor364 Not tainted 5.6.0-rc5-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1e9/0x30e lib/dump_stack.c:118 register_lock_class+0x6f4/0xec0 kernel/locking/lockdep.c:443 __lock_acquire+0x116/0x1bc0 kernel/locking/lockdep.c:3836 lock_acquire+0x154/0x250 kernel/locking/lockdep.c:4484 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x9e/0xc0 kernel/locking/spinlock.c:159 __wake_up_common_lock kernel/sched/wait.c:122 [inline] __wake_up+0xb8/0x150 kernel/sched/wait.c:142 uhid_dev_destroy drivers/hid/uhid.c:563 [inline] uhid_char_release+0x99/0x600 drivers/hid/uhid.c:642 __fput+0x2d8/0x730 fs/file_table.c:280 task_work_run+0x176/0x1b0 kernel/task_work.c:113 exit_task_work include/linux/task_work.h:22 [inline] do_exit+0x5ef/0x1f80 kernel/exit.c:801 do_group_exit+0x15e/0x2c0 kernel/exit.c:899 __do_sys_exit_group+0x13/0x20 kernel/exit.c:910 __se_sys_exit_group+0x10/0x10 kernel/exit.c:908 __x64_sys_exit_group+0x37/0x40 kernel/exit.c:908 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x4403d8 Code: 00 00 be 3c 00 00 00 eb 19 66 0f 1f 84 00 00 00 00 00 48 89 d7 89 f0 0f 05 48 3d 00 f0 ff ff 77 21 f4 48 89 d7 44 89 c0 0f 05 <48> 3d 00 f0 ff ff 76 e0 f7 d8 64 41 89 01 eb d8 0f 1f 84 00 00 00 RSP: 002b:00007ffd67f7d928 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00000000004403d8 RDX: 0000000000000000 RSI: 000000000000003c RDI: 0000000000000000 RBP: 00000000004c0d90 R08: 00000000000000e7 R09: ffffffffffffffd4 R10: 0000000000402570 R11: 0000000000000246 R12: 0000000000000001 R13: 00000000006d3180 R14: 0000000000000000 R15: 0000000000000000 general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] CPU: 0 PID: 10346 Comm: syz-executor364 Not tainted 5.6.0-rc5-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:__wake_up_common+0x297/0x4d0 kernel/sched/wait.c:86 Code: fb 01 00 00 45 31 f6 eb 13 66 2e 0f 1f 84 00 00 00 00 00 4d 39 fc 0f 84 e3 01 00 00 4c 89 fb 49 8d 6f e8 4c 89 f8 48 c1 e8 03 <80> 3c 10 00 74 12 48 89 df e8 eb 4e 59 00 48 ba 00 00 00 00 00 fc RSP: 0018:ffffc90001687c10 EFLAGS: 00010046 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: dffffc0000000000 RSI: 0000000000000001 RDI: ffff888091fe13c8 RBP: ffffffffffffffe8 R08: 0000000000000000 R09: ffffc90001687c78 R10: fffff520002d0f82 R11: 0000000000000000 R12: ffff888091fe1400 R13: 1ffff920002d0f8f R14: 0000000000000000 R15: 0000000000000000 FS: 00000000023ec940(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020000088 CR3: 0000000096b74000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: __wake_up_common_lock kernel/sched/wait.c:123 [inline] __wake_up+0xd4/0x150 kernel/sched/wait.c:142 uhid_dev_destroy drivers/hid/uhid.c:563 [inline] uhid_char_release+0x99/0x600 drivers/hid/uhid.c:642 __fput+0x2d8/0x730 fs/file_table.c:280 task_work_run+0x176/0x1b0 kernel/task_work.c:113 exit_task_work include/linux/task_work.h:22 [inline] do_exit+0x5ef/0x1f80 kernel/exit.c:801 do_group_exit+0x15e/0x2c0 kernel/exit.c:899 __do_sys_exit_group+0x13/0x20 kernel/exit.c:910 __se_sys_exit_group+0x10/0x10 kernel/exit.c:908 __x64_sys_exit_group+0x37/0x40 kernel/exit.c:908 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:294 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x4403d8 Code: 00 00 be 3c 00 00 00 eb 19 66 0f 1f 84 00 00 00 00 00 48 89 d7 89 f0 0f 05 48 3d 00 f0 ff ff 77 21 f4 48 89 d7 44 89 c0 0f 05 <48> 3d 00 f0 ff ff 76 e0 f7 d8 64 41 89 01 eb d8 0f 1f 84 00 00 00 RSP: 002b:00007ffd67f7d928 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00000000004403d8 RDX: 0000000000000000 RSI: 000000000000003c RDI: 0000000000000000 RBP: 00000000004c0d90 R08: 00000000000000e7 R09: ffffffffffffffd4 R10: 0000000000402570 R11: 0000000000000246 R12: 0000000000000001 R13: 00000000006d3180 R14: 0000000000000000 R15: 0000000000000000 Modules linked in: ---[ end trace 6b49c4c2b7708f14 ]--- RIP: 0010:__wake_up_common+0x297/0x4d0 kernel/sched/wait.c:86 Code: fb 01 00 00 45 31 f6 eb 13 66 2e 0f 1f 84 00 00 00 00 00 4d 39 fc 0f 84 e3 01 00 00 4c 89 fb 49 8d 6f e8 4c 89 f8 48 c1 e8 03 <80> 3c 10 00 74 12 48 89 df e8 eb 4e 59 00 48 ba 00 00 00 00 00 fc RSP: 0018:ffffc90001687c10 EFLAGS: 00010046 RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: dffffc0000000000 RSI: 0000000000000001 RDI: ffff888091fe13c8 RBP: ffffffffffffffe8 R08: 0000000000000000 R09: ffffc90001687c78 R10: fffff520002d0f82 R11: 0000000000000000 R12: ffff888091fe1400 R13: 1ffff920002d0f8f R14: 0000000000000000 R15: 0000000000000000 FS: 00000000023ec940(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000000020000088 CR3: 0000000096b74000 CR4: 00000000001406f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400