Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
To:     =?iso-8859-1?Q?Christian_K=F6nig?= <christian.koenig@amd.com>
CC:     xinhui pan <xinhui.pan@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Felix.Kuehling@amd.com" <Felix.Kuehling@amd.com>,
        "Alexander.Deucher@amd.com" <Alexander.Deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu: Correct the condition of warning while bo
 release
Thread-Topic: [PATCH] drm/amdgpu: Correct the condition of warning while bo
 release
Thread-Index: AQHV9iAWGvTdIfRZI0Kw62U7ndmsIqhAVmIAgAAV3YA=
Date:   Mon, 9 Mar 2020 16:03:28 +0000
Message-ID: <PSXP216MB0438A4A1EFC2F67579542BB480FE0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
References: <20200309143458.18411-1-xinhui.pan@amd.com>
 <9da8f3a9-5d28-37b9-cda6-8be336068e7b@amd.com>
In-Reply-To: <9da8f3a9-5d28-37b9-cda6-8be336068e7b@amd.com>
Accept-Language: en-AU, en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn:  [dE6dk91ZefiW1+TQzKm03HM8Ja+j6COL0VTItOMcLPHeRm7S1biUwidW8Tx96pKG]
x-microsoft-original-message-id: <20200309160319.GA2812@nicholas-dell-linux>
x-ms-publictraffictype: Email
x-incomingheadercount: 50
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 33125ac1-888e-451b-e2df-08d7c4436793
x-ms-traffictypediagnostic: SG2APC01HT152:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: LhjCBJEkkFHTkkAAVegh1IXPQR1GHNhuxl6cvFuQk1gbvlB7KVnvL4Eqe4vgyKpX1cpAZPr/qLNINNz+Iwo40fD9jl6qg56sPuQAIjOxQwOyJxf90DI07lXYtaRRBuudspu9PFQDs8IG7/zgXXLV2RHyqORAH63cC4I04Lm3butxnxs2icWcXttXicq2zk4E
x-ms-exchange-antispam-messagedata: 7fOxPWnRiQOEFnYSlOjgu1lOR5YNH+OJ/B+OnJ1g5gB+wgTMXChVN6M97zDkH+l/0pE0SlEdChvO12UUAnQpsHxQtE5V8T0oIgxH4ukAzOIeivnmnuZMv5/K91M7k/8W2wCHpCot3EnKok9Ra8OkX1PL1ZGcL0oR/MTJsJuuBcWKiGVNzfmG4RYOms983XoJwIFHNbz3+fO7/wt6mcKwTQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-ID: <D35AF6ECF8697C469713E19640664B10@KORP216.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 33125ac1-888e-451b-e2df-08d7c4436793
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Mar 2020 16:03:28.0540
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2APC01HT152
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 09, 2020 at 03:45:04PM +0100, Christian K?nig wrote:
> Am 09.03.20 um 15:34 schrieb xinhui pan:
> > Only kernel bo has kfd eviction fence.
> > This warning is to give a notice that kfd only remove eviction fence on
> > individual bos.
> > 
> > Signed-off-by: xinhui pan <xinhui.pan@amd.com>
> 
> Reviewed-by: Christian K?nig <christian.koenig@amd.com>
If applicable (I reported but was not the first to report / you were 
already aware):

Tested-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>

The warning went away when applied.

Cheers!
> 
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> > index 5766d20f29d8..e99f68af2bf7 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c
> > @@ -1308,7 +1308,8 @@ void amdgpu_bo_release_notify(struct ttm_buffer_object *bo)
> >   		amdgpu_amdkfd_unreserve_memory_limit(abo);
> >   	/* We only remove the fence if the resv has individualized. */
> > -	WARN_ON_ONCE(bo->base.resv != &bo->base._resv);
> > +	WARN_ON_ONCE(bo->type == ttm_bo_type_kernel
> > +			&& bo->base.resv != &bo->base._resv);
> >   	if (bo->base.resv == &bo->base._resv)
> >   		amdgpu_amdkfd_remove_fence_on_pt_pd_bos(abo);
>