Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp2780723ybh; Mon, 9 Mar 2020 12:53:36 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsk6UAE6UHNpZhJu8IGH8Y7FkaKCSZzmAX8D3RZrPhX+sU+5sW+qIJvgI+k2CeFiywYu08W X-Received: by 2002:aca:3507:: with SMTP id c7mr160687oia.147.1583783615989; Mon, 09 Mar 2020 12:53:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583783615; cv=none; d=google.com; s=arc-20160816; b=O/95rdH/hhPItc29oxbGKbpI2dKZ4EtJKbK5iWgRL2n7sviMQPOIXV47+UwdkqENyh sbuQfwNoQsmm+XJAr7GDnJng7i/vnlL4WqfZH4g1m10m33OpEIiJxwYHeU5to5hpwavG AlFlrfE9Fp3/nSOTYYt1FqGqQ4o5kzwiae+xdj+JBbZXNj2sbVGBZGPPA5NLqfXkryhh WbMQwz++q8WoYUFoOFE3SJcW0jz8bigA8+Ev4UttX7dKkZNFg5Ez3BepTgLVKOYUaAUO JNodKVOMgxNHpkB6OCPJtluxLijGtMT8sjBVyi28Q7IJrFuZGopyFw40nfG6Etjto5Ro SqvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=c1osNqRAKc0726dqEwHuKyvC5yuBvSfA/WeWwR//zkA=; b=ssTfsLeAAH0LFaocKj6KBOLjWtFm+K/LN5bllYtyEGDfX9GVELJL0MKNbpe8rXOCwI Ajxx4ZgTTBUHl5D05gIcU6xPHcP2MdEtofjqU/4huW6CRy7yUNX3hU7LjBNOMuHz2YWS +CHx6vHGYfVcRrqGcskzhQH8IUXtnXzdxnO7ci4mm0QbxwVPpQoMOujIWZuxXGj0Yje5 Um0RRcSz4HRMU68r/Q3uypGjIE7YLY7mjfST+S8OpridZgNPWEDqjSSKtewQf8lT8aT0 phe3yZl1YNOV8qihe7GHTebSpJSSGE1BrUkesIALqo57aS/HT2MedoAwPJW12PmzHESV aB2g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=rHHHsldR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x4si6076646oto.217.2020.03.09.12.53.24; Mon, 09 Mar 2020 12:53:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=rHHHsldR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbgCITvc (ORCPT + 99 others); Mon, 9 Mar 2020 15:51:32 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:38971 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726096AbgCITvb (ORCPT ); Mon, 9 Mar 2020 15:51:31 -0400 Received: by mail-qk1-f193.google.com with SMTP id e16so10515943qkl.6; Mon, 09 Mar 2020 12:51:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=c1osNqRAKc0726dqEwHuKyvC5yuBvSfA/WeWwR//zkA=; b=rHHHsldRAuzPzsRgPpYEEF41npGcL20HK/bsJw2992ey9MCD1z2d/FuTLQuxE7Z7+U UjjRUAWlDcX/hB45O4nq7ukPOkA6tW26Rm5nFJWVe0NEtEWkRX3zjZ/MHACLc22D2njO gg7yxHAarOUO5a8tZGMxrF0Und3s1CJWP3XrMOgP8aqlhpsA2V00Sfovg2MMnzIz/q/Y z95z15IJyPmsgsifkmYCj+k22WS8M1Rk6mvHcTfr2znjU3uThKNQ0rJpr5w21p6mdZTV X0CVA6FjslyawUt5y/SULEsAXCb5NzFPr8XH50Ej7T3a/gbf8EqzGvn3NFjM85Xn/odz qGaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=c1osNqRAKc0726dqEwHuKyvC5yuBvSfA/WeWwR//zkA=; b=p5n8lX/4Nmd8sdHUs72+pAmQibZTglqdIuImuN4Tova3IrBYPO90iTauBDa4uZyxtF T9hfaCbeNl5AfgGhDZq/hQcrodM1ePGfQPP2YuzEZuzD2iQFCnK6tpBmuear4JsJ+sMf EiTjXnPVGi4NS3X5dCimTjc5xZb2Z9jPeVo1jIpcfHNcX3OmzEfcmgZY5WfJGmppZ8sW mpugxNQ7ugP+MRNmevaliwiQpRuX8D2NGqWPHJzEW7ERnz9AbOQX3jw6q25BQ0O+zQCY XY+ECbI2BjyYBql4aU0yE2H4gdxFd9Runv5WvRC1EnSW5hWa0nBNv1vYKY2Dof1TaQzO ynjw== X-Gm-Message-State: ANhLgQ2juhSJdxHE2eWU1zRetvZnTfLy2+I6OHOviPCVpRzhWtZBF3zV XLSoQ9IyLNKN714mTqXoaSJSmAAU1VM= X-Received: by 2002:a05:620a:102f:: with SMTP id a15mr11232027qkk.243.1583783490243; Mon, 09 Mar 2020 12:51:30 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::182b]) by smtp.gmail.com with ESMTPSA id z4sm20660167qtm.69.2020.03.09.12.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2020 12:51:21 -0700 (PDT) Date: Mon, 9 Mar 2020 15:51:20 -0400 From: Tejun Heo To: Joe Perches Cc: Daniel Xu , cgroups@vger.kernel.org, lizefan@huawei.com, hannes@cmpxchg.org, shakeelb@google.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, kernel-team@fb.com Subject: Re: [PATCH v2 1/4] kernfs: kvmalloc xattr value instead of kmalloc Message-ID: <20200309195104.GA77841@mtj.thefacebook.com> References: <6bbfc8b8c9c206d80de43a64bfe4b8083cc2c02f.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6bbfc8b8c9c206d80de43a64bfe4b8083cc2c02f.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2020 at 12:41:05PM -0700, Joe Perches wrote: > If the need is to allocate from a single block of memory, > perhaps you need a submemory allocator like gen_pool. > (gennalloc.h) > > Dunno. Maybe i just don't quite understand your need. vmalloc is the right thing to do here. vmalloc space isn't a scarce resource on any 64bit machines. On 32bits, which basically are tiny machines at this point, these allocations are both size and quantity limited by other factors (e.g. each cgroup consumes way more memory). -- tejun