Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: =?UTF-8?Q?Re:_=e5=9b=9e=e5=a4=8d:[PATCH_1/6]_PCI:_Add_Loongson_vend?=
 =?UTF-8?Q?or_ID_and_7A1000_device_IDs?=
To:     Jiaxun Yang <jiaxun.yang@flygoat.com>
References: <1583742206-29163-1-git-send-email-yangtiezhu@loongson.cn>
 <1583742206-29163-2-git-send-email-yangtiezhu@loongson.cn>
 <170be7ca00e.133ea84fa2305.7803335422925759322@flygoat.com>
Cc:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Huacai Chen <chenhc@lemote.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jens Axboe <axboe@kernel.dk>,
        linux-mips <linux-mips@vger.kernel.org>,
        linux-pci <linux-pci@vger.kernel.org>,
        linux-ide <linux-ide@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>
From:   Tiezhu Yang <yangtiezhu@loongson.cn>
Message-ID: <2ba6de2e-7880-d322-a0f6-5cea2647ea50@loongson.cn>
Date:   Tue, 10 Mar 2020 10:31:56 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <170be7ca00e.133ea84fa2305.7803335422925759322@flygoat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/09/2020 04:50 PM, Jiaxun Yang wrote:
>   ---- 在 星期一, 2020-03-09 16:23:21 Tiezhu Yang <yangtiezhu@loongson.cn> 撰写 ----
>   > Add the Loongson vendor ID and 7A1000 device IDs to pci_ids.h
>   > to be used by the controller driver in the future.
>   >
>   > The Loongson IDs can be found at the following link:
>   > https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/tree/pci.ids
>   >
>   > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>   > ---
>   >  include/linux/pci_ids.h | 18 ++++++++++++++++++
>   >  1 file changed, 18 insertions(+)
>   >
>   > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>   > index 352c0d7..0125ab4 100644
>   > --- a/include/linux/pci_ids.h
>   > +++ b/include/linux/pci_ids.h
>   > @@ -3113,4 +3113,22 @@
>   >
>   >  #define PCI_VENDOR_ID_NCUBE        0x10ff
>   >
>   > +#define PCI_VENDOR_ID_LOONGSON            0x0014
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_HT    0x7a00
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_APB    0x7a02
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_GMAC    0x7a03
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_OTG    0x7a04
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_DC    0x7a06
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_HDA    0x7a07
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_SATA    0x7a08
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X1    0x7a09
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_SPI    0x7a0b
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_LPC    0x7a0c
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_DMA    0x7a0f
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_EHCI    0x7a14
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_GPU    0x7a15
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X4    0x7a19
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_OHCI    0x7a24
>   > +#define PCI_DEVICE_ID_LOONGSON_7A1000_PCIE_X8    0x7a29
>
> Devices IDs are unlikely to be reused by mutiple subsystems, so probably we don't need
> to add them here?

Hi Jiaxun,

I think it is better to define the device IDs in pci_ids.h,
otherwise it seems a little disorganized.

Thanks,

Tiezhu Yang

>   
>> +
>   >  #endif /* _LINUX_PCI_IDS_H */
>   > --
>   > 2.1.0
>   >
>   >