Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932331AbWBPRMx (ORCPT ); Thu, 16 Feb 2006 12:12:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932266AbWBPRMx (ORCPT ); Thu, 16 Feb 2006 12:12:53 -0500 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:26122 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S932331AbWBPRMw (ORCPT ); Thu, 16 Feb 2006 12:12:52 -0500 Date: Thu, 16 Feb 2006 17:12:00 +0000 From: Russell King To: James Bottomley Cc: Greg KH , Andrew Morton , Linus Torvalds , linux-kernel@vger.kernel.org, Jens Axboe , "Brown, Len" , "David S. Miller" , linux-acpi@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, "Yu, Luming" , Ben Castricum , sanjoy@mrao.cam.ac.uk, Helge Hafting , "Carlo E. Prelz" , Gerrit Bruchh?user , Nicolas.Mailhot@LaPoste.net, Jaroslav Kysela , Takashi Iwai , Patrizio Bassi , Bj?rn Nilsson , Andrey Borzenkov , "P. Christeas" , ghrt , jinhong hu , Andrew Vasquez , linux-scsi@vger.kernel.org, Benjamin LaHaise Subject: Re: Linux 2.6.16-rc3 Message-ID: <20060216171200.GD29443@flint.arm.linux.org.uk> Mail-Followup-To: James Bottomley , Greg KH , Andrew Morton , Linus Torvalds , linux-kernel@vger.kernel.org, Jens Axboe , "Brown, Len" , "David S. Miller" , linux-acpi@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, "Yu, Luming" , Ben Castricum , sanjoy@mrao.cam.ac.uk, Helge Hafting , "Carlo E. Prelz" , Gerrit Bruchh?user , Nicolas.Mailhot@LaPoste.net, Jaroslav Kysela , Takashi Iwai , Patrizio Bassi , Bj?rn Nilsson , Andrey Borzenkov , "P. Christeas" , ghrt , jinhong hu , Andrew Vasquez , linux-scsi@vger.kernel.org, Benjamin LaHaise References: <20060212190520.244fcaec.akpm@osdl.org> <20060213203800.GC22441@kroah.com> <1139934883.14115.4.camel@mulgrave.il.steeleye.com> <1140054960.3037.5.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1140054960.3037.5.camel@mulgrave.il.steeleye.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 34 On Wed, Feb 15, 2006 at 08:56:00PM -0500, James Bottomley wrote: > On Tue, 2006-02-14 at 10:34 -0600, James Bottomley wrote: > > Well, I can't solve the problem that it requires memory allocation from > > IRQ context to operate. Based on that, it's an unsafe interface. I'm > > going to put it inside SCSI for 2.6.16, since it's better than what we > > have now, but I don't think we can export it globally. > > OK, this is what I'm proposing as the device model fix. What it does is > thread context checking APIs throughout the device subsystem. SCSI can > then use it simply via device_put_process_context(). Since we have to > supply the kref_work; I'd plan to do that as an additional element in > struct scsi_device. > > This, by itself, won't solve the SCSI target problem, but I plan to fix > that via a device model addition which would have target alloc waiting > around for any deleted targets to disappear. > > Since this is planned for post 2.6.16, we have plenty of time to argue > about it. This is probably an idiotic question, but if there's something in the scsi release handler can't be called in non-process context, why can't scsi queue up the release processing via the work API itself, rather than having to have this additional code and complexity for everyone? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/