Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Yanjun Zhu <yanjunz@mellanox.com>
To:     Leon Romanovsky <leon@kernel.org>,
        Jason Gunthorpe <jgg@mellanox.com>
CC:     syzbot <syzbot+e11efb687f5ab7f01f3d@syzkaller.appspotmail.com>,
        "dledford@redhat.com" <dledford@redhat.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        Moni Shoua <monis@mellanox.com>,
        "syzkaller-bugs@googlegroups.com" <syzkaller-bugs@googlegroups.com>
Subject: RE: KASAN: use-after-free Read in rxe_query_port
Thread-Topic: KASAN: use-after-free Read in rxe_query_port
Thread-Index: AQHV9jkJCU28FFAXfky+bua200OhVqhBcaYAgAAJUZA=
Date:   Tue, 10 Mar 2020 08:21:29 +0000
Message-ID: <AM6PR05MB50143279152CCAB54786D930D8FF0@AM6PR05MB5014.eurprd05.prod.outlook.com>
References: <0000000000000c9e12059fc941ff@google.com>
 <20200309173451.GA15143@mellanox.com> <20200310073936.GF172334@unreal>
In-Reply-To: <20200310073936.GF172334@unreal>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2351a862-edee-495a-0eef-08d7c4cc0889
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Mar 2020 08:21:29.0657
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nLNwtZmPzN1QPPkPKQKmNW1Fnc09gUSKEeeU1mNgnbWrRRutXekLGoYjA/4fJpZe9sbhCCP0ni4jYuPG0hQ/ZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR05MB5473
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi, Leon

Thanks. From the patch https://lore.kernel.org/netdev/20200306134518.84416-=
1-kgraul@linux.ibm.com,

@@ -240,6 +240,9 @@ static void smc_ib_port_event_work(struct work_struct *=
work)
 		work, struct smc_ib_device, port_event_work);
 	u8 port_idx;
=20
+	if (list_empty(&smcibdev->list))
+		return;
+
 	for_each_set_bit(port_idx, &smcibdev->port_event_mask, SMC_MAX_PORTS) {
 		smc_ib_remember_port_attr(smcibdev, port_idx + 1);
 		clear_bit(port_idx, &smcibdev->port_event_mask);

This block is try to check smcibdev->list to avoid ib_query_port after the =
NIC is down.
But smcibdev->list is used by spinlock when add and del.
"
...
549         spin_lock(&smc_ib_devices.lock);
550         list_add_tail(&smcibdev->list, &smc_ib_devices.list);
551         spin_unlock(&smc_ib_devices.lock);
...

579         spin_lock(&smc_ib_devices.lock);
580         list_del_init(&smcibdev->list); /* remove from smc_ib_devices *=
/
581         spin_unlock(&smc_ib_devices.lock);
...
"
So in the above block, is it necessary to protect  smcibdev->list when it i=
s accessed?
Please comment on it.

Thanks a lot.
Zhu Yanjun

-----Original Message-----
From: Leon Romanovsky <leon@kernel.org>=20
Sent: Tuesday, March 10, 2020 3:40 PM
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: syzbot <syzbot+e11efb687f5ab7f01f3d@syzkaller.appspotmail.com>; dledfor=
d@redhat.com; linux-kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Mon=
i Shoua <monis@mellanox.com>; syzkaller-bugs@googlegroups.com; Yanjun Zhu <=
yanjunz@mellanox.com>
Subject: Re: KASAN: use-after-free Read in rxe_query_port

On Mon, Mar 09, 2020 at 02:34:51PM -0300, Jason Gunthorpe wrote:
> On Sun, Mar 01, 2020 at 03:20:12AM -0800, syzbot wrote:
> > Hello,
> >
> > syzbot found the following crash on:
> >
> > HEAD commit:    f8788d86 Linux 5.6-rc3
> > git tree:       upstream
> > console output: https://syzkaller.appspot.com/x/log.txt?x=3D132d3645e00=
000
> > kernel config:  https://syzkaller.appspot.com/x/.config?x=3D9833e26bab3=
55358
> > dashboard link: https://syzkaller.appspot.com/bug?extid=3De11efb687f5ab=
7f01f3d
> > compiler:       gcc (GCC) 9.0.0 20181231 (experimental)
> >
> > Unfortunately, I don't have any reproducer for this crash yet.
> >
> > IMPORTANT: if you fix the bug, please add the following tag to the comm=
it:
> > Reported-by: syzbot+e11efb687f5ab7f01f3d@syzkaller.appspotmail.com
>
> Yanjun, do you have some idea what this could be?

See this fix in the net mailing list.
https://lore.kernel.org/netdev/20200306134518.84416-1-kgraul@linux.ibm.com

Thanks

>
> Thanks,
> Jason