Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp520575ybh; Tue, 10 Mar 2020 03:16:56 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtNdr8BZAHxwT8bNXHrbaPauHUgO+QK7wyNEEMV+vWiIq1S4CqMR+bUPsQYljf5WwW1bVZX X-Received: by 2002:a54:468b:: with SMTP id k11mr563661oic.134.1583835416796; Tue, 10 Mar 2020 03:16:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583835416; cv=none; d=google.com; s=arc-20160816; b=jKGuDQQn3hCEPGvU+5VN8urM7blN/YjXGsC3AXsxqsqgel/Yo64c/RT7jF9qvLsz9M Mg6W0+fL2s7CN9yypziOVPZYS3zBFZzrYN+17FxtBcyQ5Kxn5pEjB6TUCXBqXImeiXoV J4LrWmHR7PoaTxqoRly1OOJuscdbEo5n9pXNBKwq/uCY1Z1fY5+j2v0nMAUw/mqOPud7 YLdlO7l7uACvnr6sdJTPSgp40wxrh740TLNO31HfJFGWIVT4FVK0ZfUOwlsIWMztGCEX 5GSVHPRC9rK4DQqKHzm17x/oKjlOjRlKJE0hnAkKBnaSu66yv3ETPiX5T4D7Gxh+6KTs JLlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:dkim-filter; bh=c1hiVSalTfFe0k0/wchrmFhfrgNpWjBz7yfa9mrIes0=; b=Qjct1EFNwTpFmPRNc5Vh3tpR9QhFTENr12FdAHbgGb1L+k/ajtvvIhbFR52bDr+ZFF c6fjjH1wmJl9Zc9w+g63m/isHiAQ4nZQGaLDTRehqMp62ssyij24MSXzCULAYqpz/yu9 cwzOwBALAZgXStrzLTDO9rdx/FiS79KeSjvdDooysNvbYuQmks4uK2+pLd6IVqk8pDh+ MLte75fpx9OeLp3SUA7RwlNUa/oGISQwnLWEdwG291dFwId+GLuIN37quHHwidD9baLL 1GoDb3KfzUYxHU7fX57W6ukxb9qbPFcbazX1Y3VZJ9tjUjXzzD0K8xRZaCsu0qrjatUp kdQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=czPo1Alz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x2si5145735oie.56.2020.03.10.03.16.44; Tue, 10 Mar 2020 03:16:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=czPo1Alz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726446AbgCJKPN (ORCPT + 99 others); Tue, 10 Mar 2020 06:15:13 -0400 Received: from conuserg-09.nifty.com ([210.131.2.76]:28070 "EHLO conuserg-09.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbgCJKPN (ORCPT ); Tue, 10 Mar 2020 06:15:13 -0400 Received: from localhost.localdomain (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-09.nifty.com with ESMTP id 02AACqfV019796; Tue, 10 Mar 2020 19:12:53 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-09.nifty.com 02AACqfV019796 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1583835174; bh=c1hiVSalTfFe0k0/wchrmFhfrgNpWjBz7yfa9mrIes0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=czPo1Alz4v2bYy/O+q1ieUqOMyecpHvIpktuzimVqNuSLSW59yllVakJKLtmz+z40 yOKERYzt+YCkxIqs7mQdJHtYA7sxpB54U/94Lu6Mo2udosIOymxVX3ifGZajrk5YHV y9DAzF3XmhsdprFlMsBZOZYKD/g4QyDUv93/1/G6o85FzesJ+32gw7hHJOJCzQJtvo no/VAdi3c8JpC4+3UMLk+cs/orlJ6vaUxybrzWKG+621Sk5gmrtC6aHW5VyhWgqyDe w8A5BZAf1opTQjUIxh3iIkI0Q8Zjfg7SN0VjCrsyIwDxed7S/2nGS8EIBzXedUTpet y7zsLNw7eD/rA== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: Ard Biesheuvel , George Spelvin , Masahiro Yamada , Dan Williams , David Howells , "Eric W. Biederman" , Greg Kroah-Hartman , Herbert Xu , "Joel Fernandes (Google)" , Krzysztof Kozlowski , Masami Hiramatsu , Mauro Carvalho Chehab , Patrick Bellasi , "Steven Rostedt (VMware)" , linux-kernel@vger.kernel.org Subject: [PATCH 2/2] int128: fix __uint128_t compiler test in Kconfig Date: Tue, 10 Mar 2020 19:12:50 +0900 Message-Id: <20200310101250.22374-2-masahiroy@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200310101250.22374-1-masahiroy@kernel.org> References: <20200310101250.22374-1-masahiroy@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The support for __uint128_t is dependent on the target bit size. GCC that defaults to the 32-bit can still build the 64-bit kernel with -m64 flag passed. However, $(cc-option,-D__SIZEOF_INT128__=0) is evaluated against the default machine bit, which may not match to the kernel it is building. Theoretically, this could be evaluated separately for 64BIT/32BIT. config CC_HAS_INT128 bool default !$(cc-option,$(m64-flag) -D__SIZEOF_INT128__=0) if 64BIT default !$(cc-option,$(m32-flag) -D__SIZEOF_INT128__=0) I simplified it more because the 32-bit compiler is unlikely to support __uint128_t. Fixes: c12d3362a74b ("int128: move __uint128_t compiler test to Kconfig") Reported-by: George Spelvin Signed-off-by: Masahiro Yamada --- init/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/init/Kconfig b/init/Kconfig index 20a6ac33761c..4f717bfdbfe2 100644 --- a/init/Kconfig +++ b/init/Kconfig @@ -767,8 +767,7 @@ config ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH bool config CC_HAS_INT128 - def_bool y - depends on !$(cc-option,-D__SIZEOF_INT128__=0) + def_bool !$(cc-option,$(m64-flag) -D__SIZEOF_INT128__=0) && 64BIT # # For architectures that know their GCC __int128 support is sound -- 2.17.1