Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp562217ybh; Tue, 10 Mar 2020 04:09:52 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuPzztGGULwmjbRHoMNKqcibYYJXsmSb0OHZNFfNxBH/qWkDElt0a0Kk6MvIOD+0frYK40R X-Received: by 2002:aca:fcd8:: with SMTP id a207mr742248oii.56.1583838592662; Tue, 10 Mar 2020 04:09:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583838592; cv=none; d=google.com; s=arc-20160816; b=W+viOQ7oPXXUw6BeR6rQpsIeVhUUc+ittU5X9Z6QfugIH25cI4O+A0zuDD1/v2bRAH RzQAjk1R6ON8rQ2DtaRVGoBXjMHFuD3iWew8ZvBzN4iaBQKZaJexWiaPNNbvbD/r1cB1 X7YLlhT1bUk4tq7RZCXLgFTtZUVJd4pz77NR+Fi1RJ8Hg3p2Y6ojolfagwsgPWc+ZGi2 Lz6LOTUHMTBKUyuHZtq547TSPE9uo0dIQmKbqyIGt6TAMx8CHYsWqZeQH4mHJagq0z+I inKBC27UCTZvfWDLBL40eu6ZZQoa+aBCKYfQso0uTcimtGyYhRFLJEwGYBfkUP9UL702 cJgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=NLbmp6bW9B7OsLKSubj4LOvRjmIgDRbX4DKrnaThSj8=; b=b12eV/edV3cvxr1/8jTRO4Zltzdo/Da7ZGyN4hP8qP2KqsL0zJu6wPnGhgvWvX0tyl Mh5CpXYNLCc+0/LZJOO1HD8kFiNJV066CeCz3YGm8c3sm70dN6qEDd5RcGDxxZKAM4NP HHg4vaGMKTZsvszBia+gqs8f64xozKWadD/wig+SRBrq/6DVSvm+B40eSy3IN/TFIyXS YOINGD8PIgo9/qXx88742GJ/J5x82uXVtnPkJpWP/J9AFIb8f2MSSC8s2h3/H6Bhly7o SSkm95VZPE3NjVhK6VomwtdtVlDgH31WH4+t6fdlM4AvuAcyamLzHwL3YUTWgBzV8IZB ITuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ZySw3lnm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j9si4762148oiw.133.2020.03.10.04.09.40; Tue, 10 Mar 2020 04:09:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=ZySw3lnm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726269AbgCJLIA (ORCPT + 99 others); Tue, 10 Mar 2020 07:08:00 -0400 Received: from mail.skyhub.de ([5.9.137.197]:50750 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726186AbgCJLIA (ORCPT ); Tue, 10 Mar 2020 07:08:00 -0400 Received: from zn.tnic (p200300EC2F09B4000CCA2EEF87DC47A5.dip0.t-ipconnect.de [IPv6:2003:ec:2f09:b400:cca:2eef:87dc:47a5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BF4E61EC0273; Tue, 10 Mar 2020 12:07:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1583838478; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=NLbmp6bW9B7OsLKSubj4LOvRjmIgDRbX4DKrnaThSj8=; b=ZySw3lnmctyl8oeUPZzrtCq2JhRmON6AyovzV9gGKlp/OcXDigwH4UHCnrBhGlH2irE8X4 xSyRiOjcRh+tVgmMKAymn84+KtNuTQbtU6cbUCvsdccF+vDv7ub/vDUqPBuR/fKEtW+jyF bWeBJYlq8dTciyrngPgDuBLU8ccMjbU= Date: Tue, 10 Mar 2020 12:08:02 +0100 From: Borislav Petkov To: Alexandre Chartre Cc: Thomas Gleixner , LKML , x86@kernel.org, Steven Rostedt , Brian Gerst , Juergen Gross , Frederic Weisbecker Subject: Re: [patch part-II V2 08/13] tracing: Provide lockdep less trace_hardirqs_on/off() variants Message-ID: <20200310110802.GC29372@zn.tnic> References: <20200308222359.370649591@linutronix.de> <20200308222609.731890049@linutronix.de> <07a50582-1c2f-7f45-c7dd-5ff9c2ff3052@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <07a50582-1c2f-7f45-c7dd-5ff9c2ff3052@oracle.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 11:55:57AM +0100, Alexandre Chartre wrote: > Shouldn't trace_hardirqs_on() be updated to call __trace_hardirqs_on()? It's the same > code except for the lockdep call. Fell into that one too initially. Look again. :) -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette