Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp598628ybh; Tue, 10 Mar 2020 04:53:56 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtHKVPD5cSvnb3HGCw2flSguIyt0J9aUHWWuFcI8lQWu1spvy4768qh2RrAw4sOy5w0oZu3 X-Received: by 2002:aca:a857:: with SMTP id r84mr827167oie.65.1583841236407; Tue, 10 Mar 2020 04:53:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583841236; cv=none; d=google.com; s=arc-20160816; b=UX9rda0+tZjnYTMs2Nfv3bX3QhJlhRDpGk9lielnK+j0ioRJLOpBht/F+OEsHrjtmg xBwnZ3vZWbRNqMsgMxXB1rYvb62xvQ3cnD+1dBfQVAJdxvvCh/JjJoGI44yuYlmXNqgc OUAWjy0qqfGZpo6VU77x6hUb/nOX1haCF5ZVCC/GHmUpMNBuAqjh0mKIwtkQvIRWFIPj cL/K7LTlyObERc5sJLaQDCW5YxMkR5Otl9KzA2wlR1FTnidMQ5JfPHnyYKU0NrcvrGyC vsAh8S5EM9AVb3PpXeAFkaBfBFGtilcz4JSGEdm24pHD1XZPZUyLKl7TzgE3TRfS+yjN ItxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=kroQ8FsSeA+xxwJ4JRP03YiyvBIuCnBbtbz4zjzrWGw=; b=nDg1AXHNGep4U+Ohh9ZScjyAh2fF0EsblDm9o84oQtcHM7atcUBGtA59O3Zw4chw8g hyDsGtWYL2qNBYPV1xOtoerSstzjYvsaGXP/jprigH/JKMizAmYp7+b1H8OxfM3zKHZ+ kXilVOOuKu+KHiwFy4sR8FWR+cTgGFP0jA/WRZG/PUhxliyjKns0srZ8Z2Gw1laa9rC9 u/ztnvKLuydgGPrQ6MmmlfrSBag4LRe44B0o88vjTKzt+v3POmY/BERaiW2i1sgP5C2Z MKbV8afoMhMod/EVOvZrhLbhQ6fzMjrR9ibwKq+3n2Df863cSbATbKnURbBwDso1pmXp h5FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sjCiWvrQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c83si6306055oig.116.2020.03.10.04.53.44; Tue, 10 Mar 2020 04:53:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sjCiWvrQ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726420AbgCJLxY (ORCPT + 99 others); Tue, 10 Mar 2020 07:53:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:43082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726205AbgCJLxY (ORCPT ); Tue, 10 Mar 2020 07:53:24 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2514524680; Tue, 10 Mar 2020 11:53:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583841204; bh=9Dqcrvid3TzQgZ9K1Vvw91iUzAv4QQy5lINcNKCa/so=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=sjCiWvrQsolPGGawdf8DitKDpTSHdufJ9q+aIS3KMYbySomPXkCgOtBchAWe09kWT paeMlaX3QMSvoon7YaHpUFg2Zm3VcIqdZGYsNh3YEdUsGv8C4dYcPyvWeOhmhmZbl4 R1OvSiEkS5OqQly2085o8KQu/CmwGsBrKFH5wzR8= Date: Tue, 10 Mar 2020 12:53:21 +0100 (CET) From: Jiri Kosina To: Tony Fischetti cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] add ALWAYS_POLL quirk to lenovo pixart mouse In-Reply-To: <20200304164700.11574-1-tony.fischetti@gmail.com> Message-ID: References: <20200304164700.11574-1-tony.fischetti@gmail.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Mar 2020, Tony Fischetti wrote: > A lenovo pixart mouse (17ef:608d) is afflicted common the the malfunction > where it disconnects and reconnects every minute--each time incrementing > the device number. This patch adds the device id of the device and > specifies that it needs the HID_QUIRK_ALWAYS_POLL quirk in order to > work properly. You are missing Signed-off-by: line here (please see Documentation/process/5.Posting.rst and Documentation/process/submitting-patches.rst to read what this is about). Also, we generally prefix all the patches to HID susbsytem with 'HID: ' in the subject / shortlog, so as you'll be resending with signoff, could you please fix that up at the same time as well? Thanks, -- Jiri Kosina SUSE Labs