Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp657842ybh; Tue, 10 Mar 2020 06:02:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsYv9kShH6xGgUaHOCA1dTnrg0bCOV//9HAzAvr4JWeskJ1UKJbeJlPT7l9U8Vfh1ZFWJMr X-Received: by 2002:a05:6830:1c77:: with SMTP id s23mr12009232otg.191.1583845322323; Tue, 10 Mar 2020 06:02:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583845322; cv=none; d=google.com; s=arc-20160816; b=E9T+SeaFa45Xr7eeIZLYmLIyLb/elbVUl5WTpLjdOirwmyCsNMbLKWMD/mbatIY/VB hiDMBiCGJQRD+9TO026QNnyCSF+FCMYRpgUS/pap+Qt4rjCmcasCDHIejCDpUblt7Zm4 dD4hDmqb+XZu1tgBVSvqfArvOLkEZ10VyTFW9/pSt65Ne2E1vSsFyYB0bRjlHlPkdqp6 vGrx8A4QdmFbSsZYExUh8BTjp6v9pg7izKqFmJKekPRTG+NZDIfYelpiUaDairlKGWn4 //lqGqxK3egMkRFP0Axwb9Lb2xk32SXHyDjfNgB7NyeVI6Dawr929yA+WKZ6N7bnYWVi MhJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BggrrlrtQqkSECvYXQARW/5X4rjO/VY+TdpiikoeCsw=; b=LJ181Wd71Q3Y6/Gitel0/GIegxM8zIepwBg2IRhTtbp7xW2itvJb+6wJBOYIB1okVs jSfd8OhEtNQxz7gjCQpY4Flp/WK6L3ZjiUEiLY+dxOSVPDE6oV/oisef82PynHKCY4nv 43f6FH+kVhLThB1vxyb2ZUqqIlGWAwJSvHlpLj18kQqmzrL+EBjba1ISBm8rAjJw42Fw I4nTTLDkEYLcePVxKWfl06+Cj56gsEwBAQ8ITJddcRMXPXyiwlxSd3ezLSXZAFWPacAQ bF8rvBKWSmZvI4j0jbXni77QvsraefHbF3CTrRjfLuSsu7XPrp88O+NfOJ9ulaAcXThT hRow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oos0ro4Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r129si2896038oib.123.2020.03.10.06.01.32; Tue, 10 Mar 2020 06:02:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=oos0ro4Z; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730167AbgCJNAn (ORCPT + 99 others); Tue, 10 Mar 2020 09:00:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:41510 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729899AbgCJNAk (ORCPT ); Tue, 10 Mar 2020 09:00:40 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC8522253D; Tue, 10 Mar 2020 13:00:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845240; bh=YdL6srul3R7Y6m6aFXkHfEa6dkbwy5CkfR5vAKHotE8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oos0ro4ZlyuWezXCc/+QPI63x3HtM9Ca1Pdj1A750tJAiVXkfakTNiFzZF7xbN3h4 eA+W4Tk3dRIgMNlNZfZ7H5MTURECYftfuo2RJ8o0Tory/H651WeocXhWV/7LRbrBq9 1nu46cO3CezLZVj0y5ihYSx73zAggG827fqEleDc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gerd Hoffmann , Gurchetan Singh , Guillaume Gardet Subject: [PATCH 5.5 111/189] drm/shmem: add support for per object caching flags. Date: Tue, 10 Mar 2020 13:39:08 +0100 Message-Id: <20200310123650.922870835@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310123639.608886314@linuxfoundation.org> References: <20200310123639.608886314@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gerd Hoffmann commit 1cad629257e76025bcbf490c58de550fb67d4d0e upstream. Add map_cached bool to drm_gem_shmem_object, to request cached mappings on a per-object base. Check the flag before adding writecombine to pgprot bits. Cc: stable@vger.kernel.org Signed-off-by: Gerd Hoffmann Reviewed-by: Gurchetan Singh Tested-by: Guillaume Gardet Link: http://patchwork.freedesktop.org/patch/msgid/20200226154752.24328-2-kraxel@redhat.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/drm_gem_shmem_helper.c | 15 +++++++++++---- include/drm/drm_gem_shmem_helper.h | 5 +++++ 2 files changed, 16 insertions(+), 4 deletions(-) --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -254,11 +254,16 @@ static void *drm_gem_shmem_vmap_locked(s if (ret) goto err_zero_use; - if (obj->import_attach) + if (obj->import_attach) { shmem->vaddr = dma_buf_vmap(obj->import_attach->dmabuf); - else + } else { + pgprot_t prot = PAGE_KERNEL; + + if (!shmem->map_cached) + prot = pgprot_writecombine(prot); shmem->vaddr = vmap(shmem->pages, obj->size >> PAGE_SHIFT, - VM_MAP, pgprot_writecombine(PAGE_KERNEL)); + VM_MAP, prot); + } if (!shmem->vaddr) { DRM_DEBUG_KMS("Failed to vmap pages\n"); @@ -537,7 +542,9 @@ int drm_gem_shmem_mmap(struct drm_gem_ob } vma->vm_flags |= VM_MIXEDMAP | VM_DONTEXPAND; - vma->vm_page_prot = pgprot_writecombine(vm_get_page_prot(vma->vm_flags)); + vma->vm_page_prot = vm_get_page_prot(vma->vm_flags); + if (!shmem->map_cached) + vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); vma->vm_page_prot = pgprot_decrypted(vma->vm_page_prot); vma->vm_ops = &drm_gem_shmem_vm_ops; --- a/include/drm/drm_gem_shmem_helper.h +++ b/include/drm/drm_gem_shmem_helper.h @@ -96,6 +96,11 @@ struct drm_gem_shmem_object { * The address are un-mapped when the count reaches zero. */ unsigned int vmap_use_count; + + /** + * @map_cached: map object cached (instead of using writecombine). + */ + bool map_cached; }; #define to_drm_gem_shmem_obj(obj) \