Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp661023ybh; Tue, 10 Mar 2020 06:04:37 -0700 (PDT) X-Google-Smtp-Source: ADFU+vujK7IIiD5QwXzc2HAxXREXdHrRyh0Skx6B2GlpGixg+dcxMCeFMj/QGo8bujD6wO1vz4Bl X-Received: by 2002:a9d:e83:: with SMTP id 3mr16740034otj.93.1583845477071; Tue, 10 Mar 2020 06:04:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583845477; cv=none; d=google.com; s=arc-20160816; b=h5PskRVRHxjwGtUYDW1dqtfMVswWutVvxejbwpJqJNIhrUytqgJ14VvZ9x1qxFGLhi JB9F7CCG8YKECNzj74EwgZ6WJdlFRiyBV/BknnYifVjNkVJxMogwE6RrmiGHEndEO1Df 2GSJQqY797+Aj0Zw7jvmufOKWLudcOq8uk2R/dcnc5dblhXgRwuzxaiU6fO6WPG4aTHc bmXHHxZ14HujvyeQAwASDNbXxoEgQ+vCvA74iVH+p2pez1w6aOHUS5pX6pO+tZUALQdD HPfgDpttl5iWa+6sQiobyXANwT6BG8DK9IkbaavERDrgCawZw/W580InShwvRe5mpz4W 9Rrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9UbbocVeSn1/1/Pb+hVl2hk56aZ00ETyfMembY+U3QE=; b=VanWsXwRG8NivU8aPPoXklnOQ1gK4FgmKcGpE1LYs5gJFtWBd/lj/i4B4ZIYDJjVXL E6xJ2XcZWZXgbN3AMxEm0WX1aNbaUr9g8CvLVDEjvTxAy8eI5eIcrXCC5nNn9hkQuCcK iMZm6nGNcVRfT5i28/6wBPq9jtQ7rWm5lqDD2kWifVR/4qLPXqf/t8OxpzZKqEiq+lfG wj49c1ht2Zx8QciOPcOtLq82nCEX3xm0nIC3MfGDQ68nawHdnnWYP0mUbpfCEnJFwwCo 3roEraKFdnFNlgh95jjxfVKQuwd4yUOo7q9oiw5qN10sdUHpuaPZfuspCBlB7QWm4UC/ UNpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TUDPy8kp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c22si7582803otr.97.2020.03.10.06.03.36; Tue, 10 Mar 2020 06:04:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TUDPy8kp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728806AbgCJNCH (ORCPT + 99 others); Tue, 10 Mar 2020 09:02:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:43998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730357AbgCJNCF (ORCPT ); Tue, 10 Mar 2020 09:02:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 820D524649; Tue, 10 Mar 2020 13:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845325; bh=WM+6gQC/u1UCuyRxHEy0/EwiMOIe8+N1pYqTLo0kF64=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TUDPy8kp70LTtSpi3Yh2ypY6L8It/V6XM8HIlxLOQbeWPpCZxDCl3VD0prorOl0oD yb8k87VBh69xnz4tgtRgJik8AjjcV5MAu3h6JdCRAP/d0q1BN7LP+VfihsCmRGyIbR tJ+cjam+DxqYbHhECCuZZP/sGuP2nCVo5LcG8T5c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Phong LE , CK Hu Subject: [PATCH 5.5 142/189] drm/mediatek: Handle component type MTK_DISP_OVL_2L correctly Date: Tue, 10 Mar 2020 13:39:39 +0100 Message-Id: <20200310123654.188930993@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310123639.608886314@linuxfoundation.org> References: <20200310123639.608886314@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Phong LE commit 3d2ed431b8f39483477bc3c3a2aefbc9778ffe12 upstream. The larb device remains NULL if the type is MTK_DISP_OVL_2L. A kernel panic is raised when a crtc uses mtk_smi_larb_get or mtk_smi_larb_put. Fixes: b17bdd0d7a73 ("drm/mediatek: add component OVL_2L0") Signed-off-by: Phong LE Signed-off-by: CK Hu Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -358,6 +358,7 @@ int mtk_ddp_comp_init(struct device *dev /* Only DMA capable components need the LARB property */ comp->larb_dev = NULL; if (type != MTK_DISP_OVL && + type != MTK_DISP_OVL_2L && type != MTK_DISP_RDMA && type != MTK_DISP_WDMA) return 0;