Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp671366ybh; Tue, 10 Mar 2020 06:13:36 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtU6hZHbZKXHsd+v3o+Ku/6GdcQMhdFwnzYWg0r3e9nf/VoeAmdJhdeYYd4LqT4rnWoLE1j X-Received: by 2002:a9d:649a:: with SMTP id g26mr17168474otl.266.1583846016503; Tue, 10 Mar 2020 06:13:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583846016; cv=none; d=google.com; s=arc-20160816; b=sYM1/jsJIbNzI8jOI5fTYOB+HfnEIfJdd5W0/KbOiiYIKDzHg0XODNBc9YVqLti+Ch izCDa/hRiFWBUQB/jWqbr0CKEg3WSeFQm+hXD3NsStUK/VFmx4y8pYyu76nlKigbO4h8 LpxmoD9Dw4VyuIIPj7pWTJLNQm2eWZEZylUE3nX1TGALo4YtEEz30OYf4lzqIcryne3m 82+5+O6Sg+m0ax30Pvmzt8DcckjkpHW3WrQ63/njICyKIt3pM/TY1HOo36ffu2NgFxP+ RCqfN3OpU3PCeDb6jrTyDPJ2+WGZINnTCJ8kMxS5SckmTsEnjfPGnR3JXOKK48XqYw2z wNYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=w2QvXqPy8HvwmCVQZ68MYU1ZDRoxJocIZFIPaa/iRls=; b=zpUR8yLaqpwS6Lx97WJ3E5aw0mYL6vVHKB2F6vL9+nWkP8ySnk/bUs0HeT0YwfV5N5 EN9OXZilWU045rV051S9CsJS/2i9hwJ4oUV2tlpzXAIM8ZZMcsW97r949pZDWhYCHF1f J9vDV+fCmMm6agOexbDypk7ZTKeVeEOo13wEW7v9UxpUTih4RbLf1sRbsJh1zHQepDX1 SNi/Lg3HkV70ZKaQlDEVeosBMJcKkFifj7nuQs3vyKK5Zye81EZZ8ok759XWjlRqo1lk vEUIuRT9PHrcjy3SnjdYF3KIzoqEaPh//JPl+PFuMkyGYLlclY5cASse0BxcTKZ8suEN 3hdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OW2dgSqD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c85si5132928oig.225.2020.03.10.06.13.24; Tue, 10 Mar 2020 06:13:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OW2dgSqD; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731109AbgCJNLq (ORCPT + 99 others); Tue, 10 Mar 2020 09:11:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:33432 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729636AbgCJNLo (ORCPT ); Tue, 10 Mar 2020 09:11:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9EBA624692; Tue, 10 Mar 2020 13:11:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845903; bh=b7xbu10NILajY7iOF6KfhKRif8igXrRPpdUliF2ksx4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OW2dgSqDOGSWGEzqSYyze5Sn1qTktMmt2/LSiarT5qLJnPQTk42v5+Szpa4jqzBCo 1Cc4LT0OTuKkJvsZuo/mM2p2uilH6s865vHM01hYBDTSAPm6QBV9yNHP7TR3NFVNgv 2jrdpPg1M0NfRFw5WHVq2hZM3pkvncdeTpetwyFI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Harigovindan P , Rob Clark , Sasha Levin Subject: [PATCH 4.19 16/86] drm/msm/dsi: save pll state before dsi host is powered off Date: Tue, 10 Mar 2020 13:44:40 +0100 Message-Id: <20200310124531.665464778@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310124530.808338541@linuxfoundation.org> References: <20200310124530.808338541@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Harigovindan P [ Upstream commit a1028dcfd0dd97884072288d0c8ed7f30399b528 ] Save pll state before dsi host is powered off. Without this change some register values gets resetted. Signed-off-by: Harigovindan P Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 5 +++++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 ---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index bd66d2aac41f7..b01762a7778ae 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -471,6 +471,7 @@ static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge) struct msm_dsi *msm_dsi1 = dsi_mgr_get_dsi(DSI_1); struct mipi_dsi_host *host = msm_dsi->host; struct drm_panel *panel = msm_dsi->panel; + struct msm_dsi_pll *src_pll; bool is_dual_dsi = IS_DUAL_DSI(); int ret; @@ -511,6 +512,10 @@ static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge) id, ret); } + /* Save PLL status if it is a clock source */ + src_pll = msm_dsi_phy_get_pll(msm_dsi->phy); + msm_dsi_pll_save_state(src_pll); + ret = msm_dsi_host_power_off(host); if (ret) pr_err("%s: host %d power off failed,%d\n", __func__, id, ret); diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index 9a9fa0c75a131..c630871de7c5b 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c @@ -726,10 +726,6 @@ void msm_dsi_phy_disable(struct msm_dsi_phy *phy) if (!phy || !phy->cfg->ops.disable) return; - /* Save PLL status if it is a clock source */ - if (phy->usecase != MSM_DSI_PHY_SLAVE) - msm_dsi_pll_save_state(phy->pll); - phy->cfg->ops.disable(phy); dsi_phy_regulator_disable(phy); -- 2.20.1