Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp679909ybh; Tue, 10 Mar 2020 06:21:40 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuRD1yAuQqxt6gp7QZdgLp47SCqr1JZV/tV7rFy+C4Dt8GlvoUFSIsqJKI3q5Q4K3Vg17f9 X-Received: by 2002:aca:dc04:: with SMTP id t4mr1051815oig.51.1583846500128; Tue, 10 Mar 2020 06:21:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583846500; cv=none; d=google.com; s=arc-20160816; b=vqNkgVYFEnepj5sJEyG6L/8BylpEw4fXOyuOmOYRC+pD+MQpqRXKjvZUp2HUji7WbQ ntYeibTYbIU4/jvEJbBccuJ57j1AUadYcv5rXV1fMPiWE2NR5Lz6h8ax2hixkdx1kdLW AnaWVxB169/4V7DNBkL3e7y2co+rJNugiZIqnYQc6zB2LV+5xQa6sA50WHdtOttHdx50 ywn9WFU/lX6lMXOaLtzdAWmcx8xawql0t6r460/2m1LmE0YPQgFCyjEdk91aeRQjwrXF /IOQHJNG8pTcleFg7c+x9Vvu3I5r1SVYGh39NfBl+rse99okpgexjIzM8gA0297lVEO5 234w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=rV6SG6wlTmbKgaVt4bH7RTQKKxnbf/sO6Z7No511Yv0=; b=jVLEhUdvdXJ3Dwb9IDU5Y59CareXL9kI4K1pBppe0RBW9brb9Wk/hqgBWuBAoF1cTd NMwcqOesTX4C93SPg6WKZzhk9XvmfzR1kYXrvhC116oV9Kim6fTUuwFIZE1rd1ZTM8Og nRStc5NJo9SVsuO9GQ8iEAbRL/jspqNp9UmLRxaGUmqz0KWvPWJfxPR4Yc0+PdxrUO29 gRZW1xZgW13WOgEYIsK8HSV4sThEp/Z+tdtym1tLrIw+RZ/KJzb7uImy0Vha0++ldqd0 ndjADN5bcpE2Xa5Vyvz0iH8f8mizFnRbpHmsBZ2ZdbpTCRWYL0IkFlKMkAfJ5VAtADuB tWeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C6kN9QoR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r3si4933370otc.58.2020.03.10.06.21.27; Tue, 10 Mar 2020 06:21:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=C6kN9QoR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730173AbgCJNTX (ORCPT + 99 others); Tue, 10 Mar 2020 09:19:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:55894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731175AbgCJNI6 (ORCPT ); Tue, 10 Mar 2020 09:08:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1B24B2468D; Tue, 10 Mar 2020 13:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845738; bh=TZNA2TVM3aGgVsvEbNQ6ouxAgPJTw+ElW2D2JSSBOgM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=C6kN9QoR3STgdZDk8Vbsp34etHp3o6GmY9SNiY178JX3BHuj9s0sxbLRZwvnvYfTE NszwPo5g7DGNL3DB+cwRektvd6HGRG2uO40fFUHaAa8s3oaG4svpyqPKpO1xLTXUei owHQUOM8qwWtU2KCHs9QzT9R5Z+3TUkv996g3xk4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Harigovindan P , Rob Clark , Sasha Levin Subject: [PATCH 4.14 081/126] drm/msm/dsi: save pll state before dsi host is powered off Date: Tue, 10 Mar 2020 13:41:42 +0100 Message-Id: <20200310124209.079904695@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310124203.704193207@linuxfoundation.org> References: <20200310124203.704193207@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Harigovindan P [ Upstream commit a1028dcfd0dd97884072288d0c8ed7f30399b528 ] Save pll state before dsi host is powered off. Without this change some register values gets resetted. Signed-off-by: Harigovindan P Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 5 +++++ drivers/gpu/drm/msm/dsi/phy/dsi_phy.c | 4 ---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dsi/dsi_manager.c b/drivers/gpu/drm/msm/dsi/dsi_manager.c index 7d46399a39b4d..9fbfa9f94e6ce 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_manager.c +++ b/drivers/gpu/drm/msm/dsi/dsi_manager.c @@ -543,6 +543,7 @@ static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge) struct msm_dsi *msm_dsi1 = dsi_mgr_get_dsi(DSI_1); struct mipi_dsi_host *host = msm_dsi->host; struct drm_panel *panel = msm_dsi->panel; + struct msm_dsi_pll *src_pll; bool is_dual_dsi = IS_DUAL_DSI(); int ret; @@ -583,6 +584,10 @@ static void dsi_mgr_bridge_post_disable(struct drm_bridge *bridge) id, ret); } + /* Save PLL status if it is a clock source */ + src_pll = msm_dsi_phy_get_pll(msm_dsi->phy); + msm_dsi_pll_save_state(src_pll); + ret = msm_dsi_host_power_off(host); if (ret) pr_err("%s: host %d power off failed,%d\n", __func__, id, ret); diff --git a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c index 7c9bf91bc22b6..c0a7fa56d9a74 100644 --- a/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c +++ b/drivers/gpu/drm/msm/dsi/phy/dsi_phy.c @@ -613,10 +613,6 @@ void msm_dsi_phy_disable(struct msm_dsi_phy *phy) if (!phy || !phy->cfg->ops.disable) return; - /* Save PLL status if it is a clock source */ - if (phy->usecase != MSM_DSI_PHY_SLAVE) - msm_dsi_pll_save_state(phy->pll); - phy->cfg->ops.disable(phy); dsi_phy_regulator_disable(phy); -- 2.20.1