Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp680508ybh; Tue, 10 Mar 2020 06:22:16 -0700 (PDT) X-Google-Smtp-Source: ADFU+vureXExtzAmlpYYU7rLBqMA2rWFiJ1lk5RfXqBn2PSg6DoUXrGTOn2pU4sgavz9jXB+xNXz X-Received: by 2002:aca:3c45:: with SMTP id j66mr1139923oia.62.1583846536815; Tue, 10 Mar 2020 06:22:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583846536; cv=none; d=google.com; s=arc-20160816; b=DPio2f8UetgiKk4EIgxDtSL/4ifO+Cp7b+MixwgdCbE97wMcdDdyBkMgKBRbdsNILV nzP1RxS7JuK+t1tYQ+V081j0h+cHY9k8EtURZrA1wstgugAil1PWN+nuWpI5y7Bofgys SKAqAkEJD6viyfIbL1EbwnUIIP9YKX5StvzHwIujvsWccQzYlQSEj2wnEfpr75mgxqLK NLOe1+TaqiGTogE94GiC65D+fDgMBfdWk8bA75thwqh1PTOTgfPaqc5H+gc09yAsgwCz Pep1Rjof8bRyUmOglYi1ClDTXJ4VcFoMMLJvvzJ4rFBRM/YXPik+CIuZNLRIqRUA30oo 2bMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Y0EQ3LWs8a6KSydxRFf/8uZJUdaKoAzasBm6jxOgJGw=; b=wLmfmogo9sfs3oaOHXdLPH5cHu4QcG+EncyibM8QAdkuoaNYeb4BnSDYjobSjhUs+9 A1kvx1Kd7i/KFD/hmHdQFIbt4HpKz0NUdOvYWuqCHbyhB9g7hmPGbFyrP+gEKcg42eLN xhhOwB9aOwHiBAuXgj/wRu8/+v8xc34ursadHZf6Ykoo/Zqgxm4g7kanFAF08tYbQOC6 cE5+e+1Hr3w9GXgqFpKvsFSFmxZBw/IMD7p4s+9IgC92zpYZMRjsN/qUl3um/k6iLGNk yuOLguR7y3wyckdiP+PEA5b5tHT72HXsZGKES1eacFtZH614phWTwEb7mZViBYz46Gqm LVJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="am/0jn6y"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q16si7268071otc.293.2020.03.10.06.22.04; Tue, 10 Mar 2020 06:22:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="am/0jn6y"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730740AbgCJNH4 (ORCPT + 99 others); Tue, 10 Mar 2020 09:07:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:53832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730271AbgCJNHt (ORCPT ); Tue, 10 Mar 2020 09:07:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 979FF20873; Tue, 10 Mar 2020 13:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845669; bh=+4WPWUaGDWLShhdy5FaNvPbfl02ykHihgTT9PqSSayA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=am/0jn6ytoJ/eLLILEzYctdYZPEhxFMJeDfU8SFybOY3UXw9bk75e+DfGMRjMZnVf 4bbd/BHGyYx/5XdV0Bvd5ujmh4TTGe56hEACle8Rmt4fOClEfpQUBzMrRRYgwR/67y ro0suFXialrZVAAigw1+nG0XZsnQ7WxgR3nancis= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jeff Moyer , Christoph Hellwig , Jan Kara , Dan Williams , Sasha Levin Subject: [PATCH 4.14 008/126] dax: pass NOWAIT flag to iomap_apply Date: Tue, 10 Mar 2020 13:40:29 +0100 Message-Id: <20200310124204.462914067@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310124203.704193207@linuxfoundation.org> References: <20200310124203.704193207@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Moyer [ Upstream commit 96222d53842dfe54869ec4e1b9d4856daf9105a2 ] fstests generic/471 reports a failure when run with MOUNT_OPTIONS="-o dax". The reason is that the initial pwrite to an empty file with the RWF_NOWAIT flag set does not return -EAGAIN. It turns out that dax_iomap_rw doesn't pass that flag through to iomap_apply. With this patch applied, generic/471 passes for me. Signed-off-by: Jeff Moyer Reviewed-by: Christoph Hellwig Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/x49r1z86e1d.fsf@segfault.boston.devel.redhat.com Signed-off-by: Dan Williams Signed-off-by: Sasha Levin --- fs/dax.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/dax.c b/fs/dax.c index ddb4981ae32eb..34a55754164f4 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -1057,6 +1057,9 @@ dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter, lockdep_assert_held(&inode->i_rwsem); } + if (iocb->ki_flags & IOCB_NOWAIT) + flags |= IOMAP_NOWAIT; + while (iov_iter_count(iter)) { ret = iomap_apply(inode, pos, iov_iter_count(iter), flags, ops, iter, dax_iomap_actor); -- 2.20.1