Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Mar 2020 14:22:16 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     =?ISO-8859-15?Q?Filipe_La=EDns?= <lains@archlinux.org>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Nestor Lopez Casado <nlopezcasad@logitech.com>
Subject: Re: [PATCH] HID: logitech-dj: add support for the static device in
 the Powerplay mat/receiver
In-Reply-To: <5a93677bd6238a9d7928e4fd16a8915faeb5f19e.camel@archlinux.org>
Message-ID: <nycvar.YFH.7.76.2003101301280.19500@cbobk.fhfr.pm>
References: <20200115201811.3271284-1-lains@archlinux.org>  <nycvar.YFH.7.76.2002121449191.3144@cbobk.fhfr.pm> <5a93677bd6238a9d7928e4fd16a8915faeb5f19e.camel@archlinux.org>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 12 Feb 2020, Filipe La?ns wrote:

> > > +	/* custom receiver device (eg. powerplay) */
> > > +	if (hidpp_report->device_index == 7) {
> > > +		workitem.reports_supported |= HIDPP;
> > > +	}
> > > +
> > 
> > I guess we can't do anything else than to trust Logitech that they will 
> > not assign conflicting device_index ID in the future to something that 
> > will not be HID++, right?
> > 
> > Or is this properly documented somewhere?
> > 
> > Thanks,
> 
> 
> CCing Nestor
> 
> Yes, we need to trust Logitech on this. There's isn't anything
> documented regarding this AFAIK.
> 
> Even if Logitech released a device with index 7 that didn't support
> HID++, it wouldn't be that big of an issue. We would just end up with a
> hidraw node which would export a vendor page report descriptor but the
> device wouldn't actually reply to anything.

Given the silence from Nestor, I guess we can just apply this for 5.7; 
pushing to for-5.7/logitech branch.

Thanks,

-- 
Jiri Kosina
SUSE Labs