Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp683092ybh; Tue, 10 Mar 2020 06:24:50 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvJbg8pKmNjYrZdYQ8hwDkF0+Ps/AzKRI/mwEY42jumer7WMEXOoAtcaf4v41IPQbrfCv+M X-Received: by 2002:aca:f591:: with SMTP id t139mr1071801oih.153.1583846690015; Tue, 10 Mar 2020 06:24:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583846690; cv=none; d=google.com; s=arc-20160816; b=GwQdcZbqCf6tDiMoFpJ+6QMlSm2PWMKQFit7RMN7aycZBw7DJYxgrUlghoI/TZCjSb rP3AAYqRcV0/f7jIYgu5bsqd8rsk0m22xyohyIdmhk1bUiPaFliBprza8KCgjjiW70SH +R6n+YzKesQTbrvqqmx/7IUl35EM7VJBgda7E/N3oHKA/7ob242Ipd4oIDWsKBn3zvHO Lhp6++VhvqTb2r9CEf6whCQi9Qk/SDymImGT0JSbpdFwmceake6s1+zip/QkU64T9MZi IvFw08z6A9ZlAzYsQ6LsxoEUMEcI/kcJkJUvUx4D0PNZPZ1qQfKdgCPM3cRz79xY7YTq VQ2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oi4mOLsEKMe6GD3e1BZrgEH9SSbbxFd3s73s3DWUsZw=; b=yeTENuQl1GkcIBiQTUyQ2kJGk7JiFsndNT8SQONEIGvzeBn6SjqEUHqR6N4z8PrzA7 CNYLAi4B5Y7LmsfqtqjbC+wOW8JCcpcYRiPERiFZQF4+Tg+wJcdaIGUw9lrwLdpKTiDm M5OvCb1V3rDFwsKSHuWcrUUGZNZOBhW78J2r/ln0s22wUaBWfXAdAdzP25/IeXbmskBV LJnXVeMRrTl2pVJLfTGdp8Wf8hYDNJE9wmOIKVMQz43uVpox7j5fLtZ6/dPN2LXiEM46 1wsM5RrmDTkgnN3qXqUlKByYgmBspY+UPrvSlxuHHXvZ+AqrE5o4c69Ft+a3i2oDYF1T 0CZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="hj/Cgu9S"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n20si637334otf.63.2020.03.10.06.24.38; Tue, 10 Mar 2020 06:24:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="hj/Cgu9S"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730252AbgCJNWn (ORCPT + 99 others); Tue, 10 Mar 2020 09:22:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:42166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727891AbgCJNBF (ORCPT ); Tue, 10 Mar 2020 09:01:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A26592467D; Tue, 10 Mar 2020 13:01:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845265; bh=ECmkxUpoyr1wOSULnzk6Oo5QIYAGvgFnObdab+nzFdI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hj/Cgu9SDNcbu6zjX7t3JZXn5lR4LICTJq3PWPNLJ/wvxDVPGgxihaF/2ay/P46f3 zoezqHKM8pTEVjH8LnNzoussAlfMCHHQZ5bv0lQSDg6tbdep3UOkmyMBA4xFFSKsF1 pMl1baQk6D67aD0S4n0WLNA9xs4W3YX5IvXO8AnQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Peter Chen Subject: [PATCH 5.5 073/189] usb: cdns3: gadget: link trb should point to next request Date: Tue, 10 Mar 2020 13:38:30 +0100 Message-Id: <20200310123647.002620209@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310123639.608886314@linuxfoundation.org> References: <20200310123639.608886314@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Chen commit 8a7c47fb7285b23ca259c888016513d5566fa9e8 upstream. It has marked the dequeue trb as link trb, but its next segment pointer is still itself, it causes the transfer can't go on. Fix it by set its pointer as the trb address for the next request. Fixes: f616c3bda47e ("usb: cdns3: Fix dequeue implementation") Signed-off-by: Peter Chen Cc: stable Link: https://lore.kernel.org/r/20200219141455.23257-2-peter.chen@nxp.com Signed-off-by: Greg Kroah-Hartman --- drivers/usb/cdns3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/usb/cdns3/gadget.c +++ b/drivers/usb/cdns3/gadget.c @@ -2107,7 +2107,7 @@ found: /* Update ring only if removed request is on pending_req_list list */ if (req_on_hw_ring) { link_trb->buffer = TRB_BUFFER(priv_ep->trb_pool_dma + - (priv_req->start_trb * TRB_SIZE)); + ((priv_req->end_trb + 1) * TRB_SIZE)); link_trb->control = (link_trb->control & TRB_CYCLE) | TRB_TYPE(TRB_LINK) | TRB_CHAIN;