Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp684964ybh; Tue, 10 Mar 2020 06:26:46 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvihPIBbwmz6f6ibLKm+eqYAE+McsQkozNesm6HqxU5bEmWiGC/AlwquqMxPUQk11xDjYqs X-Received: by 2002:aca:cd0e:: with SMTP id d14mr1059929oig.167.1583846806307; Tue, 10 Mar 2020 06:26:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583846806; cv=none; d=google.com; s=arc-20160816; b=U0QuO/qaeiOH06hs5z7wdOu/llpvwQlVcq/VgPhfXh1L6ZKxIPYIKeQxpAzGj7cuf9 8jZlxdPF+qz24Dqy/mTGhNFjRQjrkM2TvSHtqRBUuCs8iaDL8zsig8l0f9MVYKSy9i4w wq2hnHlR8zvwl+H+uXPrxnb8+NBGi/OFO5NeMCHGMpLolTs7nrv210tHvJ603rFcS+nY +opuNOwqUVQQGEFZu1SL1KpCWnoayfYNUdT2305YQcB7+JpIND+Q36+z2m8wgJDdmSLY zjEemXXUS6jGx0n7sMEdDsTlmXvHpmkxKuU0Occm2hAUgyCvDKO7GS0O2u5/3i85ol4Q posQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=SOrqworUWuIRlISw63VSbeMCMYQLLuFkkM8awMRdrg0=; b=Nh/FU1Brq0UYayW8FCZ1fGZTndGQl7tDSj9zT7UqK0kBXZgJIDhCv0fqR92hsJxlJO 49Hyf77LRESHU3U1sh++jBRVHkZpkhDWVAxNILgFPaVgaAhPYXeHIcOmPcqJF4WmeUrX 35KCZrBn27J2fApvVHt/acQw4baCmn6w0iZUO/73nZUYXqfTcnR9C0WxVfXu+D9TFXIT mfnIaApmHLtTiEp4Ym46VEvJjISL27MX1BYobeedOTGwJiVi8SkLZiU4evMcYmvmQoTr +2gyTjOC65ODXyrSW2ZAdgk6XX8lS/ipHWzacHqVi9PxsDzH9WNnRxZDxAeAQB2O7AgN lxmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CV3SRR7B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z23si7491005oti.34.2020.03.10.06.26.33; Tue, 10 Mar 2020 06:26:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CV3SRR7B; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729761AbgCJM5a (ORCPT + 99 others); Tue, 10 Mar 2020 08:57:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:36980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728024AbgCJM50 (ORCPT ); Tue, 10 Mar 2020 08:57:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7D02624694; Tue, 10 Mar 2020 12:57:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583845046; bh=CRPQnmQX8v9UbMLLUzvOypGMEqyXfDIldQelCKqdbLI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CV3SRR7BQeCqVgfjuuz2dreSIny/ZhHY3K/cD8liXE652+V+slY9/Gd80KnQLk0b5 g51160eYfkVWEjpSre0dz5bdzrEOlPBQGDL2L0kWZ6cOZHJRDG+LkYf+ckR/OIR5tg BFCrK522ksFDtu9vSqFuPUQNbZJiGT0OI0JtUwKQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jon Derrick , Christoph Hellwig , Shyjumon N , Keith Busch , Sasha Levin Subject: [PATCH 5.5 043/189] nvme/pci: Add sleep quirk for Samsung and Toshiba drives Date: Tue, 10 Mar 2020 13:38:00 +0100 Message-Id: <20200310123643.822498031@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310123639.608886314@linuxfoundation.org> References: <20200310123639.608886314@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shyjumon N [ Upstream commit 1fae37accfc5872af3905d4ba71dc6ab15829be7 ] The Samsung SSD SM981/PM981 and Toshiba SSD KBG40ZNT256G on the Lenovo C640 platform experience runtime resume issues when the SSDs are kept in sleep/suspend mode for long time. This patch applies the 'Simple Suspend' quirk to these configurations. With this patch, the issue had not been observed in a 1+ day test. Reviewed-by: Jon Derrick Reviewed-by: Christoph Hellwig Signed-off-by: Shyjumon N Signed-off-by: Keith Busch Signed-off-by: Sasha Levin --- drivers/nvme/host/pci.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index bb5e13ad1aff2..ec4165e879163 100644 --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -2747,6 +2747,18 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev) (dmi_match(DMI_BOARD_NAME, "PRIME B350M-A") || dmi_match(DMI_BOARD_NAME, "PRIME Z370-A"))) return NVME_QUIRK_NO_APST; + } else if ((pdev->vendor == 0x144d && (pdev->device == 0xa801 || + pdev->device == 0xa808 || pdev->device == 0xa809)) || + (pdev->vendor == 0x1e0f && pdev->device == 0x0001)) { + /* + * Forcing to use host managed nvme power settings for + * lowest idle power with quick resume latency on + * Samsung and Toshiba SSDs based on suspend behavior + * on Coffee Lake board for LENOVO C640 + */ + if ((dmi_match(DMI_BOARD_VENDOR, "LENOVO")) && + dmi_match(DMI_BOARD_NAME, "LNVNB161216")) + return NVME_QUIRK_SIMPLE_SUSPEND; } return 0; -- 2.20.1