Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp685225ybh; Tue, 10 Mar 2020 06:27:02 -0700 (PDT) X-Google-Smtp-Source: ADFU+vt/ALn1mUP3sqUn/jUQKh4yr3OatAtS3MkCWq1c0ZQR9OSKztWzMhZQxIy3ZmQWTwAoyCYs X-Received: by 2002:a05:6830:1182:: with SMTP id u2mr5256109otq.222.1583846822690; Tue, 10 Mar 2020 06:27:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583846822; cv=none; d=google.com; s=arc-20160816; b=fFxOopl0ZDZ4uSH6pvZS4pxoVKPD7GlU9xukr22e1t/6Pd6fEHXJg00zuGa0zIWTlx 09VQNZEQ3AdPKSNPUzfoXXmkB3pl+OoiPzShJLzUC15dstVZ6cs7C6AoG4HBDCJYw6X7 aAwVyFZOZL7TFxL822d2U3Ets4l9hpmzHJRAeQxzokijJyQpLzWpuZK+oBq6d2IWuO1p ++TsMMoTFbH1Q9hKwnVBM6j0JxdQMbxGmas3c+MtbcX2zggPsz1mcohfQU9b+nXzdGK9 EsulYajS0XMJZE+itRAVfcPN0juX9NQEsgGPflZf0J+tvqz1Va8Kq1S73Z46UbX8aAjG Dylg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=J7xTTrZNFRLy/NqSAuh+IbkM+jN+VdaUssO29Io4Qk8=; b=CFtEqa54aJ2leKNt7V8GnNIzd8bSh+yQR5XG+z5k5GnXXsl5D8fqXzCXAObvv5WnlR 8US24w7ehE5DXiilE3sn4WAPk/elGkjk2OV0joiRxPRNyUOQPV0AN9/ODapLNs3jpwxg oMXMLkMnaWfq3GlRy+TRkVk7jz1VPehDXTcPH6vkxZ36i6njt8Cg+eVPyxRIPatPtu1p 3GpAcgCYCrNI6XR7MtiRT2A+VCaY+L4fi5H/Lyhe+jX8hg6xZgNwHqGi3mMYV2hDc+QW qJqPED6AbX+25OHBV2yJsNVO9k4SRdmr+pPP7e2tfMXDM/WXjf7c7eZr36g6HOuhkDRW VvKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E0FNHdvL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d10si7430793oti.226.2020.03.10.06.26.50; Tue, 10 Mar 2020 06:27:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E0FNHdvL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728776AbgCJNZ4 (ORCPT + 99 others); Tue, 10 Mar 2020 09:25:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:35882 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729673AbgCJM4h (ORCPT ); Tue, 10 Mar 2020 08:56:37 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0C912253D; Tue, 10 Mar 2020 12:56:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583844997; bh=TRhJge8rXSTVwiWtVyAVL2+zDSITLcul7kvtQLFQMYw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=E0FNHdvLXb74EAQRRUPXCwZchwsvZlk7t3L3TNo6s4oGP77ppumhAihb8ql5oTNdZ WGdJoaP31ojuBhDOM19LqRoQO0SWWKv2jRhhSK0UOmRA87qoyHSLazjUHF9zvmytgA eQMOChJS3wYISIL1CaR1/REo9UZWrftPwRNeyWek= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Stephan Gerhold , Maxime Ripard , Sasha Levin Subject: [PATCH 5.5 025/189] drm/modes: Allow DRM_MODE_ROTATE_0 when applying video mode parameters Date: Tue, 10 Mar 2020 13:37:42 +0100 Message-Id: <20200310123642.003666380@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310123639.608886314@linuxfoundation.org> References: <20200310123639.608886314@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephan Gerhold [ Upstream commit 5c320b6ce7510653bce68cecf80cf5b2d67e907f ] At the moment, only DRM_MODE_ROTATE_180 is allowed when we try to apply the rotation from the video mode parameters. It is also useful to allow DRM_MODE_ROTATE_0 in case there is only a reflect option in the video mode parameter (e.g. video=540x960,reflect_x). DRM_MODE_ROTATE_0 means "no rotation" and should therefore not require any special handling, so we can just add it to the if condition. Signed-off-by: Stephan Gerhold Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20200117153429.54700-3-stephan@gerhold.net Signed-off-by: Sasha Levin --- drivers/gpu/drm/drm_client_modeset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c index 6d4a29e99ae26..3035584f6dc72 100644 --- a/drivers/gpu/drm/drm_client_modeset.c +++ b/drivers/gpu/drm/drm_client_modeset.c @@ -951,7 +951,8 @@ bool drm_client_rotation(struct drm_mode_set *modeset, unsigned int *rotation) * depending on the hardware this may require the framebuffer * to be in a specific tiling format. */ - if ((*rotation & DRM_MODE_ROTATE_MASK) != DRM_MODE_ROTATE_180 || + if (((*rotation & DRM_MODE_ROTATE_MASK) != DRM_MODE_ROTATE_0 && + (*rotation & DRM_MODE_ROTATE_MASK) != DRM_MODE_ROTATE_180) || !plane->rotation_property) return false; -- 2.20.1