Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp690916ybh; Tue, 10 Mar 2020 06:32:55 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsMZ8lPoMmW7pRf4Ys8E0OATRRPkvNgY3REPJMMAE1VqsI4pDV65+eM7MgMPyL3YKGb4xbX X-Received: by 2002:a05:6830:22f2:: with SMTP id t18mr17432025otc.165.1583847175715; Tue, 10 Mar 2020 06:32:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583847175; cv=none; d=google.com; s=arc-20160816; b=bYPcAH0Z1/EU7GnskY9B1NO9FRkqCeUFUlNxVCUxWDGEVjlYpi4F2PVvxAQl5X/rM/ fGeSZ+hAkd6ofv+21DhvlEujfumGNnPUAUisNWiADg/0BUiAxfSAX1JnpyyTnWDYnOLZ 5cNdJnzyrWKIt18gLp1zr5whc66nyamO9dzQ2s6X52Vs9k+yHnnKjF2QRAsSuFxLzqsi LcVg39f/zRTe1e3RyPNROFAKOwv2bvk7FUTfB93EAGk1gDABFy/4nAdoernyJSpwDNJu 68Mp/ZvHlCWl0yVrtjIq+NPNS8I41Bi4dD2heBM6FGJE7vTl7CBJ7t1/Tm6N9shigUVv Iwrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i55w1bVxWCBYrNCs6Ap1qrne/WI6lcBozrwzFpA28wU=; b=yMwyaKYVYdrO3JdosC5Dw839c1h3BkokGRUqldQt95MU8iQZOxRVZ87H+J5WIPhBjP 8uiM4coCeuFcyVwC1SZnV0Lyg3L5cbrmoCaNwoCCTelZuSY7PSqapm/hHX5uV7ItI2CP nokWgj63LMVfOZ9NVjHfHsyooM4zL6gL5VXrPpxgjNlLa/ZgiQgKUsbAFy5JjnaNCeGI 0KdPQ+j+DAyI9/sOPWlv68v2VP268MzKeGp3RtIOcaZLz6urzKerrG+M8vM0RNby4ryB bZEzFWJzlvVmP2onEOjX/re7NKKSpCueT+TNhiM+20LjAbyMmrOIY/lK51Pz2Odu/07f vRNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rSe3q9tp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m15si7555437otq.324.2020.03.10.06.32.43; Tue, 10 Mar 2020 06:32:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rSe3q9tp; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729509AbgCJNb7 (ORCPT + 99 others); Tue, 10 Mar 2020 09:31:59 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:43642 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729418AbgCJNb4 (ORCPT ); Tue, 10 Mar 2020 09:31:56 -0400 Received: by mail-wr1-f67.google.com with SMTP id v9so15863129wrf.10 for ; Tue, 10 Mar 2020 06:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i55w1bVxWCBYrNCs6Ap1qrne/WI6lcBozrwzFpA28wU=; b=rSe3q9tpfbCKCB6fqEd/+P3YDIX/0/o9UZ16SeK2CJhEziJLQqOMwxnnB5dto3rZq6 2078mhZ5G2G+iB0a9uv3YFfADnKEp7qkX1G9bZEm5ScJOg1uEp9RNv4Uo0ppQvPbeDJ8 i2o3QGBjZU4VKzVu7xCbGXcPO1FAuJCHAwaQhxxvZqTRkJs1o2CKaDW1VmuM13cs1AoU GMurzUy5LyNzESX6JSjDwsFGPPC+vxSvtCzLAAlEDtDZDC2SDmACb4OyXslHlC4okF+m fDmIqNDplUNjmr5fBbWrzbAuodwcWN3F/EXQayeOmitHsIondSte8Hef8X7er14KvB/+ gTdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i55w1bVxWCBYrNCs6Ap1qrne/WI6lcBozrwzFpA28wU=; b=gZnwwqWcaPwdeNddG35+V2bI/QebQ0ywFO6wFVDiOz2Q3KINkxyYUXuE3uE6sgC65x cGUzLGabJCYm5+LWp0Q7pIFmRQJqN8mLQTjsxxFpiNVRmPAErSSxzmXyrn6kKxJ66mBj xExyCOZPMQ4Hq2HcAaEYu1GjmBgFc3aBPOlSA8J6R0IVgqha4gYZlbCjYXgcqxFBZ4Tz 57Q1mjmLoMDihcPBClbA9mlhSPpVLDYihRogW2zXLxF0Jib8i7mTLJq25fhfr6X7iffp Bu8Kl64Dy9Ks0K355uJqoqtEamfydqjk0cV9eOxnRhRGRig3jm7Zl1gLMbN2cn6y9CwB 6bZg== X-Gm-Message-State: ANhLgQ2nB7A9Y+CQ7sLijyPTm/cAdfhO1AGuSyC55FGAWllNVu7ip4bw NgZg6rsa7TTbh7A40M1th64= X-Received: by 2002:a5d:6a03:: with SMTP id m3mr27915078wru.275.1583847113580; Tue, 10 Mar 2020 06:31:53 -0700 (PDT) Received: from localhost.localdomain ([197.248.222.210]) by smtp.googlemail.com with ESMTPSA id o7sm14047141wrx.60.2020.03.10.06.31.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 06:31:53 -0700 (PDT) From: Wambui Karuga To: airlied@linux.ie, daniel@ffwll.ch, Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: [PATCH v2 10/17] drm/vram-helper: make drm_vram_mm_debugfs_init() return 0 Date: Tue, 10 Mar 2020 16:31:14 +0300 Message-Id: <20200310133121.27913-11-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310133121.27913-1-wambui.karugax@gmail.com> References: <20200310133121.27913-1-wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of drm_vram_mm_debugfs_init(), and have the function return 0 directly. v2: have drm_vram_mm_debugfs_init() return 0 instead of void to avoid introducing build issues and build breakage. References: https://lists.freedesktop.org/archives/dri-devel/2020-February/257183.html Signed-off-by: Wambui Karuga Acked-by: Thomas Zimmermann --- drivers/gpu/drm/drm_gem_vram_helper.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c index 92a11bb42365..c8bcc8609650 100644 --- a/drivers/gpu/drm/drm_gem_vram_helper.c +++ b/drivers/gpu/drm/drm_gem_vram_helper.c @@ -1048,14 +1048,12 @@ static const struct drm_info_list drm_vram_mm_debugfs_list[] = { */ int drm_vram_mm_debugfs_init(struct drm_minor *minor) { - int ret = 0; - #if defined(CONFIG_DEBUG_FS) - ret = drm_debugfs_create_files(drm_vram_mm_debugfs_list, - ARRAY_SIZE(drm_vram_mm_debugfs_list), - minor->debugfs_root, minor); + drm_debugfs_create_files(drm_vram_mm_debugfs_list, + ARRAY_SIZE(drm_vram_mm_debugfs_list), + minor->debugfs_root, minor); #endif - return ret; + return 0; } EXPORT_SYMBOL(drm_vram_mm_debugfs_init); -- 2.25.1