Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp691311ybh; Tue, 10 Mar 2020 06:33:18 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuBpOTMwgzHmcVv1Bs3tsSpGhf41XCpEin6Zk+eKyLJP5sekn8vsXEzMSE+Dmu5k88hj3qE X-Received: by 2002:aca:1015:: with SMTP id 21mr1116967oiq.101.1583847197855; Tue, 10 Mar 2020 06:33:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583847197; cv=none; d=google.com; s=arc-20160816; b=kyBFMlC03AX1DPpbBpK+SSiEpoYo/RQZCQpvE8P0n6Ec5EIgQ3qTEZjInV1CThPzn5 jckTWRD5IZC7d5Ci3og4HBQgO8u/ibrK0E8r4d8PAkNETRFbD5uTwRoHboh2w191kg7T ZpPz1uqFT9OdYU8yeQWnNOfqhbxhuPr4yuovEA5SvUQzMFpJTLuxTrpV1mvHdwS1as60 9sUwKjkGhefTE93rMBfD7VP1usmQuSUYgNF47ECKzACsV1HY9qAxUFvNqAsTldhym/D8 uZFdrcp5DDh3AfLRKG0s5aESiMGQKBBdIyCf5I/RZ7uEW9V3wciwx0WHhnvpUA2HkezJ a3Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5yjkQehLF0f6xll/bhOaQmEiXBo2J9wKC5XShatyRos=; b=dKIO3Gm9REU+Oh/4vEZ2gAh451NzXRLuG/XWSXD65gza0RBkMZEv/lboAOoOSpZACm DUv6YZlrqIlgGU7UD1aD5y4ZEMpGHdNweC3gK+0NtP/fT6rVgske1KwFpeI2bSBV+rle DIi+iR6jT7YiMLE5LrqJAfcReNAKiFBsQfMoSGeZlkCH8V96KaOGrXCN9NL2cSutwOOs AR/H9Ui9T1poyQQKYTxEJYf99UMAKF0nwbV1j/wBPQbgqeB0zsl7Qhoj9NYQCWCx1xo5 sroKf2+q4aGbNweEZtyCKIw/ZWAD44Do6WUhSgHI/XT/DY3nGYQSol2J506YjyTf9lpi JQPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KTPwiJSM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c21si3174112oto.137.2020.03.10.06.33.05; Tue, 10 Mar 2020 06:33:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KTPwiJSM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728495AbgCJNcZ (ORCPT + 99 others); Tue, 10 Mar 2020 09:32:25 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:39946 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728080AbgCJNcF (ORCPT ); Tue, 10 Mar 2020 09:32:05 -0400 Received: by mail-wm1-f67.google.com with SMTP id e26so1352681wme.5 for ; Tue, 10 Mar 2020 06:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5yjkQehLF0f6xll/bhOaQmEiXBo2J9wKC5XShatyRos=; b=KTPwiJSM/qzAYzigcpA0Y2zHDa/6QW3xECg+PL0A4YQZCTKBUehAocmVanrkaYwNWB BVuCETrnkcveGVfYF/e/qnudD5gWQoIsuJnsLBsoxaWZhuLSYZBwjkjREQkiqrtqq9G0 fhCbmmMxnTenEzXygKIVlt+afExuMshk7MK6YWUmt2k8/tjRFVFbSj/G6Qz6UBaAwNEb qX2TsekYXrUzA43wqiTWsuQXzbEcUjl5J0W+xgbvDmalnbtx7B21ot1xCWeyRq9gAGP3 Z1OZLPEt3QWVfKaZzjGl8G+DKAz+KmsmYt3ktwom160s2BWdHITseV6u05dkv+s8XO33 PKDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5yjkQehLF0f6xll/bhOaQmEiXBo2J9wKC5XShatyRos=; b=VGRRONIO+KfellpodonyEueqy4c2g2G0Uanl81v66P6TP2nuAhLOdktCs8BpFOawNZ sioNxIVNdR+9/z/Br/oCvV4kVLicRdQgPlHg2AMtBkIVKqjJ/u4jS5Rmj5P9/mqwe1/o Q05sADCSBcaCtDIpsnl6yXaYkEsY5Nip7d7wj6b+XW6aZ6AGVeyvwOh35yHoyyUk8ADH uWQyUBa2QKsY2smJ5kOZ5Zg1/54kQcJEmPQlG4LTdKq25/CYbNLHKNtZIFHip3iNUz/G x47zn8I+5S0ZhTu7JZ4Kr7pHOtFtUN08FbR0iNWrnKWQxmgJjG6VeszHcaoUCL2B/YL6 amow== X-Gm-Message-State: ANhLgQ2aJgTjuJCU5rbLx8Za9efQ3f0X6v3YF3q6yeVfntvRZTirZplo hb0hba+yGh1PV8sBsgDcM+U= X-Received: by 2002:a1c:ba42:: with SMTP id k63mr2275852wmf.71.1583847123016; Tue, 10 Mar 2020 06:32:03 -0700 (PDT) Received: from localhost.localdomain ([197.248.222.210]) by smtp.googlemail.com with ESMTPSA id o7sm14047141wrx.60.2020.03.10.06.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 06:32:02 -0700 (PDT) From: Wambui Karuga To: airlied@linux.ie, daniel@ffwll.ch, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, intel-gfx@lists.freedesktop.org Subject: [PATCH v2 14/17] drm/i915: have *_debugfs_init() functions return void. Date: Tue, 10 Mar 2020 16:31:18 +0300 Message-Id: <20200310133121.27913-15-wambui.karugax@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200310133121.27913-1-wambui.karugax@gmail.com> References: <20200310133121.27913-1-wambui.karugax@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since commit 987d65d01356 (drm: debugfs: make drm_debugfs_create_files() never fail), drm_debugfs_create_files() never fails and should return void. Therefore, remove its use as the return value of debugfs_init() functions and have the functions return void. v2: convert intel_display_debugfs_register() stub to return void too. Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/display/intel_display_debugfs.c | 8 ++++---- drivers/gpu/drm/i915/display/intel_display_debugfs.h | 4 ++-- drivers/gpu/drm/i915/i915_debugfs.c | 8 ++++---- drivers/gpu/drm/i915/i915_debugfs.h | 4 ++-- 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c index 1e6eb7f2f72d..424f4e52f783 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c @@ -1927,7 +1927,7 @@ static const struct { {"i915_edp_psr_debug", &i915_edp_psr_debug_fops}, }; -int intel_display_debugfs_register(struct drm_i915_private *i915) +void intel_display_debugfs_register(struct drm_i915_private *i915) { struct drm_minor *minor = i915->drm.primary; int i; @@ -1940,9 +1940,9 @@ int intel_display_debugfs_register(struct drm_i915_private *i915) intel_display_debugfs_files[i].fops); } - return drm_debugfs_create_files(intel_display_debugfs_list, - ARRAY_SIZE(intel_display_debugfs_list), - minor->debugfs_root, minor); + drm_debugfs_create_files(intel_display_debugfs_list, + ARRAY_SIZE(intel_display_debugfs_list), + minor->debugfs_root, minor); } static int i915_panel_show(struct seq_file *m, void *data) diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.h b/drivers/gpu/drm/i915/display/intel_display_debugfs.h index a3bea1ce04c2..c922c1745bfe 100644 --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.h +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.h @@ -10,10 +10,10 @@ struct drm_connector; struct drm_i915_private; #ifdef CONFIG_DEBUG_FS -int intel_display_debugfs_register(struct drm_i915_private *i915); +void intel_display_debugfs_register(struct drm_i915_private *i915); int intel_connector_debugfs_add(struct drm_connector *connector); #else -static inline int intel_display_debugfs_register(struct drm_i915_private *i915) { return 0; } +static inline void intel_display_debugfs_register(struct drm_i915_private *i915) {} static inline int intel_connector_debugfs_add(struct drm_connector *connector) { return 0; } #endif diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 8f2525e4ce0f..de313199c714 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915/i915_debugfs.c @@ -2392,7 +2392,7 @@ static const struct i915_debugfs_files { {"i915_guc_log_relay", &i915_guc_log_relay_fops}, }; -int i915_debugfs_register(struct drm_i915_private *dev_priv) +void i915_debugfs_register(struct drm_i915_private *dev_priv) { struct drm_minor *minor = dev_priv->drm.primary; int i; @@ -2409,7 +2409,7 @@ int i915_debugfs_register(struct drm_i915_private *dev_priv) i915_debugfs_files[i].fops); } - return drm_debugfs_create_files(i915_debugfs_list, - I915_DEBUGFS_ENTRIES, - minor->debugfs_root, minor); + drm_debugfs_create_files(i915_debugfs_list, + I915_DEBUGFS_ENTRIES, + minor->debugfs_root, minor); } diff --git a/drivers/gpu/drm/i915/i915_debugfs.h b/drivers/gpu/drm/i915/i915_debugfs.h index 6da39c76ab5e..1de2736f1248 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.h +++ b/drivers/gpu/drm/i915/i915_debugfs.h @@ -12,10 +12,10 @@ struct drm_i915_private; struct seq_file; #ifdef CONFIG_DEBUG_FS -int i915_debugfs_register(struct drm_i915_private *dev_priv); +void i915_debugfs_register(struct drm_i915_private *dev_priv); void i915_debugfs_describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj); #else -static inline int i915_debugfs_register(struct drm_i915_private *dev_priv) { return 0; } +static inline void i915_debugfs_register(struct drm_i915_private *dev_priv) {} static inline void i915_debugfs_describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj) {} #endif -- 2.25.1