Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Mar 2020 14:47:13 +0100
From:   Robert Richter <rrichter@marvell.com>
To:     Hanna Hawa <hhhawa@amazon.com>
CC:     <bp@alien8.de>, <mchehab@kernel.org>, <tony.luck@intel.com>,
        <james.morse@arm.com>, <robh+dt@kernel.org>,
        <frowand.list@gmail.com>, <davem@davemloft.net>,
        <gregkh@linuxfoundation.org>, <Jonathan.Cameron@huawei.com>,
        <arnd@arndb.de>, <linux-kernel@vger.kernel.org>,
        <linux-edac@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <dwmw@amazon.co.uk>, <benh@amazon.com>, <ronenk@amazon.com>,
        <talel@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
        <barakw@amazon.com>
Subject: Re: [PATCH v9 3/3] edac: Add support for Amazon's Annapurna Labs L2
 EDAC
Message-ID: <20200310134713.n4gtrgtjdjymmgm5@rric.localdomain>
References: <20200129195016.956-1-hhhawa@amazon.com>
 <20200129195016.956-4-hhhawa@amazon.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200129195016.956-4-hhhawa@amazon.com>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from rric.localdomain (31.208.96.227) by HE1PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:7:66::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.7 via Frontend Transport; Tue, 10 Mar 2020 13:47:20 +0000
X-Originating-IP: [31.208.96.227]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 81566fc2-4bbc-4ffa-be50-08d7c4f98fa3
X-MS-TrafficTypeDiagnostic: MN2PR18MB2637:
X-Microsoft-Antispam-PRVS: <MN2PR18MB2637E1FF1C4DE324D6C4ADCFD9FF0@MN2PR18MB2637.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:5236;
X-Forefront-PRVS: 033857D0BD
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(366004)(346002)(136003)(39850400004)(396003)(376002)(47630400002)(189003)(199004)(9686003)(4744005)(26005)(186003)(55016002)(66946007)(8936002)(66556008)(16526019)(66476007)(6666004)(8676002)(53546011)(1076003)(81156014)(4326008)(956004)(81166006)(5660300002)(7416002)(6506007)(7696005)(52116002)(478600001)(2906002)(316002)(86362001)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2637;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
Received-SPF: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 3iDPY63OFmKeEvxkYoUabbu/05T+TPyoPb08LDX9pJ+TmJYsHZdIm4MaKygNjRMXSUDuzcErYEcTBQQWmXootgCGYaWmH00biqMTCujwo47Gp0WA5fAHlqqeu8C1D+Ka04KIY3J9ZYk6SEV4xXcsGnLOaqko/F2gWtEcVa9srBk8B5Ii6w0gw9J6Kfv7ljw0ltUHyf+yNd0jM/QJvUu9HRgLLXSTzWR6ZUw5zlJKwxexZNzCB2FPRq2PT61wBGwb+DBI7G86833zaVp99KQvec+6hbYUasqkX46uCmWuLtTkSpyH2WfpFiA2QqH3VhgFjbkDHs1I+1DfWKT4TaiGah+EKFMzxdjD4d/yFiCPKy70/emx/YNO4y2AY4T1NCS+XQsjs4o+eXrtdUORlIE0bCxAhkzNLxmZO350K2Xnbmvfk7ZShQOQ87GQ71s0niGz
X-MS-Exchange-AntiSpam-MessageData: ZDeLOLbfR76Mc9JtJpCvKO5Ao4Vr7gMwPWX9x7ljlsQ5/a62Ff9oIvp0AUsylfFWX+cnMv4OS2QCCRMz9VLSOsxWgNGShhfF2XPyWyxcDI7puOTDrub6xvxV+kf3admSCoMv5q1AjpVHO1m+oA5wEQ==
X-MS-Exchange-CrossTenant-Network-Message-Id: 81566fc2-4bbc-4ffa-be50-08d7c4f98fa3
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2020 13:47:23.4646
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ggssCBrCi+hHedYGRAFzuCAbIIF8XRQF9tfv90kVxC1x4rTU5d3FSIspTJ/Thc+ErvnnHkRTDjUDfCm/+tHg5w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2637
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-03-10_07:2020-03-10,2020-03-10 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 29.01.20 21:50:16, Hanna Hawa wrote:
> Adds support for Amazon's Annapurna Labs L2 EDAC driver to detect and
> report L2 errors.
> 
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
> ---
>  MAINTAINERS               |   5 +
>  drivers/edac/Kconfig      |   8 ++
>  drivers/edac/Makefile     |   1 +
>  drivers/edac/al_l2_edac.c | 270 ++++++++++++++++++++++++++++++++++++++
>  4 files changed, 284 insertions(+)
>  create mode 100644 drivers/edac/al_l2_edac.c

Hanna, most of the review comments by Boris for patch #1 (al_l1_edac)
apply here too. Please address them.

Thanks,

-Robert