Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp809944ybh; Tue, 10 Mar 2020 08:39:45 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtItHH1n5HhUbz3y8HGmiJYuJENq4y3o16iy7P5zgmZ+Q7RyQJns3oz7m5nv/IsC7ToHAJP X-Received: by 2002:a9d:6197:: with SMTP id g23mr17738083otk.239.1583854785763; Tue, 10 Mar 2020 08:39:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583854785; cv=none; d=google.com; s=arc-20160816; b=sMt+4wA1LyhchYdmjsfeyyt3dBP0WpYV5L5AVU8TAG/F5dz2gnCA0/yylwPyZ9NPIz DybxvA5gZ+PhZji2Qn2hPq/7uMIxPJrICKF2HI96wAAg8kCvrfYMrln3ur/i1+zOkiGM xf3CNmLKwiPRPsRkrgoN54nFkSbvDPzc/D0o/doHD8K2f01ttWMudfBvqoo6XPKTtrry PGV7IJidLFAI8t4XSska8rRzW8QIqrDwugU+2FskuxyL85IpI0ngn1/tjn62uBcHtmRV 2EjMqW3d0veEerZDsF7Yt2FruMQjYMwoaTInLpmxiXGwAYNiP2jJwLchzIgTIn4V+MZE TXaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:mime-version:user-agent :message-id:in-reply-to:date:references:cc:to:from; bh=UNNznZ7R0WF+jZJ68D/IOF65Z6edsJWbhzTdbrswAlA=; b=NktK+LKUbR+GxCjygN2X+Di3j4N4R1CK/rrkM6srOy00WgSuRo989H1L6hgITC67/J jGKeyX/lsi31bo7cmwS1btNZqSDFCClNYqRRh9fs8wzvGd0BoNFE+Zff2vIKUpQm6cEx m+KDJBON7TVLQtHAvNzr0Hd8xOFtv+GbwXlsQHq/fX8rPm4VhEH6wVlDq4cGc2EpDGOc Xt+Qy4onaMeoGTg1NV9GDFJYVNbtjyiC00wwYEYEne4I0gW35jibjXqBp0Q9giDBebhB Uvsoa5DCUrc3Iua6XTdndtdZF7iEpf1XUfmxawoxJu6+yn6v9hflCn3D0doA/Gz26qVk NCUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y82si3890688oia.35.2020.03.10.08.39.33; Tue, 10 Mar 2020 08:39:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xmission.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726659AbgCJPiF (ORCPT + 99 others); Tue, 10 Mar 2020 11:38:05 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:44554 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726380AbgCJPiF (ORCPT ); Tue, 10 Mar 2020 11:38:05 -0400 Received: from in01.mta.xmission.com ([166.70.13.51]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jBgxE-0001AS-RF; Tue, 10 Mar 2020 09:38:00 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in01.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jBgxD-0000sr-Jr; Tue, 10 Mar 2020 09:38:00 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Bernd Edlinger Cc: Christian Brauner , Kees Cook , Jann Horn , Jonathan Corbet , Alexander Viro , Andrew Morton , Alexey Dobriyan , Thomas Gleixner , Oleg Nesterov , Frederic Weisbecker , Andrei Vagin , Ingo Molnar , "Peter Zijlstra \(Intel\)" , Yuyang Du , David Hildenbrand , Sebastian Andrzej Siewior , Anshuman Khandual , David Howells , James Morris , Greg Kroah-Hartman , Shakeel Butt , Jason Gunthorpe , Christian Kellner , Andrea Arcangeli , Aleksa Sarai , "Dmitry V. Levin" , "linux-doc\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" , "linux-fsdevel\@vger.kernel.org" , "linux-mm\@kvack.org" , "stable\@vger.kernel.org" , "linux-api\@vger.kernel.org" References: <87r1y8dqqz.fsf@x220.int.ebiederm.org> <87tv32cxmf.fsf_-_@x220.int.ebiederm.org> <87v9ne5y4y.fsf_-_@x220.int.ebiederm.org> <87zhcq4jdj.fsf_-_@x220.int.ebiederm.org> <878sk94eay.fsf@x220.int.ebiederm.org> <87r1y12yc7.fsf@x220.int.ebiederm.org> <87k13t2xpd.fsf@x220.int.ebiederm.org> <87d09l2x5n.fsf@x220.int.ebiederm.org> <871rq12vxu.fsf@x220.int.ebiederm.org> <877dzt1fnf.fsf@x220.int.ebiederm.org> Date: Tue, 10 Mar 2020 10:35:41 -0500 In-Reply-To: (Bernd Edlinger's message of "Tue, 10 Mar 2020 14:43:21 +0100") Message-ID: <875zfcxlwy.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jBgxD-0000sr-Jr;;;mid=<875zfcxlwy.fsf@x220.int.ebiederm.org>;;;hst=in01.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX18NOUXxtLcovq85kyfc0MbvMJLCG3mnAmU= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa07.xmission.com X-Spam-Level: ** X-Spam-Status: No, score=2.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,XMNoVowels,XMSubLong autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4887] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa07 1397; Body=1 Fuz1=1 Fuz2=1] X-Spam-DCC: XMission; sa07 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: **;Bernd Edlinger X-Spam-Relay-Country: X-Spam-Timing: total 698 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 6 (0.8%), b_tie_ro: 3.6 (0.5%), parse: 0.98 (0.1%), extract_message_metadata: 11 (1.5%), get_uri_detail_list: 0.89 (0.1%), tests_pri_-1000: 8 (1.2%), tests_pri_-950: 1.24 (0.2%), tests_pri_-900: 1.05 (0.2%), tests_pri_-90: 32 (4.5%), check_bayes: 30 (4.2%), b_tokenize: 12 (1.7%), b_tok_get_all: 8 (1.1%), b_comp_prob: 3.6 (0.5%), b_tok_touch_all: 3.8 (0.5%), b_finish: 0.66 (0.1%), tests_pri_0: 627 (89.8%), check_dkim_signature: 0.50 (0.1%), check_dkim_adsp: 2.1 (0.3%), poll_dns_idle: 0.30 (0.0%), tests_pri_10: 2.0 (0.3%), tests_pri_500: 6 (0.8%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 0/4] Use new infrastructure to fix deadlocks in execve X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bernd Edlinger writes: > This is a follow up on Eric's patch series to > fix the deadlocks observed with ptracing when execve > in multi-threaded applications. > > This fixes the simple and most important case where > the cred_guard_mutex causes strace to deadlock. > > This also adds a test case (which is only partially > fixed so far, the rest of the fixes will follow > soon). > > Two trivial comment fixes are also included. > > Bernd Edlinger (4): > exec: Fix a deadlock in ptrace > selftests/ptrace: add test cases for dead-locks > mm: docs: Fix a comment in process_vm_rw_core > kernel: doc: remove outdated comment in prepare_kernel_cred > > kernel/cred.c | 2 - > kernel/fork.c | 4 +- > mm/process_vm_access.c | 2 +- > tools/testing/selftests/ptrace/Makefile | 4 +- > tools/testing/selftests/ptrace/vmaccess.c | 86 +++++++++++++++++++++++++++++++ > 5 files changed, 91 insertions(+), 7 deletions(-) > create mode 100644 tools/testing/selftests/ptrace/vmaccess.c Applied. Thank you, Eric