Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Alexandre Chartre <alexandre.chartre@oracle.com>,
        LKML <linux-kernel@vger.kernel.org>
Cc:     x86@kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Brian Gerst <brgerst@gmail.com>,
        Juergen Gross <jgross@suse.com>,
        Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [patch part-II V2 11/13] x86/speculation/mds: Mark mds_user_clear_cpu_buffers() __always_inline
In-Reply-To: <c9847c45-32b0-e5e6-1eb9-5f9e10814276@oracle.com>
References: <20200308222359.370649591@linutronix.de> <20200308222610.040107039@linutronix.de> <c9847c45-32b0-e5e6-1eb9-5f9e10814276@oracle.com>
Date:   Tue, 10 Mar 2020 17:38:01 +0100
Message-ID: <87lfo85fo6.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Alexandre Chartre <alexandre.chartre@oracle.com> writes:
> On 3/8/20 11:24 PM, Thomas Gleixner wrote:
>> -static inline void mds_user_clear_cpu_buffers(void)
>> +static __always_inline void mds_user_clear_cpu_buffers(void)
>>   {
>>   	if (static_branch_likely(&mds_user_clear))
>>   		mds_clear_cpu_buffers();
>> 
>
> Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>
>
> I am just wondering if it would be worth defining a new function attribute to
> identify functions which shouldn't be trace/probe more clearly. For example:
>
> #define no_trace_and_probe __always_inline
>
> static no_trace_and_probe void mds_user_clear_cpu_buffers(void)
> {
>          ...
> }
>
> I am just concerned that overtime we might forgot that a function is defined
> __always_inline just because it shouldn't be traced/probed.

True, for exactly that reason we are reconsidering the whole annotation
business by putting stuff into a separate section so we get tools
support for finding things which escape. See the discussion at:

  https://lore.kernel.org/lkml/87mu8p797b.fsf@nanos.tec.linutronix.de/

Peter and I are working on this right now, so you might end up reviewing
this pile in different form yet another time :(

Thanks,

        tglx