Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH block/for-5.6-fixes] blk-iocost: fix incorrect vtime
 comparison in iocg_is_idle()
To:     Tejun Heo <tj@kernel.org>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20200310170746.GD79873@mtj.duckdns.org>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <e3980b91-7a43-2493-48d0-081ef4158d2e@kernel.dk>
Date:   Tue, 10 Mar 2020 11:37:18 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200310170746.GD79873@mtj.duckdns.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/10/20 11:07 AM, Tejun Heo wrote:
> vtimes may wrap and time_before/after64() should be used to determine
> whether a given vtime is before or after another. iocg_is_idle() was
> incorrectly using plain "<" comparison do determine whether done_vtime
> is before vtime. Here, the only thing we're interested in is whether
> done_vtime matches vtime which indicates that there's nothing in
> flight. Let's test for inequality instead.

Applied, thanks.

-- 
Jens Axboe