Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp920916ybh; Tue, 10 Mar 2020 10:49:14 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvwXPjDHMm7V8l6XFtqSn6yWdmspSWI0yR9vM5A+bLISeZvpPPzgm9BXSsLMBr7EblM0D/M X-Received: by 2002:a9d:69d3:: with SMTP id v19mr17943997oto.320.1583862553874; Tue, 10 Mar 2020 10:49:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583862553; cv=none; d=google.com; s=arc-20160816; b=PYtHSVVpdbYh3RnOuJD23ft6mPUOXuZUFJzsqsObmhoGsZ+5ReAsm77ezpyJqLPLLn KQbUAOKA5EsZgwhYN4Bf4hon1Z1T2kaBWzy8SGbaLg/w8NHtRnYpQ/BPq4fHDuNq2sj+ 0HWsIMehbiTjXv7Y9UD/bR8XVDcfIvYdTvLcGzl+/FbnCK6tUGw49uQ26wK8dDJFbjh4 KWBLl97JMlFB2Os4ct9Xt/d7vcm8HkBoMPxKWDujoK9k8Tw7Vkvn8LI4zXvft/w1ZYpv GzZWNQP33KUlqAa4u0/aNH60+Hqck8UbumeDSR+3emyhM/Mg8dCV9VDBqr5VRDc5RDyv 0ZXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=wfk9LyHiaZ8h3bN11V5g1MOTrXQPEhKu6SXM4fhvRmM=; b=ANqs3Y5nwRtN+EvEhp4KKeMZotB6rkYIMODfEdPufhtb8XK0U9TKVQYpdWyyXHdqfq JUWhoLpjqZhf/D3EB4iG6DUNAaih1XRa7rFCiyay2xJ8aM8LBU9gPbdgiNyaxBgQjjPj wxRcwyCe4wENMyrptJS02A+tuD+BGOPNr0/MlU5CZdpnh3PSRrt2bCUX67dp4ovnLzyJ 1TnMLSwWBR3xTLM7k60h1yF+tfIYDE+pq2gE1NTLwKCJs+eE7LaQ2GVTvZuRGZTHyPkl vzRHlPQF2M7Pl8CxOHt4iDOmWw0tGgIQ9GSKblR3nCMtL2N41icalkIrtbgQgto0CvP0 GiKA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o2si8364616otj.312.2020.03.10.10.49.02; Tue, 10 Mar 2020 10:49:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727461AbgCJRsK (ORCPT + 99 others); Tue, 10 Mar 2020 13:48:10 -0400 Received: from verein.lst.de ([213.95.11.211]:54323 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgCJRsJ (ORCPT ); Tue, 10 Mar 2020 13:48:09 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C5C4168BE1; Tue, 10 Mar 2020 18:48:07 +0100 (CET) Date: Tue, 10 Mar 2020 18:48:07 +0100 From: Christoph Hellwig To: Martijn Coenen Cc: axboe@kernel.dk, hch@lst.de, bvanassche@acm.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH] loop: Only change blocksize when needed. Message-ID: <20200310174807.GB8359@lst.de> References: <20200310131230.106427-1-maco@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310131230.106427-1-maco@android.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 02:12:30PM +0100, Martijn Coenen wrote: > Return early in loop_set_block_size() if the requested block size is > identical to the one we already have; this avoids expensive calls to > freeze the block queue. > > Signed-off-by: Martijn Coenen Looks good, Reviewed-by: Christoph Hellwig