Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <833c188c0c1b9b0b842973952907bdabed774122.camel@surriel.com>
Subject: Re: [PATCH v2] mm: hugetlb: optionally allocate gigantic hugepages
 using cma
From:   Rik van Riel <riel@surriel.com>
To:     Roman Gushchin <guro@fb.com>,
        Mike Kravetz <mike.kravetz@oracle.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>, linux-mm@kvack.org,
        kernel-team@fb.com, linux-kernel@vger.kernel.org
Date:   Tue, 10 Mar 2020 14:22:17 -0400
In-Reply-To: <20200310180558.GD85000@carbon.dhcp.thefacebook.com>
References: <20200310002524.2291595-1-guro@fb.com>
         <5cfa9031-fc15-2bcc-adb9-9779285ef0f7@oracle.com>
         <20200310180558.GD85000@carbon.dhcp.thefacebook.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-D94rFl3rXI1Y1H51/0DC"
User-Agent: Evolution 3.34.3 (3.34.3-1.fc31) 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-D94rFl3rXI1Y1H51/0DC
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2020-03-10 at 11:05 -0700, Roman Gushchin wrote:
> On Tue, Mar 10, 2020 at 10:27:01AM -0700, Mike Kravetz wrote:
> >=20
> > > +	for_each_node_state(nid, N_ONLINE) {
> > > +		unsigned long min_pfn =3D 0, max_pfn =3D 0;
> > > +
> > > +		for_each_mem_pfn_range(i, nid, &start_pfn, &end_pfn,
> > > NULL) {
> > > +			if (!min_pfn)
> > > +				min_pfn =3D start_pfn;
> > > +			max_pfn =3D end_pfn;
> > > +		}
> > > +
> > > +		res =3D cma_declare_contiguous(PFN_PHYS(min_pfn), size,
> > > +					     PFN_PHYS(max_pfn), (1UL <<
> > > 30),
> >=20
> > The alignment is hard coded for x86 gigantic page size.  If this
> > supports
> > more architectures or becomes arch independent we will need to
> > determine
> > what this alignment should be.  Perhaps an arch specific call back
> > to get
> > the alignment for gigantic pages.  That will require a little
> > thought as
> > some arch's support multiple gigantic page sizes.
>=20
> Good point!
> Should we take the biggest possible size as a reference?
> Or the smallest (larger than MAX_ORDER)?

I would say biggest.

You can always allocate multiple smaller gigantic pages
inside the space reserved for one ginormous one.

--=20
All Rights Reversed.

--=-D94rFl3rXI1Y1H51/0DC
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEKR73pCCtJ5Xj3yADznnekoTE3oMFAl5n2tkACgkQznnekoTE
3oN+Owf/Sy6WliqWQnAbEHq56M8WlOqyAKoXZupvl2NMopJY6+FsMKMtOezaF0+s
7jli5AA4QEwoCAcLAWsfwZa5lmnrCs918KI8pnQ+6xFFDh7bg9j+iyxvS87SUseM
jOiAjAdjHIODLlz5Q7lHktmtO68cU8QDcKjbBtobntk+LS7oGA+FwucdRaZ/hLyI
+Rn43qwaod6UxqZCkoNblYlxJhosQfF7bZ99Gkmh+K09lEmgylK0fObIpPIfKI4q
sYBTMe7qUzdsfqAOFmF5xzRZX2q0mwOCdTZhjpZ68MjRpHsvKstrlh4UqfAgd7D+
uDn75ec2IPpFAR/8DTp06Kl6a1+q2g==
=tGVb
-----END PGP SIGNATURE-----

--=-D94rFl3rXI1Y1H51/0DC--