Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp955964ybh; Tue, 10 Mar 2020 11:33:48 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuLhqTLkFIfc9Lz1XgEEJQVt5ioMqufikSTEiodTNB0TSOd3n8kbZ+qaecVZbEuvNgXpUi3 X-Received: by 2002:a9d:3b6:: with SMTP id f51mr18704621otf.255.1583865227765; Tue, 10 Mar 2020 11:33:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583865227; cv=none; d=google.com; s=arc-20160816; b=T3T5aIEGasdVP8b5a96wwKqjs4s6p2UsVRpLnuRKJjAHAR/8oXd59Mg3SSeD8LT8jJ iqFoGwqeRQUD2ZJe52/W7YcaieA08nLqEKZb/VKpM+eWsaSnPVMFBQMF79i5k07nNsbO IO2FaiOc4NHCnebXS661A6NswNkRRpNz0PkVkSyF3dlzq9b/hwLU+T9eDtHaAgAQk1QJ FFjabnNqr70ryTGVeqnmur+DH9Bf5gVXwcmxJ6duNaxA1WIfxXvUzlq0xy2gTWWy0nbb +HkCJJrM8BDhFXlZeyAypduzEawdOymX/0PCjoV/bpxdBiho/73XRQF0BfSeyZX642Bl KJ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=wte8gq+nmGAQn+3qeUlUcJ6GxrSSbCeXxh8IKgXLR5w=; b=bdK5zpputIzEVFdZxvIURMuklJo3RXn+0qCI+D2gH82d4w/bfsnnRwAlRn9CBPpk3u kPzc0rm/q9fWOLqHsZguUiV0joyVnot0QmbpFoMHrpv2CpleCsKxycO/acIhZ3Ixei6O H3sWIgb5ji7i59zVLL1DTuBhSBrCPcCQzSybFiWZQXVlRnshfs+s6VR1dSoDD0HQA/T4 D4IIx1+Oeakx7hK1gimhzFG0KyGYiCK4P0WYsS7Bd1siJbIJ0/JaFfznti45ukfggTHO Isw88mgv08V5o/UPszQqrbRQsO1dtLZ22nqHsB4Hqlib0zwHPMHOswMLNt2/sSwqyDcy RkCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e7si8982373oti.301.2020.03.10.11.33.35; Tue, 10 Mar 2020 11:33:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727556AbgCJSbq (ORCPT + 99 others); Tue, 10 Mar 2020 14:31:46 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:43671 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727268AbgCJSbq (ORCPT ); Tue, 10 Mar 2020 14:31:46 -0400 X-Originating-IP: 91.224.148.103 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 235AE6000A; Tue, 10 Mar 2020 18:31:42 +0000 (UTC) From: Miquel Raynal To: Schrempf Frieder , Boris Brezillon , Jeff Kletsky , liaoweixiong , Miquel Raynal Cc: Richard Weinberger , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 2/3] mtd: spinand: Explicitly use MTD_OPS_RAW to write the bad block marker to OOB Date: Tue, 10 Mar 2020 19:31:42 +0100 Message-Id: <20200310183142.18777-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200218100432.32433-3-frieder.schrempf@kontron.de> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: 958272110eefde17d5d97a3e3e7427c97b48f179 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2020-02-18 at 10:05:25 UTC, Schrempf Frieder wrote: > From: Frieder Schrempf > > When writing the bad block marker to the OOB area the access mode > should be set to MTD_OPS_RAW as it is done for reading the marker. > Currently this only works because req.mode is initialized to > MTD_OPS_PLACE_OOB (0) and spinand_write_to_cache_op() checks for > req.mode != MTD_OPS_AUTO_OOB. > > Fix this by explicitly setting req.mode to MTD_OPS_RAW. > > Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") > Signed-off-by: Frieder Schrempf > Reviewed-by: Boris Brezillon Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel