Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 10 Mar 2020 14:37:31 -0400 (EDT)
From:   Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        paulmck <paulmck@kernel.org>,
        "Joel Fernandes, Google" <joel@joelfernandes.org>,
        Frederic Weisbecker <frederic@kernel.org>
Message-ID: <799177238.23913.1583865451495.JavaMail.zimbra@efficios.com>
In-Reply-To: <87d09k5aet.fsf@nanos.tec.linutronix.de>
References: <87mu8p797b.fsf@nanos.tec.linutronix.de> <1403546357.21810.1583779060302.JavaMail.zimbra@efficios.com> <871rq171ca.fsf@nanos.tec.linutronix.de> <1489283504.23399.1583852595008.JavaMail.zimbra@efficios.com> <87imjc5f6a.fsf@nanos.tec.linutronix.de> <1666704263.23816.1583862003925.JavaMail.zimbra@efficios.com> <87d09k5aet.fsf@nanos.tec.linutronix.de>
Subject: Re: Instrumentation and RCU
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Thread-Topic: Instrumentation and RCU
Thread-Index: 06r5HuF/850lcpCTrawcQQsFC9RdIA==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

----- On Mar 10, 2020, at 2:31 PM, Thomas Gleixner tglx@linutronix.de wrote:

> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> writes:
>> ----- On Mar 10, 2020, at 12:48 PM, Thomas Gleixner tglx@linutronix.de wrote:
>>> How do you "fix" that when you can't reach the tracepoint because you
>>> trip over a breakpoint and then while trying to fixup that stuff you hit
>>> another one?
>>
>> I may still be missing something, but if the fixup code (AFAIU the code
>> performing
>> the out-of-line single-stepping of the original instruction) belongs to a
>> section
>> hidden from instrumentation, it should not be an issue.
> 
> Sure, but what guarantees that on the way there is nothing which might
> call into instrumentable code? Nothing, really.
> 
> That's why I want the explicit sections which can be analyzed by
> tools. Humans (including me) are really bad at it was demonstrated
> several times.

AFAIU, my in_tracer flag proposal complements yours.

The explicit sections thingy is required for early/late entry/exit code,
but does nothing to prevent "explicitly marked" safe-to-instrument kernel
code from triggering infinite recursion.

My flag proposal handles that second issue.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com