Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp258377ybh; Wed, 11 Mar 2020 00:16:25 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtJTWBNk1OobMvNczxPkJFfcVdtJybKENAyy6TSzrWvxjqWmbzQIOAQyp7n9uGfFihsRVhu X-Received: by 2002:aca:1201:: with SMTP id 1mr1003729ois.172.1583910985495; Wed, 11 Mar 2020 00:16:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583910985; cv=none; d=google.com; s=arc-20160816; b=Ltp1HqS5lG5i2xVoUemM97GBV2mufCu8/iqMdpfOZrAkBWgIsxIHZtvnXqPJb/q/Ej Tp9Jzj9zpbHr+CHHgpaQl4qOD7LZ+/Jd1fKcf0JuJEajgM1JfSwUOR0tG3HrxKG02Zt1 mm1NEmSb++2sFPhXQZJzk8QvJ0F1aEvhLZuj5Rz7u3o7if46ObshwmZ7QrHskcot4qG0 8dQnZlT/NjCo5YASkk+HyTjy0YnnidotgOnl53l/UI7Ha9jWRgR8J34qq0EIGOs9Av8v W5cw/YH8B7vplWrjET52BVOm4OAxhatZimoC+uMz9o4CDuR1J4Osiyin2DDbf7EYNeJU Y0lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=a3RcO693m5jlkuMEtK17FqwhM/2Qqacp9D1wCRAgLCs=; b=jvNiZsEqM3xGbgY3xYaUI5rmCFy5RkUKEkfJmfk1cxow0zlGPSJaPPUPjG5yg7m+Yj S6MdMuRHJuhAxEP2dVvg9G4JW5ER8ddKCRlpIoLmP8+OWthWupo+eu7wDJlX3v1G6TDa 5828Za5iGk8cgraBkAdLpPvwiOxn8Fzo4VS+S3BvIm4bOUPcQvcFhx6RAqpRBwZJTHLh P2GTKWpg6WRDWOXgBwrAPTwzXBxc9pw7noIJLJmXaVHnd/5gaE3jN1fzNqeyN0yEphjl YNYNE6T9cZfkIaWjsTyxcWC7BC+9MHR3zveVuVv6b3fX45uZbtXrRWXuGE3ayoVrKL+g IGfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="u/KBCjFu"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z107si648690otb.292.2020.03.11.00.16.12; Wed, 11 Mar 2020 00:16:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="u/KBCjFu"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728347AbgCKHOo (ORCPT + 99 others); Wed, 11 Mar 2020 03:14:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:38500 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgCKHOo (ORCPT ); Wed, 11 Mar 2020 03:14:44 -0400 Received: from dragon (80.251.214.228.16clouds.com [80.251.214.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 03EDA21655; Wed, 11 Mar 2020 07:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1583910882; bh=iXz4q2qWQPcHO89hOxSWWFxi1Lqa7VY6OPTeHFNILqs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u/KBCjFuijTc3Cdpw6UiQcYun3vjlUiGR+ejoZxaBVjoTMYTeIMD4zEYaxm+nH9DR BQUC1RgzZe28TJlhiBJEBHl6BvuE19pF7sTZXBJoVTnc5j1TvQWO42XYaS2iYQsPAo seiVA4zWvOHOWYZoHQhf61zJRzCdeVheTrLwHzi8= Date: Wed, 11 Mar 2020 15:14:36 +0800 From: Shawn Guo To: peng.fan@nxp.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Anson.Huang@nxp.com, leonard.crestez@nxp.com, daniel.baluta@nxp.com Subject: Re: [PATCH] ARM64: dts: imx8m: fix aips dts node Message-ID: <20200311071435.GK29269@dragon> References: <1582602242-28577-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1582602242-28577-1-git-send-email-peng.fan@nxp.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 25, 2020 at 11:44:02AM +0800, peng.fan@nxp.com wrote: > From: Peng Fan > > Per binding doc fsl,aips-bus.yaml, compatible and reg is > required. And for reg, the AIPS configuration space should be > used, not all the AIPS bus space. > > Signed-off-by: Peng Fan > --- > arch/arm64/boot/dts/freescale/imx8mm.dtsi | 12 ++++++++---- > arch/arm64/boot/dts/freescale/imx8mn.dtsi | 16 ++++++++-------- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 12 ++++++------ > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 12 ++++++++---- > 4 files changed, 30 insertions(+), 22 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > index b3d0b29d7007..a4356d2047cd 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi > @@ -227,7 +227,8 @@ > ranges = <0x0 0x0 0x0 0x3e000000>; > > aips1: bus@30000000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; The binding doc says "fsl,aips-bus", not "fsl,aips". Shawn > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30000000 0x30000000 0x400000>; > @@ -496,7 +497,8 @@ > }; > > aips2: bus@30400000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30400000 0x30400000 0x400000>; > @@ -555,7 +557,8 @@ > }; > > aips3: bus@30800000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30800000 0x30800000 0x400000>; > @@ -800,7 +803,8 @@ > }; > > aips4: bus@32c00000 { > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x32df0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > index f2775724377f..4848ce82f083 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi > @@ -203,8 +203,8 @@ > ranges = <0x0 0x0 0x0 0x3e000000>; > > aips1: bus@30000000 { > - compatible = "simple-bus"; > - reg = <0x30000000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -401,8 +401,8 @@ > }; > > aips2: bus@30400000 { > - compatible = "simple-bus"; > - reg = <0x30400000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -461,8 +461,8 @@ > }; > > aips3: bus@30800000 { > - compatible = "simple-bus"; > - reg = <0x30800000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -707,8 +707,8 @@ > }; > > aips4: bus@32c00000 { > - compatible = "simple-bus"; > - reg = <0x32c00000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x32df0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 71b0c8f23693..eb67f56cdfe2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -144,8 +144,8 @@ > ranges = <0x0 0x0 0x0 0x3e000000>; > > aips1: bus@30000000 { > - compatible = "simple-bus"; > - reg = <0x30000000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -309,8 +309,8 @@ > }; > > aips2: bus@30400000 { > - compatible = "simple-bus"; > - reg = <0x30400000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x400000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > @@ -369,8 +369,8 @@ > }; > > aips3: bus@30800000 { > - compatible = "simple-bus"; > - reg = <0x30800000 0x400000>; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x400000>; > #address-cells = <1>; > #size-cells = <1>; > ranges; > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 6a1e83922c71..07070464063d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -290,7 +290,8 @@ > dma-ranges = <0x40000000 0x0 0x40000000 0xc0000000>; > > bus@30000000 { /* AIPS1 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x301f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30000000 0x30000000 0x400000>; > @@ -692,7 +693,8 @@ > }; > > bus@30400000 { /* AIPS2 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x305f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30400000 0x30400000 0x400000>; > @@ -751,7 +753,8 @@ > }; > > bus@30800000 { /* AIPS3 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x309f0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x30800000 0x30800000 0x400000>, > @@ -1023,7 +1026,8 @@ > }; > > bus@32c00000 { /* AIPS4 */ > - compatible = "simple-bus"; > + compatible = "fsl,aips", "simple-bus"; > + reg = <0x32df0000 0x10000>; > #address-cells = <1>; > #size-cells = <1>; > ranges = <0x32c00000 0x32c00000 0x400000>; > -- > 2.16.4 >