Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 11 Mar 2020 09:45:15 +0100
From:   Robert Richter <rrichter@marvell.com>
To:     Marc Zyngier <maz@kernel.org>
CC:     <kvmarm@lists.cs.columbia.edu>, <linux-kernel@vger.kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        James Morse <james.morse@arm.com>,
        Julien Thierry <julien.thierry.kdev@gmail.com>,
        Suzuki K Poulose <suzuki.poulose@arm.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Andrew Murray <Andrew.Murray@arm.com>,
        Zenghui Yu <yuzenghui@huawei.com>
Subject: Re: [PATCH v3 03/32] irqchip/gic-v3: Workaround Cavium TX1 erratum
 when reading GICD_TYPER2
Message-ID: <20200311084515.5vbfudbls3cj2cre@rric.localdomain>
References: <20191224111055.11836-1-maz@kernel.org>
 <20191224111055.11836-4-maz@kernel.org>
 <20200309221137.5pjh4vkc62ft3h2a@rric.localdomain>
 <b1b7db1f0e1c47b7d9e2dfbbe3409b77@kernel.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b1b7db1f0e1c47b7d9e2dfbbe3409b77@kernel.org>
User-Agent: NeoMutt/20170113 (1.7.2)
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from rric.localdomain (31.208.96.227) by HE1PR07CA0020.eurprd07.prod.outlook.com (2603:10a6:7:67::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.8 via Frontend Transport; Wed, 11 Mar 2020 08:45:22 +0000
X-Originating-IP: [31.208.96.227]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a2a17bfe-37d5-40a0-891e-08d7c5988a71
X-MS-TrafficTypeDiagnostic: MN2PR18MB3152:
X-Microsoft-Antispam-PRVS: <MN2PR18MB3152E35704CBFA34993602CDD9FC0@MN2PR18MB3152.namprd18.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-Forefront-PRVS: 0339F89554
X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(39860400002)(376002)(366004)(136003)(199004)(66556008)(81166006)(26005)(8936002)(53546011)(66476007)(316002)(6666004)(8676002)(54906003)(66946007)(1076003)(81156014)(6506007)(7416002)(186003)(4326008)(2906002)(55016002)(956004)(478600001)(52116002)(5660300002)(7696005)(16526019)(9686003)(86362001)(6916009);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB3152;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;
Received-SPF: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: +ZrQ9hMrr9LgPSo+M/A0DCjKsC/o47rBt/XDDfTcle9h/c0cTI5BRO0DOh7E12gUfAxBgvTjZCNhX+rPXmfYk+jTXgxjk7JsFxSqnbMalW/NMjUfFhNJ0aOB36pyx8MqVWshanGspMQI23Dm0yBgx0igA8IPPC4mJhNK+v7k9JI9WdZ54wloE6P/LrD2kzRK1347CC7AKuEoRDT2IX/3OdRl0f+yo4PAMlksN5gR14XEHuCxZ+myoD0U5myB6DbYrXp27D1o8KWcCw4Q5nhpvHlOa+4OuoT9ai6e0bCuh7aOLLkdrUtRcUuWrJaOjvUjb2Re5U3JXhF6ymCY0HN9Fp0xuRk7I6sHf1A3dFPhr3t5d1yT4b+2deaT20EU0VLCkdJ9qR5f6jbu7v3A1aew0Zlmh1VrotRBBeEqT5JpOfnjuTTJl8GYseQYGmQWPZwi
X-MS-Exchange-AntiSpam-MessageData: vwIV0hF508p2eZhZZtXjTNHL5AjyXw2PrVeUmlXr3EgCelZFjbzqwBboAkvmRvKpsD9lM4Cpxuf05qxLZcNc2jD6eFCq+yO2ub1mojbJad4kJFsGI9QuXcqgaaoeUnybHMQFlKCDwWnqQe+LRbqtkA==
X-MS-Exchange-CrossTenant-Network-Message-Id: a2a17bfe-37d5-40a0-891e-08d7c5988a71
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2020 08:45:24.8749
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YrUKzvv9f1Bm7aK7eJam/7g6b6CijeAala1fPhiGDrmHxooxsa/g09tKQ/9tQVVh1xbQHPrFPFX9f8GcqHhO6Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3152
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572
 definitions=2020-03-11_02:2020-03-10,2020-03-11 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Marc,

On 10.03.20 11:41:09, Marc Zyngier wrote:
> On 2020-03-09 22:11, Robert Richter wrote:
> > On 24.12.19 11:10:26, Marc Zyngier wrote:

> > > @@ -1502,6 +1512,12 @@ static const struct gic_quirk gic_quirks[] = {
> > >  		.mask	= 0xffffffff,
> > >  		.init	= gic_enable_quirk_hip06_07,
> > >  	},
> > > +	{
> > > +		.desc	= "GICv3: Cavium TX1 GICD_TYPER2 erratum",
> > 
> > There is no errata number yet.
> 
> Please let me know when/if you obtain one.

GIC-38539: GIC faults when accessing reserved GICD_TYPER2 register

Applies to (covered with iidr mask below):

 ThunderX: CN88xx
 OCTEON TX: CN83xx, CN81xx
 OCTEON TX2: CN93xx, CN96xx, CN98xx, CNF95xx*

Issue: Access to GIC reserved registers results in an exception.
Notes:
1) This applies to other reserved registers too.
2) The errata number is unique over all IP blocks, so a macro
   CAVIUM_ERRATUM_38539 is ok.

> 
> > 
> > > +		.iidr	= 0xa100034c,
> > > +		.mask	= 0xfff00fff,
> > > +		.init	= gic_enable_quirk_tx1,
> > 
> > All TX1 and OcteonTX parts are affected, which is a0-a7 and b0-b7. So
> > the iidr/mask should be:
> > 
> > 		.iidr   = 0xa000034c,
> > 		.mask   = 0xe8f00fff,
> 
> Thanks, that's pretty helpful. I'll update the patch with these values
> and the corresponding description.
> 
> > > +	},
> > >  	{
> > >  	}
> > >  };

Thank you for addressing this.

-Robert