Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 11 Mar 2020 17:06:47 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc:     kernel@pengutronix.de, linux-imx@nxp.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH] drivers: soc: Fix COMPILE_TEST for IMX SCU
Message-ID: <20200311090646.GJ29269@dragon>
References: <20200306113119.56577-1-vincenzo.frascino@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200306113119.56577-1-vincenzo.frascino@arm.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Mar 06, 2020 at 11:31:19AM +0000, Vincenzo Frascino wrote:
> IMX SCU SoCs support COMPILE_TEST that allows to compile the driver on a
> different platform for development purposes.
> These SoCs depend on a firmware interface that is not built on COMPILE_TEST
> mode. This results in triggering the following errors at compile time (on
> arm64):
> 
> aarch64-none-linux-gnu-ld:
> drivers/soc/imx/soc-imx-scu.o: in function `imx_scu_soc_probe':
> soc-imx-scu.c:(.text+0x24): undefined reference to `imx_scu_get_handle'
> aarch64-none-linux-gnu-ld:
> soc-imx-scu.c:(.text+0xac): undefined reference to `imx_scu_call_rpc'
> aarch64-none-linux-gnu-ld:
> soc-imx-scu.c:(.text+0xd8): undefined reference to `imx_scu_call_rpc'
> linux/Makefile:1078: recipe for target 'vmlinux' failed
> make[1]: *** [vmlinux] Error 1
> Makefile:180: recipe for target 'sub-make' failed
> make: *** [sub-make] Error 2
> 
> Enable the relevant compilation units in the Makefile when the config option
> is selected to address the issue.
> 
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>

Thanks for the patch.  But we already queued Peng's version [1].

Shawn

[1] https://www.spinics.net/lists/arm-kernel/msg787548.html