Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp392277ybh; Wed, 11 Mar 2020 03:12:09 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvWS86bG7Vl2S4zYVxpi+so1gWhl2t5Cx9u9xfvsKZTss9PGXFEEVItrLDE7IR97Bp+r+Oy X-Received: by 2002:a9d:6452:: with SMTP id m18mr1636482otl.366.1583921529747; Wed, 11 Mar 2020 03:12:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583921529; cv=none; d=google.com; s=arc-20160816; b=vDyqYDni3A9IhTGHcOw4BeO05kYH2Cg6nBhXLG22XgcRFPLOcNka87htpumE+/2frC Bo9AmE6h3fsjmb0dfgthkqhzp1KRLFjkVM3ZgoxJmdxg3Nl5a7EjLyUY9SEqI5EwjCqq Dk+qYU2tuqQYX9FxDQX3vF4zoemM0DvZRgw4q33dcIvslcC2yCiDm9KJ8gzdH3CUEn1y NMyZNbCs5FhV4rGZMoiqfgDCF5+egtRzwuqufrp+Avqbv5odjckIjxttErvxaq4lDbp5 NJXKhhheyYH+LgcnjNUDajPZx8FQ7GFb6TPHKx4a9wUmcabJZKdmZ0RJ3waiKPXlzI0z ylUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=pxsnWL7fbrVMITF6Zef2MEtX+Yv4rG3hYhxrgf8TS48=; b=X/sYfw6zJpU/pIfSMTH5oMOIa+KK/LQJ4PhmUhyqVDPIc+jjcVZmYybI3yITRwWHD+ 9wgSlqenPeSIXHFLpex8Ac6xrVwzkTz06Bw7NQqUdepYh2W9bL3rsP0+DFfnNhBxD6iN 3D6pNI0F9WSPzWdhWnLv+TTGnqjsoQi8QYoDNtQSmaO7Jf1THbKbRE+C7Mc0AniZP4DV KmS6o9BUZzvgmFul/aZ0PgXKATTxRlAFTrBu8YTzBM386MNaNuXWaxkMIOZzYkdxGljq ZjllB7SORS1w95lEPKEsF7TjPfeq6/Ru90WcTv195uGBwxQXSiuXBpka8uaBwEl3TCdm enAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@pascalroeleven.nl header.s=x header.b=pafocN20; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=pascalroeleven.nl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s21si16628otp.225.2020.03.11.03.11.55; Wed, 11 Mar 2020 03:12:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@pascalroeleven.nl header.s=x header.b=pafocN20; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=pascalroeleven.nl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728912AbgCKKLA (ORCPT + 99 others); Wed, 11 Mar 2020 06:11:00 -0400 Received: from web0081.zxcs.nl ([185.104.29.10]:51582 "EHLO web0081.zxcs.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728554AbgCKKLA (ORCPT ); Wed, 11 Mar 2020 06:11:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=pascalroeleven.nl; s=x; h=Message-ID:References:In-Reply-To:Subject:Cc:To: From:Date:Content-Transfer-Encoding:Content-Type:MIME-Version:Sender:Reply-To :Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pxsnWL7fbrVMITF6Zef2MEtX+Yv4rG3hYhxrgf8TS48=; b=pafocN20pcCkV+R7kR9GLsRPha Yk/qAVwPmim9ObXoNw8XqLrChIaApCXKhX9bN2eNdqhyoFqkAbCMqUbFuMyk1HV0EpaMy9dSKe3M8 EogWqlazXu4uRzuG6U8oM7BIs466eystkiZUkKhLrDPpe8jUZXsDRKsHqNNi0fIPaStUUvwt4Zeue Ne0HHAReFjPenayvrsYlPKhnwsK86dGDuukMKmCJP346CCYlUJNfHugAHurfdPtYqHYbASFMpNH0u N2Xui0Qz/9CevewQufTC4Qi+ORV0cC3qQMMLr0kBO9z2jkHhW6oxWB5BG5ZDLLq2GwQ1UCnjIXFuJ /7PF/2Sw==; Received: from spamrelay.zxcs.nl ([185.104.28.12]:35692 helo=mail-slave01.zxcs.nl) by web0081.zxcs.nl with esmtp (Exim 4.92.3) (envelope-from ) id 1jByK1-004H54-TJ; Wed, 11 Mar 2020 11:10:41 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 11 Mar 2020 11:10:41 +0100 From: Pascal Roeleven To: =?UTF-8?Q?Ond=C5=99ej_Jirman?= Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Maxime Ripard , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com Subject: Re: [linux-sunxi] [PATCH 2/2] ARM: dts: sun4i: Add support for Topwise A721 tablet In-Reply-To: <20200310140202.ntydtg4seosb2aqs@core.my.home> References: <20200310102725.14591-1-dev@pascalroeleven.nl> <20200310102725.14591-3-dev@pascalroeleven.nl> <20200310140202.ntydtg4seosb2aqs@core.my.home> User-Agent: Roundcube Webmail/1.4.2 Message-ID: <761a53d08ecf6fec63054cb1b0b5c4ce@pascalroeleven.nl> X-Sender: dev@pascalroeleven.nl Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-03-10 15:02, OndÅ™ej Jirman wrote: > Hello Pascal, > > On Tue, Mar 10, 2020 at 11:27:24AM +0100, Pascal Roeleven wrote: >> The Topwise A721/LY-F1 tablet is a tablet sold around 2012 under >> different brands. The mainboard mentions A721 clearly, so this tablet >> is best known under this name. >> >> Signed-off-by: Pascal Roeleven >> --- >> arch/arm/boot/dts/Makefile | 3 +- >> arch/arm/boot/dts/sun4i-a10-topwise-a721.dts | 302 >> +++++++++++++++++++ >> 2 files changed, 304 insertions(+), 1 deletion(-) >> create mode 100644 arch/arm/boot/dts/sun4i-a10-topwise-a721.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 78f144e33..6e6141e00 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -1040,7 +1040,8 @@ dtb-$(CONFIG_MACH_SUN4I) += \ >> sun4i-a10-olinuxino-lime.dtb \ >> sun4i-a10-pcduino.dtb \ >> sun4i-a10-pcduino2.dtb \ >> - sun4i-a10-pov-protab2-ips9.dtb >> + sun4i-a10-pov-protab2-ips9.dtb \ >> + sun4i-a10-topwise-a721.dtb >> dtb-$(CONFIG_MACH_SUN5I) += \ >> sun5i-a10s-auxtek-t003.dtb \ >> sun5i-a10s-auxtek-t004.dtb \ >> diff --git a/arch/arm/boot/dts/sun4i-a10-topwise-a721.dts >> b/arch/arm/boot/dts/sun4i-a10-topwise-a721.dts >> new file mode 100644 >> index 000000000..ff43c9c12 >> --- /dev/null >> +++ b/arch/arm/boot/dts/sun4i-a10-topwise-a721.dts >> @@ -0,0 +1,302 @@ >> +/* >> + * Copyright 2020 Pascal Roeleven >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of >> the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the >> Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY >> KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE >> WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ > > You should use SPDX license identifier instead of boilerplate license > text. > >> +/dts-v1/; >> +#include "sun4i-a10.dtsi" >> +#include "sunxi-common-regulators.dtsi" >> + >> +#include >> +#include >> +#include >> +#include >> + >> +/ { >> + model = "Topwise A721"; >> + compatible = "topwise,a721", "allwinner,sun4i-a10"; > > topwise is not in vendor-prefixes.yaml > >> + aliases { >> + serial0 = &uart0; >> + }; >> + >> + backlight: backlight { >> + compatible = "pwm-backlight"; >> + pwms = <&pwm 0 100000 PWM_POLARITY_INVERTED>; >> + power-supply = <®_vbat>; >> + enable-gpios = <&pio 7 7 GPIO_ACTIVE_HIGH>; /* PH7 */ >> + brightness-levels = <0 30 40 50 60 70 80 90 100>; >> + default-brightness-level = <8>; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + panel: panel { >> + compatible = "starry,kr070pe2t"; >> + backlight = <&backlight>; >> + power-supply = <®_lcd_power>; >> + >> + port { >> + panel_input: endpoint { >> + remote-endpoint = <&tcon0_out_panel>; >> + }; >> + }; >> + }; >> + >> + reg_lcd_power: reg-lcd-power { >> + compatible = "regulator-fixed"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&lcd_power_pin>; >> + regulator-name = "reg-lcd-power"; >> + gpio = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* PH8 */ >> + enable-active-high; >> + }; >> + >> + reg_vbat: reg-vbat { >> + compatible = "regulator-fixed"; >> + regulator-name = "vbat"; >> + regulator-min-microvolt = <3700000>; >> + regulator-max-microvolt = <3700000>; >> + }; >> + >> +}; >> + >> +&codec { >> + status = "okay"; >> +}; >> + >> +&cpu0 { >> + cpu-supply = <®_dcdc2>; >> +}; >> + >> +&de { >> + status = "okay"; >> +}; >> + >> +&ehci0 { >> + status = "okay"; >> +}; >> + >> +&ehci1 { >> + status = "okay"; >> +}; >> + >> +&i2c0 { >> + status = "okay"; >> + >> + axp209: pmic@34 { >> + reg = <0x34>; >> + interrupts = <0>; >> + }; >> +}; >> + >> +#include "axp209.dtsi" >> + >> +&ac_power_supply { >> + status = "okay"; >> +}; >> + >> +&battery_power_supply { >> + status = "okay"; >> +}; >> + >> +&i2c1 { >> + status = "okay"; >> + >> + mma7660: accelerometer@4c { >> + compatible = "fsl,mma7660"; >> + reg = <0x4c>; >> + }; >> +}; >> + >> +&i2c2 { >> + status = "okay"; >> + >> + ft5406ee8: touchscreen@38 { >> + compatible = "edt,edt-ft5406"; >> + reg = <0x38>; >> + interrupt-parent = <&pio>; >> + interrupts = <7 21 IRQ_TYPE_EDGE_FALLING>; >> + touchscreen-size-x = <800>; >> + touchscreen-size-y = <480>; >> + vcc-supply = <®_vcc3v3>; >> + }; >> +}; >> + >> +&lradc { >> + vref-supply = <®_ldo2>; >> + status = "okay"; >> + >> + button-vol-down { >> + label = "Volume Down"; >> + linux,code = ; >> + channel = <0>; >> + voltage = <761904>; >> + }; >> + >> + button-vol-up { >> + label = "Volume Up"; >> + linux,code = ; >> + channel = <0>; >> + voltage = <571428>; >> + }; >> +}; >> + >> +&mmc0 { >> + vmmc-supply = <®_vcc3v3>; >> + bus-width = <4>; >> + cd-gpios = <&pio 7 1 GPIO_ACTIVE_LOW>; /* PH01 */ >> + status = "okay"; >> +}; >> + >> +&ohci0 { >> + status = "okay"; >> +}; >> + >> +&ohci1 { >> + status = "okay"; >> +}; >> + >> +&otg_sram { >> + status = "okay"; >> +}; >> + >> +&pio { >> + vcc-pb-supply = <®_vcc3v3>; >> + vcc-pf-supply = <®_vcc3v3>; >> + vcc-ph-supply = <®_vcc3v3>; >> + >> + lcd_power_pin: lcd-power-pin { >> + pins = "PH8"; >> + function = "gpio_out"; >> + bias-pull-up; >> + }; >> + >> + usb0_id_detect_pin: usb0-id-detect-pin { >> + pins = "PH4"; >> + function = "gpio_in"; >> + bias-pull-up; >> + }; >> + >> + usb0_vbus_detect_pin: usb0-vbus-detect-pin { >> + pins = "PH5"; >> + function = "gpio_in"; >> + bias-pull-down; >> + }; > > All 3 nodes above can be replaced with appropriate GPIO_PULL_UP / > GPIO_PULL_DOWN > macros inside the *-gpios property. > >> +}; >> + >> +&pwm { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pwm0_pin>; >> + status = "okay"; >> +}; >> + >> +®_dcdc2 { >> + regulator-always-on; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-name = "vdd-cpu"; >> +}; >> + >> +®_dcdc3 { >> + regulator-always-on; >> + regulator-min-microvolt = <1250000>; >> + regulator-max-microvolt = <1250000>; >> + regulator-name = "vdd-int-dll"; >> +}; >> + >> + > > You have extra space here ^ > >> +®_ldo1 { >> + regulator-name = "vdd-rtc"; >> +}; >> + >> +®_ldo2 { >> + regulator-always-on; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-name = "avcc"; >> +}; >> + >> +®_usb0_vbus { >> + status = "okay"; >> +}; >> + >> +®_usb1_vbus { >> + status = "okay"; >> +}; >> + >> +®_usb2_vbus { >> + status = "okay"; >> +}; >> + >> +&tcon0_out { >> + tcon0_out_panel: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&panel_input>; >> + }; >> +}; >> + >> +&uart0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&uart0_pb_pins>; >> + status = "okay"; >> +}; >> + >> +&usb_otg { >> + dr_mode = "otg"; >> + status = "okay"; >> +}; >> + >> +&usb_power_supply { >> + status = "okay"; >> +}; >> + >> +&usbphy { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&usb0_id_detect_pin>, <&usb0_vbus_detect_pin>; > > No need to use pinctrl to configure regular GPIO functions anymore. > > regards, > Ondrej > >> + usb0_id_det-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */ >> + usb0_vbus_det-gpios = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */ >> + usb0_vbus-supply = <®_usb0_vbus>; >> + usb1_vbus-supply = <®_usb1_vbus>; >> + usb2_vbus-supply = <®_usb2_vbus>; >> + status = "okay"; >> +}; >> -- >> 2.20.1 >> >> -- >> You received this message because you are subscribed to the Google >> Groups "linux-sunxi" group. >> To unsubscribe from this group and stop receiving emails from it, send >> an email to linux-sunxi+unsubscribe@googlegroups.com. >> To view this discussion on the web, visit >> https://groups.google.com/d/msgid/linux-sunxi/20200310102725.14591-3-dev%40pascalroeleven.nl. Hi Ondrej, Thank you for your review. I will be fixing these in v2.