Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp402571ybh; Wed, 11 Mar 2020 03:24:40 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsA8GNtjETMkSnFyWjxGddfnPV91E8Eei+ChrMwq21/g9N9VL0f+etE/mdU25xPrSkvij6O X-Received: by 2002:aca:d645:: with SMTP id n66mr1371477oig.66.1583922280504; Wed, 11 Mar 2020 03:24:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583922280; cv=none; d=google.com; s=arc-20160816; b=HgdO/2WLxK9uygArlG0DU13wHkikY+ixgHDpctiRN3vBM4zXJxhBsqhEmK7mX1Laba kp1hYOUr5oArQfF4fkkrOUQWDWuTH4VGNNVvgr1HXNdjyYBDe8vLT0k2TI3qQfeEHi6l zk6bywMLzamlte7aYl6JKG6xg+JJ/+Lp36lgihsRV3/bSuqncotXLeDN2U2GBUJMeliG Fd+X1I0d7sChQLc4Hk3QyBFUYGx+sRWsKZTr6v7S2uDDiywInC12Ph7BsC6v/d0d9sI0 unXHO+V4PF5YBCsj5PuwCXyU1BQ4UhLTRWzYUnOUIZNf499OcO3i8pwHak7JA8fNhPqF ab+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=0w5021LDG4/rRvygIbHG63Z95gP0VM/SUWm4WPjVwCE=; b=H6JCmWoOOpg0zUxB6ALL1R6Q1ZJuNOdhbECwcvG4Pi7kAKO671hzNnCIDQqUL08Vll OqYka4uZ2ut5ELQScIGoQ7kVcfWsW1gCvnZcYjGysZIOoi+22EIFM/LJzavPlL005P/S tF+VJymhCqAcLxmN3NK7etdEx1Wabhojd4nbhU8KmKeyrrayLEgJtl5H9u1NEsdOeL5p Ti9Nj795dbfRmKIGhWT6BTB3qXs9kFM093GnGNyMz95r4lO/D9iWWnO7SoK3DQz1tIre BkufWV5qppoIllk+9nT79yHchwT2mbLkyKgJDYN9qqwciPE7FgOVl0KvKJJRRTgzCU3A 7wlA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 94si844031otb.114.2020.03.11.03.24.27; Wed, 11 Mar 2020 03:24:40 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728988AbgCKKWc (ORCPT + 99 others); Wed, 11 Mar 2020 06:22:32 -0400 Received: from mga07.intel.com ([134.134.136.100]:56992 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725976AbgCKKWc (ORCPT ); Wed, 11 Mar 2020 06:22:32 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2020 03:22:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,540,1574150400"; d="scan'208";a="231648107" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga007.jf.intel.com with ESMTP; 11 Mar 2020 03:22:26 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jByVQ-008i2l-Ab; Wed, 11 Mar 2020 12:22:28 +0200 Date: Wed, 11 Mar 2020 12:22:28 +0200 From: Andy Shevchenko To: Tobias Schramm Cc: Sebastian Reichel , Rob Herring , Mark Rutland , Maxime Ripard , Sam Ravnborg , Heiko Stuebner , Stephan Gerhold , Mark Brown , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/3] power: supply: add CellWise cw2015 fuel gauge driver Message-ID: <20200311102228.GF1922688@smile.fi.intel.com> References: <20200311093043.3636807-1-t.schramm@manjaro.org> <20200311093043.3636807-4-t.schramm@manjaro.org> <20200311101830.GE1922688@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311101830.GE1922688@smile.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 12:18:30PM +0200, Andy Shevchenko wrote: > On Wed, Mar 11, 2020 at 10:30:43AM +0100, Tobias Schramm wrote: ... > > + ret = device_property_read_u32_array(dev, > > + "cellwise,monitor-interval-ms", > > It's fine to have it on one line. > > > + &value, 1); Actually this is simple ret = device_property_read_u32(dev, "cellwise,monitor-interval-ms", &value); (You can use one or two lines on your choice) -- With Best Regards, Andy Shevchenko