Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp503542ybh; Wed, 11 Mar 2020 05:24:49 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsfi4jKSYTnyBTi1PWMIaY9Vwkb241w5REdKwUKQZA30QM858dQ4R60xvhplUHq84aJDY71 X-Received: by 2002:a9d:7653:: with SMTP id o19mr2072870otl.118.1583929489875; Wed, 11 Mar 2020 05:24:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583929489; cv=none; d=google.com; s=arc-20160816; b=T4EO67cAGZe8wdy9XM7uDAM40j+JrUu12c9vt3YQYtVYWJE3fUVWeZ7ld0j/MM/2xU FBu/jm1aERqIRWiDF6IrkCxx8IcqynuMXOw+pkCYYeR4m6sZGY7EFbheGJn3L2fxa8OJ 6aSp60AEO2n6cYeVyGlrXHg4L3q05BYnmFWpzlqlp5BrhnPQrJvm93jKAaPNlDlMet3h 0PbQEmjdXXtaSqq5hgyL9NroOXF7wIodKPammd3Jwx8Kg6aP6znhCVNEgEka0XepDwB3 huMMi3w/HQVGihrBoaMgJOo+XHdIW1OaiKvQWvff0bX42KwOkGQm8nXdi6gBSa+umNYS lpLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=vloOX72//WFqApw3VIxT8iVXlKKbFeoZETeP41SPnaw=; b=WqRTJ6aW2m8i+7lTcBOfACizJZQymCAFUMgqTSwZiE1T/+OYsqwaI13TZK1X4lAtX8 5cLc68WdGjZ6pIN+N1Gk/2y+EvD8U9mWUaPkzvXsicc2bXE+9a5fzLaB+QotwYwHsrSq AFqmxHHdR7Z/xqaFS6Rz9wpjctFwo5HPMYLnIdqtnqFZW8ZDi/mVcFkJqeJYelqxPiNc cvRs1lNvuTuHVZlVMfVXZE71GQuMlZrLrUEXEP8nU/UCix/jD7j56wffXWWxePLCTk1X G4yMKYY0dSwWC+IzOg6R7uTn5nIiWm68+4m1YTBVGYyBGumCRKp7fzDYuZ4EVYLC+6yQ g/Aw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f6si1100572otq.50.2020.03.11.05.24.37; Wed, 11 Mar 2020 05:24:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729237AbgCKMYW (ORCPT + 99 others); Wed, 11 Mar 2020 08:24:22 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:53866 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729095AbgCKMYW (ORCPT ); Wed, 11 Mar 2020 08:24:22 -0400 Received: from ip5f5bf7ec.dynamic.kabel-deutschland.de ([95.91.247.236] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jC0PJ-0001lN-7Q; Wed, 11 Mar 2020 12:24:17 +0000 Date: Wed, 11 Mar 2020 13:24:16 +0100 From: Christian Brauner To: Walter Wu Cc: Andrew Morton , Christian Brauner , Oleg Nesterov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, wsd_upstream Subject: Re: [PATCH] pid: fix uninitialized var warnings Message-ID: <20200311122416.p4bz5twufd3kdzqs@wittgenstein> References: <20200311122049.11589-1-walter-zh.wu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200311122049.11589-1-walter-zh.wu@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 08:20:49PM +0800, Walter Wu wrote: > Compiling with gcc-9.2.1 points out below warnings. Fix it. > > kernel/pid.c: In function 'alloc_pid': > kernel/pid.c:180:10: warning: 'retval' may be used uninitialized > in this function [-Wmaybe-uninitialized] > > Cc: Andrew Morton > Cc: Christian Brauner > Cc: Oleg Nesterov > Signed-off-by: Walter Wu Thanks. A correct fix for this is already in my tree: https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/commit/?h=fixes&id=10dab84caf400f2f5f8b010ebb0c7c4272ec5093 (Background is https://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git/commit/?h=fixes&id=b26ebfe12f34f372cf041c6f801fa49c3fb382c5 ) Christian