Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp530688ybh; Wed, 11 Mar 2020 05:59:47 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvBwAamaBsTvj4Hh//w1rgoiiChZ2fU0KguTeXGzAQfrpDNTyaJAp+G+3pEmy/qbEc3vMHD X-Received: by 2002:aca:d985:: with SMTP id q127mr1775436oig.132.1583931587427; Wed, 11 Mar 2020 05:59:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583931587; cv=none; d=google.com; s=arc-20160816; b=CRXB9UVtK3UtZMcPWTG0qickco5nZw91eenK2HL+528s02ijpFdN8/cJ/lSkyqntNZ SZ9TQXY3MyB/97fo5gLpT2QfJVlIKjmh7nFSxeOd7VH8sSbe2/JXEiSmSRSVgz+Lukd9 FD4Z/P5sTzgrwxOMBPHMUIcofjwYaXKKsCEUEdBgHSIClbMismnJKOZtQbR//jGU4qNk 0/xRgGlBs5IX83tiqsAcBVxVAmhgbRKAM2cxUpoULfPdvP1NmyTS+zYTvIu1h8p97czO RFi1okuNYvdPuxSgWVakVkKDBQJ8Q1DhZVJzHLv32G9mhCBeaPqo2B5TunOSAispPviR LAzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=pXMGtTgQX/vG6YdfwMEutnSxHcYYkuMTZjUufEEkwrs=; b=oobF7Qdv0M87hEP8ZWnm/8He9cAvkEI51fRlXQ24pg0kGfiE5IqmzXaOB/wrctA0sv RoAZS2krEsURVdgEMbH+R7cUWbuMsf0AUfnl3AIkpLtmDgChCQ6DdnJ8prDbztwsNnSG hzGwnGnVQZz+v1Mt+/aFJcCL4+nWczy2p0+sBi2pCZg5k+fR1aQ23RCyyzabVJBl7lzR XPdyYTDR68g8fvTg7zgQBfNoCTDYWBIZKkCorY499VSq71CYCmG9c04IGW6w1pUjdh63 NCmW5pArWag26F6DEVOPFof2sUZqPkGRv3Y1jKWJgbVZx0Tm9hU9TlXr8BqiQQhtQjNb y7ww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0RdqNJ64; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v203si1074627oif.224.2020.03.11.05.59.36; Wed, 11 Mar 2020 05:59:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=0RdqNJ64; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729467AbgCKM6n (ORCPT + 99 others); Wed, 11 Mar 2020 08:58:43 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:39867 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729444AbgCKM6n (ORCPT ); Wed, 11 Mar 2020 08:58:43 -0400 Received: by mail-io1-f66.google.com with SMTP id c19so714271ioo.6 for ; Wed, 11 Mar 2020 05:58:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pXMGtTgQX/vG6YdfwMEutnSxHcYYkuMTZjUufEEkwrs=; b=0RdqNJ64RPB/YwilvK1FgfDcZgni+Z2YUWUBcLwScASQbGBbB9Dz+LE4Mm35IFt6vr 4cSxKXzulAxx/FMhBjxo7H6LFUFR8GPqsvxXNjSRUPuzvFkJ4jv1PyVkcJG+rzbCC2Np QluikAk9mzDbEMQsnqi+vhGhm69SUbxzK8wbFD8zbHl+VIITIdrwzXk7cwoU57h6DYTK xP/B6p8lJjmkYSUT2EEde9KDBifsOxQlJzU6xNbSL1nZM0pl98Obd5V+EG9SnWmey6tz SPlj8XfxaXHr4JqefQegQiSZa1hJYMurvTPgBuMJ9xU7xwGx1tFUNwEPiNDvzHAuPBK6 0h/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pXMGtTgQX/vG6YdfwMEutnSxHcYYkuMTZjUufEEkwrs=; b=H6keAo2f46dyyr+pin31gNvScsgFiuTRQmFKvHsQUYa0xVLS+Mdh7Kl9kh8EWDCuZA 2dGk9mF61En3uMzpR6Z15y4/KtgkJk2iFou2uRTd8vvnU4ZaWwm9NXNJTQHjiYkXGwaD npOS0hrLQ0aM8d11Bw0aBK31XpZL9My7J4LE9e1JViTQ1KLYKvZ1l8Zqc07Jp7rnKs23 kV8UNe2Zy+DWE6z7tMBzkcgspNu/i5/0KZz6LdW2gMZod+aLzbxLqzQatWVRpklYwbQ/ LRcOYJ1Bk6p82KaN9mJlMLOjOZV9UKgin9SAp+2p8M7U+ZpGkuLYwtbs+KeCLhaUz0nh +4CQ== X-Gm-Message-State: ANhLgQ1Yhhj2uHYfxmmpafCqteO0IyoC833iby5giJTbZRj7GKkeKCrq 21plxMs11/IagKrf4tx+QxCttA== X-Received: by 2002:a02:6658:: with SMTP id l24mr1450719jaf.33.1583931522194; Wed, 11 Mar 2020 05:58:42 -0700 (PDT) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id p79sm17821112ill.66.2020.03.11.05.58.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2020 05:58:41 -0700 (PDT) Subject: Re: [PATCH v3] block: refactor duplicated macros To: Matteo Croce , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, xen-devel@lists.xenproject.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org Cc: "James E.J. Bottomley" , Ulf Hansson , Anna Schumaker , Dan Williams , Song Liu , Guoqing Jiang References: <20200311002254.121365-1-mcroce@redhat.com> From: Jens Axboe Message-ID: <7e03d359-f199-29d8-a75f-20c4b7ff3031@kernel.dk> Date: Wed, 11 Mar 2020 06:58:39 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200311002254.121365-1-mcroce@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/10/20 6:22 PM, Matteo Croce wrote: > The macros PAGE_SECTORS, PAGE_SECTORS_SHIFT and SECTOR_MASK are defined > several times in different flavours across the whole tree. > Define them just once in a common header. > > While at it, replace replace "PAGE_SHIFT - 9" with "PAGE_SECTORS_SHIFT" too > and rename SECTOR_MASK to PAGE_SECTORS_MASK. Applied, thanks. -- Jens Axboe