Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp637408ybh; Wed, 11 Mar 2020 07:55:47 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsQA+of3jKVdk0ACFpBURGP9fn47ax8jAxoTVkThiJTbOB5Rm2DrDIFQORW8Vz0ZU6RVRuL X-Received: by 2002:a05:6808:301:: with SMTP id i1mr2268934oie.19.1583938546937; Wed, 11 Mar 2020 07:55:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583938546; cv=none; d=google.com; s=arc-20160816; b=ffPCHcIfN64rMpz/vJ17v+V2ngh2yeecpWs7U8EvWqtFLWsKAAI0iFJ4LB/ZIWPhgk 2tAAQOZeNIossYFKeHddLSa2WyNgCEzJhgUVTY72rRTbeoAgE+DqOP77F3Cwj3oI405n eOphPPYcOY00E0tmtqq0TBOxLY0dX+gI9e9Swl0XtNECWKFr4CmdhjAAZCgARAJVPcra yORBnwMr9ZFeB2RRZyQPRaoOO1CExi5WxwAw2uEwILdJ5H6lDNDgQf0MwPQ/4+rMdZqF Rsw8bD6gYKPBf/WBjzGi8sDbaCxsdbeoFaak1f1PoSG7IQ2xuGOCey0f+dbJmuEp8iQI kVoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:date:from:dkim-signature; bh=T6dhYyYvJS/8Bl4FjnByulc+SHG/kFSfXU5KSrYTgvo=; b=Kgl0yzOwBBzw+x/vcdHRNZYCkbOxYaA4+m0GtCOITWK0uJ1zrfl1ldqDSaNf4VgxE2 RU9t1BMfyOxSoVGHqZi1jDZvBqx6QyZfJU7PRKX/sYEvDAiR8l9iaHspEoSSi9MXWvXk yACHyHa2JohZpLD70YmRF6nB6ex9giW2BpPpm+i/L8gQ2ZPFuilIaLC8KG0uVJf+4AzF oSYieq+a2EcLtWIKxTnMRQF1B+E0SJCSwoE5Nt+pQ6obYt052st9+UCtptQ/nppZJQYf cyWAiHZY4b2vkaS9dOLA3CsqNG6Ca4NInHTkeNds+KIhBfki9QOUswGOfB8/dhb0MvYj l2cA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YpR821mE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a205si1197385oif.159.2020.03.11.07.55.34; Wed, 11 Mar 2020 07:55:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YpR821mE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729916AbgCKOzG (ORCPT + 99 others); Wed, 11 Mar 2020 10:55:06 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:45367 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729460AbgCKOzF (ORCPT ); Wed, 11 Mar 2020 10:55:05 -0400 Received: by mail-wr1-f67.google.com with SMTP id m9so2986944wro.12; Wed, 11 Mar 2020 07:55:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=T6dhYyYvJS/8Bl4FjnByulc+SHG/kFSfXU5KSrYTgvo=; b=YpR821mEYGSQYCAJdxDmyyX1QVwPDu7Rb+v0SpjUUf77rpGL4EX+ni4S+CA2f5Ddd4 Tn6GVumWKMkc+KSE4/YRS9Bh9EXH07aq1OGbWacOITIjyrgjPKWp5s8QtRFCtElId6ap loh9EfaNtUHKS0cARkPlOA5W3ZvPDVQe4YKYApAG4RFW2sO+D4lojIESO+ye4U8YfB0U OA7UmdyO96F/KOBzabiUxreqyVAmzi4lLfGFxNyETOZu5z/8kdcwLFq4eTsGGz3FN+Qt Zq9+pswIm00N4KRxKmDlZZouEd/pvKvXEVr3JS3V9AZ8rQJlOaDRPFtcDijkVtvYv9mf QLUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=T6dhYyYvJS/8Bl4FjnByulc+SHG/kFSfXU5KSrYTgvo=; b=NRgBx/07bnOHz1vHwnZ+kpO/r8pxWqonrmp0/7Zeto4BTzspdNp8ak/Qi8Bp7TcY2g MIg18Kvpn5TiwrTahqCXFVta0L6LqRW3nIBkJA0zu5X7Du1a5YWxdBl0Wb29wCXbOhik lz0/W4erX0UXGZI5YIU1d9JbBCjCaEX/kWAK3XoTYBQzxxq1n2kBzivvFdRt2eaX+tO5 Sc3kJNOgRlYtBIx8gML8EqzVuts5jFcM/qWJeFR1wuVFcEAFy+piNLa1Lvi26m1gO/gf 3hkMdG2SQxKDBaJvoAzyMxTskxbK15yODxoX/HReFyHQ+2u30VOYgaY+5ykwaH1laeiX AVfA== X-Gm-Message-State: ANhLgQ0otppPNH6iaySJc1mwqZLFwurqxlKIRKgMvpxflAMqzwBMPQ8F kDqZ6FauZ3+L9iyGDCCiqF4= X-Received: by 2002:adf:a506:: with SMTP id i6mr4636282wrb.146.1583938503671; Wed, 11 Mar 2020 07:55:03 -0700 (PDT) Received: from wambui.local ([197.237.61.225]) by smtp.googlemail.com with ESMTPSA id i7sm56001662wro.87.2020.03.11.07.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Mar 2020 07:55:02 -0700 (PDT) From: Wambui Karuga X-Google-Original-From: Wambui Karuga Date: Wed, 11 Mar 2020 17:54:46 +0300 (EAT) To: Thierry Reding cc: Wambui Karuga , daniel@ffwll.ch, airlied@linux.ie, Jonathan Hunter , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH 10/21] drm/tegra: remove checks for debugfs functions return value In-Reply-To: <20200311143753.GC494173@ulmo> Message-ID: References: <20200227120232.19413-1-wambui.karugax@gmail.com> <20200227120232.19413-11-wambui.karugax@gmail.com> <20200311143753.GC494173@ulmo> User-Agent: Alpine 2.21.99999 (LNX 375 2019-10-29) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Thierry, On Wed, 11 Mar 2020, Thierry Reding wrote: > On Thu, Feb 27, 2020 at 03:02:21PM +0300, Wambui Karuga wrote: >> Since 987d65d01356 (drm: debugfs: make >> drm_debugfs_create_files() never fail) there is no need to check the >> return value of drm_debugfs_create_files(). Therefore, remove the >> return checks and error handling of the drm_debugfs_create_files() >> function from various debugfs init functions in drm/tegra and have >> them return 0 directly. >> >> This change also includes removing the use of drm_debugfs_create_files >> as a return value in tegra_debugfs_init() and have the function declared >> as void. >> >> Signed-off-by: Wambui Karuga >> --- >> drivers/gpu/drm/tegra/dc.c | 11 +---------- >> drivers/gpu/drm/tegra/drm.c | 8 ++++---- >> drivers/gpu/drm/tegra/dsi.c | 11 +---------- >> drivers/gpu/drm/tegra/hdmi.c | 11 +---------- >> drivers/gpu/drm/tegra/sor.c | 11 +---------- >> 5 files changed, 8 insertions(+), 44 deletions(-) > > Applied, thanks. > There's a newer version[1] of this patch series as this specific patch depends on other work in drm. Thanks, wambui karuga. [1] https://lists.freedesktop.org/archives/dri-devel/2020-March/258793.html > Thierry >