Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp684111ybh; Wed, 11 Mar 2020 08:46:31 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv2/+cllWDAKwn98M0lRnlxxnFESRavfM8UA5oqfmeBogKTgeMJnrX22Z8wHZ4k7bBFocrh X-Received: by 2002:aca:cf48:: with SMTP id f69mr2272413oig.122.1583941591477; Wed, 11 Mar 2020 08:46:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583941591; cv=none; d=google.com; s=arc-20160816; b=BQzyBMxDjGRJ/aK2e0UCozaIdhxk0BfGR/yOmnXlOpA8Iy66SxAnCROkWp7xWhIAYI MYTuj4f0mFHSWody9LyB8qdWK42fOv9Oz99B7ohT0hr9FX+hPXrGMo8ippOSNww3SaEd VOUvWi2KnNv8hrB0XTD2oE3cz7nbZ5IJQsYvsVUnpPftjcAi6TA1Hn9NdsivMr4EzDXk NFKelFlQf/OrkcD8FMzK8/GuLy20zOqQrmBaZM6oM6b/5jiJZZzcG6bHHUd246TGaJee eJWhwo6NaFYubHf5yFt/ayj8HjMHwRJP3o8ovmTcMYnhdYNWHNjgiHREHOTxSjNuXIMx 7eLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:mime-version:message-id :date:subject:cc:to:from; bh=3TyCKOUEa+ZZzPxPPgj5u5wAYNCe+MYCECoIl/e8ZLs=; b=EjGvKihpKlMpBted7BPwfgOLoc+YsCFFP8FfXhoB6/fwVjtVbGcgLB1PQzZ4vubw1G vTLegrSmz8dMvQV2qIvSGlvN28R3MoIR08eFaW1hP6cyl/XLzqNhr4X2YntIyVchHLCE nG98BIViFmjx2PDwlv6N80UKvsVwwByP0skVfJxZCaEfW6VOpxU9WUIlH/MlmTnsgv6h 0UUtKQRtK7U254nDnJCeMDrERNnMticoLNdykGU0+9Hker1/ZV/cJrCN+qcMgEHQiw94 zEB5zUTTbf80irsQFvm1fE89WHKeJLXLEVYZ0OQeFIWmw2/wpKLsv5rQwrlZs9wSP8lt yeoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=XwZt0epa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v26si1264075otq.165.2020.03.11.08.46.17; Wed, 11 Mar 2020 08:46:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=XwZt0epa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730096AbgCKPoq (ORCPT + 99 others); Wed, 11 Mar 2020 11:44:46 -0400 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:15042 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730084AbgCKPoq (ORCPT ); Wed, 11 Mar 2020 11:44:46 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 11 Mar 2020 08:43:14 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 11 Mar 2020 08:44:45 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 11 Mar 2020 08:44:45 -0700 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 11 Mar 2020 15:44:44 +0000 Received: from hqnvemgw03.nvidia.com (10.124.88.68) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 11 Mar 2020 15:44:44 +0000 Received: from skomatineni-linux.nvidia.com (Not Verified[10.2.175.232]) by hqnvemgw03.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Wed, 11 Mar 2020 08:44:44 -0700 From: Sowjanya Komatineni To: , , , , , , , , , CC: , , , Subject: [PATCH v2 1/2] sdhci: tegra: Implement Tegra specific set_timeout callback Date: Wed, 11 Mar 2020 08:47:54 -0700 Message-ID: <1583941675-9884-1-git-send-email-skomatineni@nvidia.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1583941394; bh=3TyCKOUEa+ZZzPxPPgj5u5wAYNCe+MYCECoIl/e8ZLs=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: MIME-Version:Content-Type; b=XwZt0epaa0LqHQLVK6GUCGw5hNKoBEHv0flyVu7com3kh1JzvFkV+nrYbUdrkwD6G n453xOBDNzhdRroNvYIvyxAQWRU71XQ25QNY3O5TUp62kXCfLiV3jRJxfije75fZ47 tsw9cDmluLMcMzKKVTp7ZNdWPo5Dv2TFDkPBbRqBtOAQe8vwMHxozyhz5Trfc8Wd4k DxK66eKgKeq3GKZZIMpB8uihZwexORsDT4hEwX5dZQdT/xhL+EG6Mh8VEoyX4LJ6RB nPyJOlKnv+bC2IFs8y2lH9h6//siq7eNSfaO2bTTfNShL7wLOH38fL5VDsDcZQ2Qq7 ldXB2348ZT3gQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tegra host supports HW busy detection and timeouts based on the count programmed in SDHCI_TIMEOUT_CONTROL register and max busy timeout it supports is 11s in finite busy wait mode. Some operations like SLEEP_AWAKE, ERASE and flush cache through SWITCH commands take longer than 11s and Tegra host supports infinite HW busy wait mode where HW waits forever till the card is busy without HW timeout. This patch implements Tegra specific set_timeout sdhci_ops to allow switching between finite and infinite HW busy detection wait modes based on the device command expected operation time. Signed-off-by: Sowjanya Komatineni --- drivers/mmc/host/sdhci-tegra.c | 31 +++++++++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/drivers/mmc/host/sdhci-tegra.c b/drivers/mmc/host/sdhci-tegra.c index a25c3a4..fa8f6a4 100644 --- a/drivers/mmc/host/sdhci-tegra.c +++ b/drivers/mmc/host/sdhci-tegra.c @@ -45,6 +45,7 @@ #define SDHCI_TEGRA_CAP_OVERRIDES_DQS_TRIM_SHIFT 8 #define SDHCI_TEGRA_VENDOR_MISC_CTRL 0x120 +#define SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT BIT(0) #define SDHCI_MISC_CTRL_ENABLE_SDR104 0x8 #define SDHCI_MISC_CTRL_ENABLE_SDR50 0x10 #define SDHCI_MISC_CTRL_ENABLE_SDHCI_SPEC_300 0x20 @@ -1227,6 +1228,34 @@ static u32 sdhci_tegra_cqhci_irq(struct sdhci_host *host, u32 intmask) return 0; } +static void tegra_sdhci_set_timeout(struct sdhci_host *host, + struct mmc_command *cmd) +{ + u32 val; + + /* + * HW busy detection timeout is based on programmed data timeout + * counter and maximum supported timeout is 11s which may not be + * enough for long operations like cache flush, sleep awake, erase. + * + * ERASE_TIMEOUT_LIMIT bit of VENDOR_MISC_CTRL register allows + * host controller to wait for busy state until the card is busy + * without HW timeout. + * + * So, use infinite busy wait mode for operations that may take + * more than maximum HW busy timeout of 11s otherwise use finite + * busy wait mode. + */ + val = sdhci_readl(host, SDHCI_TEGRA_VENDOR_MISC_CTRL); + if (cmd && cmd->busy_timeout >= 11 * HZ) + val |= SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT; + else + val &= ~SDHCI_MISC_CTRL_ERASE_TIMEOUT_LIMIT; + sdhci_writel(host, val, SDHCI_TEGRA_VENDOR_MISC_CTRL); + + __sdhci_set_timeout(host, cmd); +} + static const struct cqhci_host_ops sdhci_tegra_cqhci_ops = { .write_l = tegra_cqhci_writel, .enable = sdhci_tegra_cqe_enable, @@ -1366,6 +1395,7 @@ static const struct sdhci_ops tegra210_sdhci_ops = { .set_uhs_signaling = tegra_sdhci_set_uhs_signaling, .voltage_switch = tegra_sdhci_voltage_switch, .get_max_clock = tegra_sdhci_get_max_clock, + .set_timeout = tegra_sdhci_set_timeout, }; static const struct sdhci_pltfm_data sdhci_tegra210_pdata = { @@ -1403,6 +1433,7 @@ static const struct sdhci_ops tegra186_sdhci_ops = { .voltage_switch = tegra_sdhci_voltage_switch, .get_max_clock = tegra_sdhci_get_max_clock, .irq = sdhci_tegra_cqhci_irq, + .set_timeout = tegra_sdhci_set_timeout, }; static const struct sdhci_pltfm_data sdhci_tegra186_pdata = { -- 2.7.4