Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp753708ybh; Wed, 11 Mar 2020 10:06:54 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtXoGsLNZK+ThZWxPhmeAzUCfNVmrZcseuHAECbrAoDFhPAA9kHu5WF4PdKRO+kiXZ9bVms X-Received: by 2002:a54:4e8d:: with SMTP id c13mr2653090oiy.27.1583946414669; Wed, 11 Mar 2020 10:06:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583946414; cv=none; d=google.com; s=arc-20160816; b=P9e2BjcRDGdvE2fEAOt5RT1DscEY8tw4a+f7SRj3qC4sEWRT9sJyuZRcFaKxR4IGlm 2cCIO3U57rx4akGDQSk7//2g04UKzhO2Q9nUdJCwNENmCtSVvzCuuDEZc8dAS0rE/C7b z2zTV5AWFK9rUJ1vNiVStQmuN7ib5F7Fky9QD1hod/j2wwqVRrCmNJeiSRuet5BQS1Yd m7U/0grqtoK4UwOzeNYtAeTv2o4gBUH1jnNzwqtfaNSVZw6/HrVrPOKultvY17b4m2Mr atLquvLN/t02RMe5gay0m0GCbxpGadKimHjjbvswkafvr4P1CqGmywkxGp9Ofhp0KUNv yJgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=jykx3cJByb3AWCb0WV64LkUlnx3R9Hi3e1lE7ij8ROg=; b=hYrnHmVJD2FnnYHg0sw/LVQ0Dn1Qj+TUjfxQzhh3F8/MVhsCnvmgw3h3pVTnFtz3fn 7vQe2A+zqLsiLk914QzomDPhOiKQFntkrrM2douejXGTKlaQK5YdEC1n8B3x6Lq++lOX ay2K4GHLiqoH9sz+7OA7n/yAReVyQBHG2h36h8zNl9i2xhON0f8+auFtQPxcxob5vqH3 gY7tHVNhysOeRqrbaHh89ojAqxJ6sWIkUnU5EZBN/LRITgKKOKOv8nT07CacxzFXljCv kOJRViXDrLytxIjj3+eQSZ5u1oS09i8++5/ohKDDPIk/jgz8bUdY246WOM8Vcc/n3SjF LGhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XSWOdsI7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z24si1396902otm.188.2020.03.11.10.06.32; Wed, 11 Mar 2020 10:06:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XSWOdsI7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730251AbgCKREq (ORCPT + 99 others); Wed, 11 Mar 2020 13:04:46 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:45465 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729675AbgCKREp (ORCPT ); Wed, 11 Mar 2020 13:04:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583946284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jykx3cJByb3AWCb0WV64LkUlnx3R9Hi3e1lE7ij8ROg=; b=XSWOdsI7jKXGkxrXUz+LY5oZdm1+A3z30b0kLKFdo823TlBRLLUqTsBd+bcDZIabFwC1Ig 5c/VL2s/FGhWhSl/6DWxfhyoo0hCVTjrDIDrz91fufSlkU6RBWhUDSSK4YspLSiPy2i33o Gc50xMUqvnZLKtE9DFesBAw6tIWBQmk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-451-fylXbBEaNUCy-xrSG-2R-A-1; Wed, 11 Mar 2020 13:04:39 -0400 X-MC-Unique: fylXbBEaNUCy-xrSG-2R-A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 07B451937FC0; Wed, 11 Mar 2020 17:04:38 +0000 (UTC) Received: from elisabeth (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E1755D9C5; Wed, 11 Mar 2020 17:04:34 +0000 (UTC) Date: Wed, 11 Mar 2020 18:04:28 +0100 From: Stefano Brivio To: Shreeya Patel Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl, Larry.Finger@lwfinger.net Subject: Re: [Outreachy kernel] [PATCH v4] Staging: rtl8188eu: rtw_mlme: Add space around operators Message-ID: <20200311180428.6489fe9b@elisabeth> In-Reply-To: <20200311131742.31068-1-shreeya.patel23498@gmail.com> References: <20200311131742.31068-1-shreeya.patel23498@gmail.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Mar 2020 18:47:42 +0530 Shreeya Patel wrote: > Add space around operators for improving the code > readability. > Reported by checkpatch.pl > > git diff -w shows no difference. > diff of the .o files before and after the changes shows no difference. > > Signed-off-by: Shreeya Patel This looks good to me. Further clean-ups here could probably make this look less messy (there are long lines, unnecessary parentheses that are rather confusing, especially on that 4/5 factor, "magic" constants that might make sense to figure out the meaning of, etc.). Reviewed-by: Stefano Brivio -- Stefano