Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp758122ybh; Wed, 11 Mar 2020 10:11:48 -0700 (PDT) X-Google-Smtp-Source: ADFU+vsmlJD5N/BmOrsWBxRhF2JaGTNQD8TxDHJRnH99kzzbDFl7RvyHZZasoiFEhcNHZxAp+LfX X-Received: by 2002:a9d:12b4:: with SMTP id g49mr3269992otg.50.1583946708025; Wed, 11 Mar 2020 10:11:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583946708; cv=none; d=google.com; s=arc-20160816; b=krtQXK5dCteb0MJMZFDwQZz+vbbag7qqet6k0FHOoeSAR/tKBHr/K63nZ+XwRA0hh5 7c9qFHw13OzZUocVB/Tw6D1QTUlUf1eTXOaGNTN0Qd+RaWV56CDeHKZXypCtQkSnIDGk FdLaPLctWyQY1S5Iysk5eHoavLC11oEIRixsJ2SBO37SiS51Uwi2kv4lBIOxvuLnC7CV 4wef2P6AlIBZUVjh7ZOy/oghrYln73vjzVotvE47jMruPe+FPplifGs1RbN0FBNzUKjX 2hxxbXEfURp1W83r8ZWQtb6ejQxUURbkpy9VJdOL4rzFG1juLhlrvRx37xc6/xXbUQas /nUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=MmvQnFre9q44tGApF0Zup0WXa8stb70tDzeRZGHdiYU=; b=L7VSuzWKu5jUteAYlM1yqv6la5Ks2V1zleqG4Vh48S6VaRFNuAH8BTxUzyRd2agThr j/QqEbVt5jN8RfEbwKVdEN65MnqLonVH/ZqgZ85+9lw4ImsGmAZviyQqCnPYthB5U0ol +rsvu6TMoambE5occUeGC48PsAgKzgvQtbeyrzYqj+Lh4GZ5K1qz9jAOO+GMzUpV6FlJ M20hHUsIpzwm2gNVuEwCcy4tKs6f9rhmUTfZmeIX/gEhorCQSzrw0SLTt6nIFtzUv4Oo sVyFR1z8DJQAkd/guWYgOJJ8Kf46pjlgzXKYP6QUyNT97jzT84fmO6+Y9B26aKLEW8T2 LXSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R2A7Rv8F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t3si416174ooc.23.2020.03.11.10.11.36; Wed, 11 Mar 2020 10:11:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R2A7Rv8F; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730406AbgCKRKO (ORCPT + 99 others); Wed, 11 Mar 2020 13:10:14 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:34704 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730258AbgCKRKN (ORCPT ); Wed, 11 Mar 2020 13:10:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583946613; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MmvQnFre9q44tGApF0Zup0WXa8stb70tDzeRZGHdiYU=; b=R2A7Rv8FE+EbZLY6UBeZamIzmV0rrAaj1HXZb6RXoPr6xBNNKf4hjA5nwFSC3Sqhlrda9f 51RUyd7ZZ00KvFXGTUUrl/r8c6HpTui177Jt/bDj3gE/liJibp1GEHmcJ6zSTCTT3UuohO rAEqAIosfguLvg0WZtf/4qm7wid3Fzc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-457-_5UnDH7BNqOVzCkG15BNyg-1; Wed, 11 Mar 2020 13:10:09 -0400 X-MC-Unique: _5UnDH7BNqOVzCkG15BNyg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A7A20107ACC4; Wed, 11 Mar 2020 17:10:07 +0000 (UTC) Received: from elisabeth (ovpn-200-42.brq.redhat.com [10.40.200.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E65288D553; Wed, 11 Mar 2020 17:10:03 +0000 (UTC) Date: Wed, 11 Mar 2020 18:09:57 +0100 From: Stefano Brivio To: Shreeya Patel Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com, daniel.baluta@gmail.com, nramas@linux.microsoft.com, hverkuil@xs4all.nl, Larry.Finger@lwfinger.net Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: sdio_halinit: Remove unnecessary conditions Message-ID: <20200311180957.0710195e@elisabeth> In-Reply-To: <20200311133811.2246-1-shreeya.patel23498@gmail.com> References: <20200311133811.2246-1-shreeya.patel23498@gmail.com> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Mar 2020 19:08:11 +0530 Shreeya Patel wrote: > Remove if and else conditions since both are leading to the > initialization of "valueDMATimeout" and "valueDMAPageCount" with > the same value. > > Found using coccinelle script. > > Signed-off-by: Shreeya Patel Reviewed-by: Stefano Brivio -- Stefano