Received: by 2002:a25:e7d8:0:0:0:0:0 with SMTP id e207csp846011ybh; Wed, 11 Mar 2020 12:01:24 -0700 (PDT) X-Google-Smtp-Source: ADFU+vtmfVLjc+EvTZbANPstjlZQsYOzv1sQKEebjNyrw80hDKbsp2judOZknLeO06Q63StV9qsc X-Received: by 2002:a9d:66d1:: with SMTP id t17mr3307644otm.235.1583953284187; Wed, 11 Mar 2020 12:01:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583953284; cv=none; d=google.com; s=arc-20160816; b=riKCSskDkvT3ksBhlooem4MPivH2tleb363Lp9ThBNLH8t1KIlvojZEuQZFYb09wWW 5Gm0xc2iPqv4MZQ6T3FDtUV8xGdrViLsePTPDpgmB5m64SRAyIqYL3BQv7CNi79w3lAU hPNAx3r52gv2XHEkdun6mjMatFlZNmN0EZEUPC862n3eJ22ssKCrK2swjADffKIjnqB8 PlXB7qQQTs2zPuGU3Gv+FDoxDcajX12NzN3xC81djLYjUlqR4H8fw1OgNTHMUHgD5Lno HIb5MclkU/OoT46nYhxrHxsqG9VcoBo1eFFoP1D5RIBtYQAcBf2n6Hm547xn11MAmwkb 4uMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id; bh=ybBA0nCZB3x5UQzqmjqtVz1aiW5wpEDfoJ7018umms0=; b=N/ZGwYH7rgbgvkVEUGjnwSeVfc41b1vzeSbyQN8D8M4+8VXPGwG2+ISowWzfaX8JCi UrXe4Bo+qdJBvAukdqcAVSPhCELIueW+t20lDyszlps41a0Uu+yeCiKABtSvnlluaWGV Xefi7ILj90YG8aR66hCQ5Yw73f2NaVmDC44iH4TKEkhN/Y/XXZC0DKgYLJdZ9vlyRMWZ evl4znXmMS/QIHiv8TacKnQtuKuZZoFqAOAbGSVhU6DaO5ab4ek1yfF0ol2Vpq8gxEBv fIv/8brED1Znt2Eu1RXYQqLYG5mspqr8SUffaz28BktgMwGOpD3C9fc2qRSNZhSfGkDV ImmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i8si547778oou.32.2020.03.11.12.01.08; Wed, 11 Mar 2020 12:01:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730958AbgCKS7H (ORCPT + 99 others); Wed, 11 Mar 2020 14:59:07 -0400 Received: from mga01.intel.com ([192.55.52.88]:25674 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730734AbgCKS7H (ORCPT ); Wed, 11 Mar 2020 14:59:07 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Mar 2020 11:59:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,541,1574150400"; d="scan'208";a="234797582" Received: from sai-dev-mach.sc.intel.com ([143.183.140.153]) by fmsmga007.fm.intel.com with ESMTP; 11 Mar 2020 11:59:06 -0700 Message-ID: Subject: Re: [PATCH V1 01/13] selftests/resctrl: Fix feature detection From: Sai Praneeth Prakhya To: Reinette Chatre , "shuah@kernel.org" , "linux-kselftest@vger.kernel.org" Cc: "tglx@linutronix.de" , "mingo@redhat.com" , "bp@alien8.de" , "Luck, Tony" , "babu.moger@amd.com" , "james.morse@arm.com" , "Shankar, Ravi V" , "Yu, Fenghua" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 11 Mar 2020 11:54:19 -0700 In-Reply-To: <518831ab-0f4e-5c5c-10c2-52c5f8492df1@intel.com> References: <7e3e4b91f5786a489e68eecda21e1d8049b60181.1583657204.git.sai.praneeth.prakhya@intel.com> <664cf142449b0a1ef7f09d04111f96ff84738e28.camel@intel.com> <518831ab-0f4e-5c5c-10c2-52c5f8492df1@intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Reinette, On Wed, 2020-03-11 at 11:45 -0700, Reinette Chatre wrote: > Hi Sai, > > On 3/11/2020 11:22 AM, Sai Praneeth Prakhya wrote: > > Hi Reinette, > > > > On Wed, 2020-03-11 at 11:06 -0700, Reinette Chatre wrote: > > > Hi Sai, > > > > > > On 3/9/2020 3:51 PM, Prakhya, Sai Praneeth wrote: > > > > > -----Original Message----- > > > > > From: Reinette Chatre > > > > > Sent: Monday, March 9, 2020 3:34 PM > > > > > > > > [SNIP] > > > > > > > > > > That's a good point and makes sense to me. I think we could fix it > > > > > > in > > > > > > two ways 1. grep for strings in dmesg but that will still leave > > > > > > ambiguity in deciding b/w mbm and cqm because kernel prints > > > > > > "resctrl: > > > > > > L3 > > > > > monitoring detected" for both the features 2. Check in "info" > > > > > directory > > > > > > a. For cat_l3, we could search for info/L3 > > > > > > b. For mba, we could search for info/MB > > > > > > c. For cqm and mbm, we could search for specified string in > > > > > > info/L3_MON/mon_features > > > > > > > > > > > > I think option 2 might be better because it can handle all cases, > > > > > > please let me > > > > > know what you think. > > > > > > > > > > I agree. For the reasons you mention and also that (1) may not be > > > > > possible if the > > > > > loglevel prevents those lines from being printed. > > > > > > > > Makes sense. I will work on the fix. > > > > > > One more note about this ... from what I can tell the test for a feature > > > currently fails if the platform does not support the feature. Would it > > > be possible to just skip the test in this case instead? > > > > That's because the output of the test should be just "ok" or "not ok". > > The output could be something like: > > ok MBA # SKIP MBA is not supported Makes sense.. I will fix it. > > I can change it to something like "# Skip because platform > > doesn't > > support the feature", but not really sure if it complies with TAP 13 > > protocol. > > Please consider the "skip" directive at > https://testanything.org/tap-version-13-specification.html Sure! thanks for the link :) Regards, Sai